test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Tang, HaifengX" <haifengx.tang@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH 1/2] add TestSuite_pmdpcap into dts
Date: Thu, 24 Sep 2015 02:46:49 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E10F052E3@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <DF029FFF923C334FAA58CEEB2979DCA601607828@SHSMSX104.ccr.corp.intel.com>

Ok, please do not forget it.

> -----Original Message-----
> From: Tang, HaifengX
> Sent: Thursday, September 24, 2015 10:46 AM
> To: Liu, Yong; dts@dpdk.org
> Subject: RE: [dts] [PATCH 1/2] add TestSuite_pmdpcap into dts
> 
> 
> Hi yong :
> 
> You can merge the patch first. I will submit another patch to add the
> suite into cfg file .
> 
> 
> thanks
> -----Original Message-----
> From: Liu, Yong
> Sent: Wednesday, September 23, 2015 10:30 AM
> To: Tang, HaifengX; dts@dpdk.org
> Subject: Re: [dts] [PATCH 1/2] add TestSuite_pmdpcap into dts
> 
> Haifeng,
> Please add this case into default execution file.
> 
> On 09/22/2015 03:23 PM, haifeng wrote:
> > Signed-off-by: haifeng <haifengx.tang@intel.com>
> > ---
> >   tests/TestSuite_pmdpcap.py | 186
> +++++++++++++++++++++++++++++++++++++++++++++
> >   1 file changed, 186 insertions(+)
> >   create mode 100644 tests/TestSuite_pmdpcap.py
> >
> > diff --git a/tests/TestSuite_pmdpcap.py b/tests/TestSuite_pmdpcap.py
> > new file mode 100644 index 0000000..41e2cfe
> > --- /dev/null
> > +++ b/tests/TestSuite_pmdpcap.py
> > @@ -0,0 +1,186 @@
> > +# BSD LICENSE
> > +#
> > +# Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
> > +# All rights reserved.
> > +#
> > +# Redistribution and use in source and binary forms, with or without
> > +# modification, are permitted provided that the following conditions
> > +# are met:
> > +#
> > +#   * Redistributions of source code must retain the above copyright
> > +#     notice, this list of conditions and the following disclaimer.
> > +#   * Redistributions in binary form must reproduce the above copyright
> > +#     notice, this list of conditions and the following disclaimer in
> > +#     the documentation and/or other materials provided with the
> > +#     distribution.
> > +#   * Neither the name of Intel Corporation nor the names of its
> > +#     contributors may be used to endorse or promote products derived
> > +#     from this software without specific prior written permission.
> > +#
> > +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> > +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT #
> > +LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
> > +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
> > +COPYRIGHT # OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
> > +INCIDENTAL, # SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
> > +(INCLUDING, BUT NOT # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
> > +SERVICES; LOSS OF USE, # DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
> > +HOWEVER CAUSED AND ON ANY # THEORY OF LIABILITY, WHETHER IN CONTRACT,
> > +STRICT LIABILITY, OR TORT # (INCLUDING NEGLIGENCE OR OTHERWISE)
> > +ARISING IN ANY WAY OUT OF THE USE # OF THIS SOFTWARE, EVEN IF ADVISED
> OF THE POSSIBILITY OF SUCH DAMAGE.
> > +
> > +'''
> > +'''
> > +from test_case import TestCase
> > +import dts
> > +
> > +from time import sleep
> > +from scapy.all import *
> > +
> > +
> > +#
> > +#
> > +# Test class.
> > +#
> > +class TestPmdPcap(TestCase):
> > +
> > +    pcap_file_sizes = [1000, 500]
> > +    dut_pcap_files_path = '/root/'
> > +
> > +    def set_up_all(self):
> > +        self.check_scapy_in_dut()
> > +
> > +        self.memory_channel = self.dut.get_memory_channels()
> > +
> > +        # Enable PCAP features and rebuild the package
> > +        self.pcap_config = self.get_pcap_compile_config()
> > +        self.dut.send_expect(
> > +            "sed -i
> 's/CONFIG_RTE_LIBRTE_PMD_PCAP=n$/CONFIG_RTE_LIBRTE_PMD_PCAP=y/'
> config/%s" % self.pcap_config, "# ")
> > +        self.dut.build_install_dpdk(self.target)
> > +
> > +        # make sure there is no interface to bind
> > +        # because if there is any interface bonded to igb_uio,
> > +        # it will result in packet transmiting failed
> > +        self.dut.restore_interfaces()
> > +
> > +    def get_pcap_compile_config(self):
> > +        config_head = "common_"
> > +        os_type = self.dut.get_os_type()
> > +        if os_type == "linux":
> > +            config_tail = os_type + "app"
> > +        elif os_type == "freebsd":
> > +            config_tail = "bsdapp"
> > +        else:
> > +            raise Exception(
> > +                "Unknow os type, please check to make sure pcap can
> > + work in OS [ %s ]" % os_type)
> > +
> > +        return config_head + config_tail
> > +
> > +    def create_pcap_file(self, filename, number_of_packets):
> > +        flow = []
> > +        for pkt_id in range(number_of_packets):
> > +            pkt_id = str(hex(pkt_id % 256))
> > +            flow.append(Ether(src='00:00:00:00:00:%s' % pkt_id[2:],
> dst='00:00:00:00:00:00') / IP(
> > +                src='192.168.1.1', dst='192.168.1.2') / ("X" * 26))
> > +
> > +        wrpcap(filename, flow)
> > +
> > +    def check_scapy_in_dut(self):
> > +        try:
> > +            self.dut.send_expect('scapy', '>>> ')
> > +            self.dut.send_expect('quit()', '# ')
> > +        except:
> > +            self.verify(False, 'Scapy is required in dut.')
> > +
> > +    def check_pcap_files(self, in_pcap, out_pcap, expected_frames):
> > +
> > +        # Check if the number of expected frames are in the output
> > +        result = self.dut.send_expect(
> > +            'tcpdump -n -e -r %s | wc -l' % out_pcap, '# ')
> > +        self.verify(str(expected_frames) in result,
> > +                    'Not all packets have been forwarded')
> > +
> > +        # Check if the frames in the input and output files match
> > +        self.dut.send_expect('scapy', '>>> ')
> > +        self.dut.send_expect('input=rdpcap("%s")' % in_pcap, '>>> ')
> > +        self.dut.send_expect('output=rdpcap("%s")' % out_pcap, '>>> ')
> > +        self.dut.send_expect(
> > +            'result=[input[i]==output[i] for i in xrange(len(input))]',
> '>>> ')
> > +        result = self.dut.send_expect('False in result', '>>> ')
> > +        self.dut.send_expect('quit()', '# ')
> > +
> > +        self.verify('True' not in result, 'In/Out packets do not
> > + match.')
> > +
> > +    def test_send_packets_with_one_device(self):
> > +        in_pcap = 'in_pmdpcap.pcap'
> > +        out_pcap = '/tmp/out_pmdpcap.pcap'
> > +
> > +        two_cores = self.dut.get_core_list("1S/2C/1T")
> > +        core_mask = dts.create_mask(two_cores)
> > +
> > +        self.create_pcap_file(in_pcap, TestPmdPcap.pcap_file_sizes[0])
> > +        self.dut.session.copy_file_to(in_pcap)
> > +
> > +        command = ("./{}/app/testpmd -c {} -n {} " +
> > +                   "--vdev=eth_pcap0,rx_pcap={},tx_pcap={} " +
> > +                   "-- -i --port-topology=chained")
> > +
> > +        self.dut.send_expect(command.format(self.target, core_mask,
> > +                             self.memory_channel,
> > +                             TestPmdPcap.dut_pcap_files_path + in_pcap,
> > +                             out_pcap), 'testpmd> ', 15)
> > +
> > +        self.dut.send_expect('start', 'testpmd> ')
> > +        sleep(2)
> > +        self.dut.send_expect('stop', 'testpmd> ')
> > +        self.dut.send_expect('quit', '# ')
> > +
> > +        self.check_pcap_files(TestPmdPcap.dut_pcap_files_path + in_pcap,
> > +                              out_pcap,
> > + TestPmdPcap.pcap_file_sizes[0])
> > +
> > +    def test_send_packets_with_two_devices(self):
> > +
> > +        in_pcap1 = 'in1_pmdpcap.pcap'
> > +        out_pcap1 = '/tmp/out1_pmdpcap.pcap'
> > +
> > +        in_pcap2 = 'in2_pmdpcap.pcap'
> > +        out_pcap2 = '/tmp/out2_pmdpcap.pcap'
> > +
> > +        four_cores = self.dut.get_core_list("1S/4C/1T")
> > +        core_mask = dts.create_mask(four_cores)
> > +
> > +        self.create_pcap_file(in_pcap1, TestPmdPcap.pcap_file_sizes[0])
> > +        self.dut.session.copy_file_to(in_pcap1)
> > +        self.create_pcap_file(in_pcap2, TestPmdPcap.pcap_file_sizes[1])
> > +        self.dut.session.copy_file_to(in_pcap2)
> > +
> > +        command = ("./{}/app/testpmd -c {} -n {} " +
> > +                   "--vdev=eth_pcap0,rx_pcap={},tx_pcap={} " +
> > +                   "--vdev=eth_pcap1,rx_pcap={},tx_pcap={} " +
> > +                   "-- -i")
> > +
> > +        self.dut.send_expect(command.format(self.target, core_mask,
> > +                                            self.memory_channel,
> > +
> TestPmdPcap.dut_pcap_files_path +
> > +                                            in_pcap1,
> > +                                            out_pcap1,
> > +
> TestPmdPcap.dut_pcap_files_path +
> > +                                            in_pcap2,
> > +                                            out_pcap2), 'testpmd> ',
> > + 10)
> > +
> > +        self.dut.send_expect('start', 'testpmd> ')
> > +        sleep(2)
> > +        self.dut.send_expect('stop', 'testpmd> ')
> > +        self.dut.send_expect('quit', '# ')
> > +
> > +        self.check_pcap_files(TestPmdPcap.dut_pcap_files_path +
> in_pcap1,
> > +                              out_pcap2,
> > + TestPmdPcap.pcap_file_sizes[0])
> > +
> > +        self.check_pcap_files(TestPmdPcap.dut_pcap_files_path +
> in_pcap2,
> > +                              out_pcap1,
> > + TestPmdPcap.pcap_file_sizes[1])
> > +
> > +    def tear_down_all(self):
> > +        # Disable PCAP feature and rebuild the package
> > +        self.dut.send_expect(
> > +            "sed -i
> 's/CONFIG_RTE_LIBRTE_PMD_PCAP=y$/CONFIG_RTE_LIBRTE_PMD_PCAP=n/'
> config/%s" % self.pcap_config, "# ")
> > +        self.dut.set_target(self.target)

      reply	other threads:[~2015-09-24  2:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-22  7:23 haifeng
2015-09-22  7:23 ` [dts] [PATCH 2/2] add TestSuite_pmdpcap rst " haifeng
2015-09-23  2:29 ` [dts] [PATCH 1/2] add TestSuite_pmdpcap " Liu, Yong
2015-09-24  2:46   ` Tang, HaifengX
2015-09-24  2:46     ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E10F052E3@SHSMSX101.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=haifengx.tang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).