test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Qiu, Michael" <michael.qiu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH] framework/dut: Fix upper and lower for MAC address
Date: Tue, 13 Oct 2015 09:19:15 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E10F27D28@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1444717254-32269-1-git-send-email-michael.qiu@intel.com>

Exactly, our configuration should have the ability to handle same configuration with different formats. 
Thanks, applied.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Michael Qiu
> Sent: Tuesday, October 13, 2015 8:21 AM
> To: dts@dpdk.org
> Subject: [dts] [PATCH] framework/dut: Fix upper and lower for MAC address
> 
> When MAC address are actually the same but different upper and lower,
> it should be take as the same.
> 
> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> ---
>  framework/dut.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/framework/dut.py b/framework/dut.py
> index 1199fc6..70bd146 100644
> --- a/framework/dut.py
> +++ b/framework/dut.py
> @@ -778,9 +778,9 @@ class Dut(Crb):
> 
>              for key in ['intf', 'mac', 'numa', 'peer', 'source']:
>                  if key in port_cfg:
> -                    if key in port and port_cfg[key] != port[key]:
> +                    if key in port and port_cfg[key].lower() !=
> port[key].lower():
>                          self.logger.warning("CONFIGURED %s NOT SAME AS
> SCANNED!!!" % (key.upper()))
> -                    port[key] = port_cfg[key]
> +                    port[key] = port_cfg[key].lower()
> 
>      def map_available_ports(self):
>          """
> --
> 1.9.3

      reply	other threads:[~2015-10-13  9:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-13  6:20 Michael Qiu
2015-10-13  9:19 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E10F27D28@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=michael.qiu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).