test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] framework/dut: Fix upper and lower for MAC address
@ 2015-10-13  6:20 Michael Qiu
  2015-10-13  9:19 ` Liu, Yong
  0 siblings, 1 reply; 2+ messages in thread
From: Michael Qiu @ 2015-10-13  6:20 UTC (permalink / raw)
  To: dts

When MAC address are actually the same but different upper and lower,
it should be take as the same.

Signed-off-by: Michael Qiu <michael.qiu@intel.com>
---
 framework/dut.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/framework/dut.py b/framework/dut.py
index 1199fc6..70bd146 100644
--- a/framework/dut.py
+++ b/framework/dut.py
@@ -778,9 +778,9 @@ class Dut(Crb):
 
             for key in ['intf', 'mac', 'numa', 'peer', 'source']:
                 if key in port_cfg:
-                    if key in port and port_cfg[key] != port[key]:
+                    if key in port and port_cfg[key].lower() != port[key].lower():
                         self.logger.warning("CONFIGURED %s NOT SAME AS SCANNED!!!" % (key.upper()))
-                    port[key] = port_cfg[key]
+                    port[key] = port_cfg[key].lower()
 
     def map_available_ports(self):
         """
-- 
1.9.3

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH] framework/dut: Fix upper and lower for MAC address
  2015-10-13  6:20 [dts] [PATCH] framework/dut: Fix upper and lower for MAC address Michael Qiu
@ 2015-10-13  9:19 ` Liu, Yong
  0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2015-10-13  9:19 UTC (permalink / raw)
  To: Qiu, Michael, dts

Exactly, our configuration should have the ability to handle same configuration with different formats. 
Thanks, applied.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Michael Qiu
> Sent: Tuesday, October 13, 2015 8:21 AM
> To: dts@dpdk.org
> Subject: [dts] [PATCH] framework/dut: Fix upper and lower for MAC address
> 
> When MAC address are actually the same but different upper and lower,
> it should be take as the same.
> 
> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> ---
>  framework/dut.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/framework/dut.py b/framework/dut.py
> index 1199fc6..70bd146 100644
> --- a/framework/dut.py
> +++ b/framework/dut.py
> @@ -778,9 +778,9 @@ class Dut(Crb):
> 
>              for key in ['intf', 'mac', 'numa', 'peer', 'source']:
>                  if key in port_cfg:
> -                    if key in port and port_cfg[key] != port[key]:
> +                    if key in port and port_cfg[key].lower() !=
> port[key].lower():
>                          self.logger.warning("CONFIGURED %s NOT SAME AS
> SCANNED!!!" % (key.upper()))
> -                    port[key] = port_cfg[key]
> +                    port[key] = port_cfg[key].lower()
> 
>      def map_available_ports(self):
>          """
> --
> 1.9.3

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-10-13  9:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-13  6:20 [dts] [PATCH] framework/dut: Fix upper and lower for MAC address Michael Qiu
2015-10-13  9:19 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).