From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 9621F5A64 for ; Wed, 14 Oct 2015 12:19:58 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 14 Oct 2015 03:19:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,681,1437462000"; d="scan'208";a="810697228" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga001.fm.intel.com with ESMTP; 14 Oct 2015 03:19:57 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 14 Oct 2015 03:19:57 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 14 Oct 2015 03:19:57 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.204]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.96]) with mapi id 14.03.0248.002; Wed, 14 Oct 2015 18:19:52 +0800 From: "Liu, Yong" To: "Qiu, Michael" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH] jumboframes: Fix bug for fm10k NIC Thread-Index: AQHRBi6d16cx257/zE+yerjzHPKDE55qxuVQ Date: Wed, 14 Oct 2015 10:19:51 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E10F2AE87@SHSMSX103.ccr.corp.intel.com> References: <1444792509-19136-1-git-send-email-michael.qiu@intel.com> In-Reply-To: <1444792509-19136-1-git-send-email-michael.qiu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH] jumboframes: Fix bug for fm10k NIC X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2015 10:19:59 -0000 Hi Michael, Same comment, we have excel file tracking those features what we do not sup= port. For the RRC Testpoint, I think we need implement one structure for this. We= cannot reply on manual commands to run DTS. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Michael Qiu > Sent: Wednesday, October 14, 2015 4:15 AM > To: dts@dpdk.org > Subject: [dts] [PATCH] jumboframes: Fix bug for fm10k NIC >=20 > For Ruby Rapid, in Testpoint should run "set port config 1,5 > max_frame_size 9000" > and "set port config 1,5,20,22 rx_cut_through off" >=20 > Singed-off-by: Michael Qiu > --- > tests/TestSuite_jumboframes.py | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) >=20 > diff --git a/tests/TestSuite_jumboframes.py > b/tests/TestSuite_jumboframes.py > index c5c70b9..e9a6abf 100644 > --- a/tests/TestSuite_jumboframes.py > +++ b/tests/TestSuite_jumboframes.py > @@ -93,7 +93,9 @@ class TestJumboframes(TestCase): > p1rx_err -=3D gp1rx_err >=20 > if received: > - self.verify(p0tx_pkts =3D=3D p1rx_pkts and p0tx_bytes =3D=3D= pktsize > and p1rx_bytes =3D=3D pktsize, > + #some nic like RRC always strip CRC, so it should be pktsize > - 4 > + size_equal =3D p0tx_bytes =3D=3D p1rx_bytes and (p1rx_bytes = =3D=3D > pktsize or p1rx_bytes =3D=3D pktsize - 4) > + self.verify(p0tx_pkts =3D=3D p1rx_pkts and size_equal, > "packet pass assert error") > else: > #self.verify(p0tx_pkts =3D=3D p1rx_pkts and (p1rx_err =3D=3D= 1 or > p1rx_pkts =3D=3D 0), > @@ -152,10 +154,12 @@ class TestJumboframes(TestCase): > This case aims to test transmitting jumbo frame packet on testpm= d > without > jumbo frame support. > """ > - self.pmdout.start_testpmd("Default", "--max-pkt-len=3D%d" % > (ETHER_STANDARD_MTU)) > + # RRC has no ability to set the max pkt len to hardware > if self.nic =3D=3D "redrockcanyou": > - self.dut.send_expect("set promisc all off", "testpmd> ") > - self.dut.send_expect("set fwd mac", "testpmd> ") > + print dts.RED("fm10k not support this case\n") > + return > + self.pmdout.start_testpmd("Default", "--max-pkt-len=3D%d" % > (ETHER_STANDARD_MTU)) > + self.dut.send_expect("set fwd mac", "testpmd> ") > self.dut.send_expect("start", "testpmd> ") >=20 > self.jumboframes_send_packet(ETHER_STANDARD_MTU + 1, False) > -- > 1.9.3