test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [patch] ironpond , twinpond and springfountain 's mbuf is 2048, not 1024
@ 2015-10-15  4:24 lijuan tu
  2015-10-20  2:22 ` Liu, Yong
  0 siblings, 1 reply; 5+ messages in thread
From: lijuan tu @ 2015-10-15  4:24 UTC (permalink / raw)
  To: dts

Signed-off-by: lijuan tu <lijuanx.a.tu@intel.com>
---
 tests/TestSuite_scatter.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_scatter.py b/tests/TestSuite_scatter.py
index abb1a08..1bec2c8 100644
--- a/tests/TestSuite_scatter.py
+++ b/tests/TestSuite_scatter.py
@@ -55,7 +55,7 @@ class TestScatter(TestCase):
         # Verify that enough ports are available
         self.verify(len(dutPorts) >= 2, "Insufficient ports")
         self.pmdout = PmdOutput(self.dut)
-        if self.nic in ["niantic", "fortville_eagle", "fortville_spirit", "fortville_spirit_single", "redrockcanyou"]:
+        if self.nic in ["niantic", "fortville_eagle", "fortville_spirit", "fortville_spirit_single", "redrockcanyou", "ironpond", "twinpond", "springfountain"]:
             self.mbsize = 2048
         else:
             self.mbsize = 1024
-- 
2.1.0

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [patch] ironpond , twinpond and springfountain 's mbuf is 2048, not 1024
  2015-10-15  4:24 [dts] [patch] ironpond , twinpond and springfountain 's mbuf is 2048, not 1024 lijuan tu
@ 2015-10-20  2:22 ` Liu, Yong
  2015-10-20  3:04   ` Qiu, Michael
  0 siblings, 1 reply; 5+ messages in thread
From: Liu, Yong @ 2015-10-20  2:22 UTC (permalink / raw)
  To: Tu, LijuanX A, dts

Applied. Thx.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lijuan tu
> Sent: Thursday, October 15, 2015 12:25 PM
> To: dts@dpdk.org
> Subject: [dts] [patch] ironpond , twinpond and springfountain 's mbuf is
> 2048, not 1024
> 
> Signed-off-by: lijuan tu <lijuanx.a.tu@intel.com>
> ---
>  tests/TestSuite_scatter.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_scatter.py b/tests/TestSuite_scatter.py
> index abb1a08..1bec2c8 100644
> --- a/tests/TestSuite_scatter.py
> +++ b/tests/TestSuite_scatter.py
> @@ -55,7 +55,7 @@ class TestScatter(TestCase):
>          # Verify that enough ports are available
>          self.verify(len(dutPorts) >= 2, "Insufficient ports")
>          self.pmdout = PmdOutput(self.dut)
> -        if self.nic in ["niantic", "fortville_eagle", "fortville_spirit",
> "fortville_spirit_single", "redrockcanyou"]:
> +        if self.nic in ["niantic", "fortville_eagle", "fortville_spirit",
> "fortville_spirit_single", "redrockcanyou", "ironpond", "twinpond",
> "springfountain"]:
>              self.mbsize = 2048
>          else:
>              self.mbsize = 1024
> --
> 2.1.0

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [patch] ironpond , twinpond and springfountain 's mbuf is 2048, not 1024
  2015-10-20  2:22 ` Liu, Yong
@ 2015-10-20  3:04   ` Qiu, Michael
  2015-10-20  3:19     ` Liu, Yong
  0 siblings, 1 reply; 5+ messages in thread
From: Qiu, Michael @ 2015-10-20  3:04 UTC (permalink / raw)
  To: Liu, Yong; +Cc: dts

I have a question, which nic's default mbuf is 1024?
Thanks,
Michael

发自我的 iPhone

> 在 2015年10月20日,上午10:23,Liu, Yong <yong.liu@intel.com> 写道:
> 
> Applied. Thx.
> 
>> -----Original Message-----
>> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lijuan tu
>> Sent: Thursday, October 15, 2015 12:25 PM
>> To: dts@dpdk.org
>> Subject: [dts] [patch] ironpond , twinpond and springfountain 's mbuf is
>> 2048, not 1024
>> 
>> Signed-off-by: lijuan tu <lijuanx.a.tu@intel.com>
>> ---
>> tests/TestSuite_scatter.py | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/tests/TestSuite_scatter.py b/tests/TestSuite_scatter.py
>> index abb1a08..1bec2c8 100644
>> --- a/tests/TestSuite_scatter.py
>> +++ b/tests/TestSuite_scatter.py
>> @@ -55,7 +55,7 @@ class TestScatter(TestCase):
>>         # Verify that enough ports are available
>>         self.verify(len(dutPorts) >= 2, "Insufficient ports")
>>         self.pmdout = PmdOutput(self.dut)
>> -        if self.nic in ["niantic", "fortville_eagle", "fortville_spirit",
>> "fortville_spirit_single", "redrockcanyou"]:
>> +        if self.nic in ["niantic", "fortville_eagle", "fortville_spirit",
>> "fortville_spirit_single", "redrockcanyou", "ironpond", "twinpond",
>> "springfountain"]:
>>             self.mbsize = 2048
>>         else:
>>             self.mbsize = 1024
>> --
>> 2.1.0
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [patch] ironpond , twinpond and springfountain 's mbuf is 2048, not 1024
  2015-10-20  3:04   ` Qiu, Michael
@ 2015-10-20  3:19     ` Liu, Yong
  2015-10-20  4:45       ` Tu, LijuanX A
  0 siblings, 1 reply; 5+ messages in thread
From: Liu, Yong @ 2015-10-20  3:19 UTC (permalink / raw)
  To: Qiu, Michael; +Cc: dts

I'm not sure why use 2048 for some NICs. Anybody known about this?
Scatter feature is used when received packets over the size of mbuf. 
I think 1024 and 2048 should be the same to measure this feature.

> -----Original Message-----
> From: Qiu, Michael
> Sent: Tuesday, October 20, 2015 11:05 AM
> To: Liu, Yong
> Cc: Tu, LijuanX A; dts@dpdk.org
> Subject: Re: [dts] [patch] ironpond , twinpond and springfountain 's mbuf
> is 2048, not 1024
> 
> I have a question, which nic's default mbuf is 1024?
> Thanks,
> Michael
> 
> 发自我的 iPhone
> 
> > 在 2015年10月20日,上午10:23,Liu, Yong <yong.liu@intel.com> 写道:
> >
> > Applied. Thx.
> >
> >> -----Original Message-----
> >> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lijuan tu
> >> Sent: Thursday, October 15, 2015 12:25 PM
> >> To: dts@dpdk.org
> >> Subject: [dts] [patch] ironpond , twinpond and springfountain 's mbuf
> is
> >> 2048, not 1024
> >>
> >> Signed-off-by: lijuan tu <lijuanx.a.tu@intel.com>
> >> ---
> >> tests/TestSuite_scatter.py | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/tests/TestSuite_scatter.py b/tests/TestSuite_scatter.py
> >> index abb1a08..1bec2c8 100644
> >> --- a/tests/TestSuite_scatter.py
> >> +++ b/tests/TestSuite_scatter.py
> >> @@ -55,7 +55,7 @@ class TestScatter(TestCase):
> >>         # Verify that enough ports are available
> >>         self.verify(len(dutPorts) >= 2, "Insufficient ports")
> >>         self.pmdout = PmdOutput(self.dut)
> >> -        if self.nic in ["niantic", "fortville_eagle",
> "fortville_spirit",
> >> "fortville_spirit_single", "redrockcanyou"]:
> >> +        if self.nic in ["niantic", "fortville_eagle",
> "fortville_spirit",
> >> "fortville_spirit_single", "redrockcanyou", "ironpond", "twinpond",
> >> "springfountain"]:
> >>             self.mbsize = 2048
> >>         else:
> >>             self.mbsize = 1024
> >> --
> >> 2.1.0
> >

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [patch] ironpond , twinpond and springfountain 's mbuf is 2048, not 1024
  2015-10-20  3:19     ` Liu, Yong
@ 2015-10-20  4:45       ` Tu, LijuanX A
  0 siblings, 0 replies; 5+ messages in thread
From: Tu, LijuanX A @ 2015-10-20  4:45 UTC (permalink / raw)
  To: Liu, Yong, Qiu, Michael; +Cc: dts

I am not sure why too,but  test_plan_scatter may give us some inofmation:

Configuring the size of mbuf data buffers
=========================================
The default size of the mbuf data buffer is 2048 so that a full 1518-byte
(CRC included) Ethernet frame can be stored in a mono-segment packet.

-----Original Message-----
From: Liu, Yong 
Sent: Tuesday, October 20, 2015 11:19 AM
To: Qiu, Michael
Cc: Tu, LijuanX A; dts@dpdk.org
Subject: RE: [dts] [patch] ironpond , twinpond and springfountain 's mbuf is 2048, not 1024

I'm not sure why use 2048 for some NICs. Anybody known about this?
Scatter feature is used when received packets over the size of mbuf. 
I think 1024 and 2048 should be the same to measure this feature.

> -----Original Message-----
> From: Qiu, Michael
> Sent: Tuesday, October 20, 2015 11:05 AM
> To: Liu, Yong
> Cc: Tu, LijuanX A; dts@dpdk.org
> Subject: Re: [dts] [patch] ironpond , twinpond and springfountain 's 
> mbuf is 2048, not 1024
> 
> I have a question, which nic's default mbuf is 1024?
> Thanks,
> Michael
> 
> 发自我的 iPhone
> 
> > 在 2015年10月20日,上午10:23,Liu, Yong <yong.liu@intel.com> 写道:
> >
> > Applied. Thx.
> >
> >> -----Original Message-----
> >> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lijuan tu
> >> Sent: Thursday, October 15, 2015 12:25 PM
> >> To: dts@dpdk.org
> >> Subject: [dts] [patch] ironpond , twinpond and springfountain 's 
> >> mbuf
> is
> >> 2048, not 1024
> >>
> >> Signed-off-by: lijuan tu <lijuanx.a.tu@intel.com>
> >> ---
> >> tests/TestSuite_scatter.py | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/tests/TestSuite_scatter.py 
> >> b/tests/TestSuite_scatter.py index abb1a08..1bec2c8 100644
> >> --- a/tests/TestSuite_scatter.py
> >> +++ b/tests/TestSuite_scatter.py
> >> @@ -55,7 +55,7 @@ class TestScatter(TestCase):
> >>         # Verify that enough ports are available
> >>         self.verify(len(dutPorts) >= 2, "Insufficient ports")
> >>         self.pmdout = PmdOutput(self.dut)
> >> -        if self.nic in ["niantic", "fortville_eagle",
> "fortville_spirit",
> >> "fortville_spirit_single", "redrockcanyou"]:
> >> +        if self.nic in ["niantic", "fortville_eagle",
> "fortville_spirit",
> >> "fortville_spirit_single", "redrockcanyou", "ironpond", "twinpond",
> >> "springfountain"]:
> >>             self.mbsize = 2048
> >>         else:
> >>             self.mbsize = 1024
> >> --
> >> 2.1.0
> >

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-10-20  4:45 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-15  4:24 [dts] [patch] ironpond , twinpond and springfountain 's mbuf is 2048, not 1024 lijuan tu
2015-10-20  2:22 ` Liu, Yong
2015-10-20  3:04   ` Qiu, Michael
2015-10-20  3:19     ` Liu, Yong
2015-10-20  4:45       ` Tu, LijuanX A

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).