From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id D2FE88E8A for ; Wed, 4 Nov 2015 08:58:22 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 03 Nov 2015 23:58:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,241,1444719600"; d="scan'208";a="842729359" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 03 Nov 2015 23:58:21 -0800 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 3 Nov 2015 23:58:21 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 3 Nov 2015 23:58:21 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.56]) by shsmsx102.ccr.corp.intel.com ([169.254.2.199]) with mapi id 14.03.0248.002; Wed, 4 Nov 2015 15:58:19 +0800 From: "Liu, Yong" To: "Xu, HuilongX" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH] try fix scatter case failed Thread-Index: AQHRFsz7or2Bk5s+I02kUyR8goRkLZ6Lb7aA//+D1QCAAIgB0A== Date: Wed, 4 Nov 2015 07:58:18 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E10F4D919@SHSMSX103.ccr.corp.intel.com> References: <1446619498-39230-1-git-send-email-huilongx.xu@intel.com> <5639AD55.9080501@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH] try fix scatter case failed X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Nov 2015 07:58:23 -0000 Huilong, The timeout 60s is for foreground commands. You can see in scapy_execute fu= nction, dts only wait two seconds after all commands. I mean whether we should enlarge the timeout value here. Maybe you can try your solution on more platforms to make sure it can work. > -----Original Message----- > From: Xu, HuilongX > Sent: Wednesday, November 04, 2015 3:37 PM > To: Liu, Yong; dts@dpdk.org > Subject: RE: [dts] [PATCH] try fix scatter case failed >=20 > Hi yong, > The default timeout value is 60s in function scapy_execute, I think not > need enlarge timeout value. > In scatter case, I check the log find issue, but I'am not sure it can fix > when sleep 5 seconds, but it work normal on my test environment, although > run many test suites > Thanks a lot >=20 > > -----Original Message----- > > From: Liu, Yong > > Sent: Wednesday, November 04, 2015 3:02 PM > > To: Xu, HuilongX; dts@dpdk.org > > Subject: Re: [dts] [PATCH] try fix scatter case failed > > > > Hi Huilong, > > This issue look like that need wait for few seconds before scapy write > > the write value. > > My question is that should we enlarge the timeout value in function > > scapy_execute()? > > > > On 11/04/2015 02:44 PM, xu,huilong wrote: > > > form log, it looks the cat result.txt failed, so add a sleep for > python > > close file. > > > > > > Signed-off-by: xu,huilong > > > --- > > > tests/TestSuite_scatter.py | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/tests/TestSuite_scatter.py b/tests/TestSuite_scatter.py > > > index 1bec2c8..7a49b53 100644 > > > --- a/tests/TestSuite_scatter.py > > > +++ b/tests/TestSuite_scatter.py > > > @@ -36,6 +36,7 @@ Test Scattered Packets. > > > import dts > > > from test_case import TestCase > > > from pmd_output import PmdOutput > > > +import time > > > # > > > # > > > # Test class. > > > @@ -85,6 +86,7 @@ class TestScatter(TestCase): > > > self.tester.scapy_append( > > > > > 'sendp([Ether(src=3D"%s",dst=3D"%s")/IP(len=3D%s)/Raw(load=3D"\x50"*%s)= ], > > iface=3D"%s")' % (smac, dmac,pktlen, padding, sintf)) > > > self.tester.scapy_execute() > > > + time.sleep(5) > > > res =3D self.tester.scapy_get_result() > > > self.tester.send_expect("ifconfig %s mtu 1500" % sintf, "#"= ) > > > self.tester.send_expect("ifconfig %s mtu 1500" % sintf, "#"= )