test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Tu, LijuanX A" <lijuanx.a.tu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH] add time for scapy exec
Date: Wed, 4 Nov 2015 08:49:54 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E10F4DB68@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1446625100-39783-1-git-send-email-lijuanx.a.tu@intel.com>

Hi Lijuan,
It will waste our time to waiting 20 seconds in every execution command.  Maybe we can add one parameter for the timeout value. 

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Lijuan Tu
> Sent: Wednesday, November 04, 2015 4:18 PM
> To: dts@dpdk.org
> Subject: [dts] [PATCH] add time for scapy exec
> 
> Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
> ---
>  framework/tester.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/framework/tester.py b/framework/tester.py
> index 1f4f7ae..851c726 100644
> --- a/framework/tester.py
> +++ b/framework/tester.py
> @@ -367,12 +367,12 @@ class Tester(Crb):
>          if self.bgProcIsRunning:
>              self.send_expect('subprocess.call("scapy -c sniff.py &",
> shell=True)', ">>> ")
>              self.bgProcIsRunning = False
> -        sleep(2)
> +        sleep(10)
> 
>          for cmd in self.scapyCmds:
>              self.send_expect(cmd, ">>> ", timeout)
> 
> -        sleep(2)
> +        sleep(10)
>          self.scapyCmds = []
>          self.send_expect("exit()", "# ")
> 
> --
> 1.9.3

      reply	other threads:[~2015-11-04  8:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-04  8:18 Lijuan Tu
2015-11-04  8:49 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E10F4DB68@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=lijuanx.a.tu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).