From: "Liu, Yong" <yong.liu@intel.com>
To: "Fu, JingguoX" <jingguox.fu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [DTS][PATCH] fix result verify issue for crc in dpdk update
Date: Thu, 19 Nov 2015 07:18:00 +0000 [thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E10F6A6B4@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1447915905-21171-1-git-send-email-jingguox.fu@intel.com>
Hi Jingguo,
This fix may not work on other NICs, you can reference to function send_packet in shutdown_api suite.
The function also handled crc and vlan packet length in testpmd.
> -----Original Message-----
> From: Fu, JingguoX
> Sent: Thursday, November 19, 2015 2:52 PM
> To: dts@dpdk.org
> Cc: Liu, Yong; Xu, HuilongX; Fu, JingguoX
> Subject: [DTS][PATCH] fix result verify issue for crc in dpdk update
>
> Signed-off-by: Jingguo Fu <jingguox.fu@intel.com>
> ---
> tests/TestSuite_pmd.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/TestSuite_pmd.py b/tests/TestSuite_pmd.py
> index 29dec2b..740504f 100644
> --- a/tests/TestSuite_pmd.py
> +++ b/tests/TestSuite_pmd.py
> @@ -407,13 +407,13 @@ class TestPmd(TestCase,IxiaPacketGenerator):
> self.verify(p1rx_bytes == frame_size,
> "packet pass assert error, expected %d RX
> bytes, actual %d" % (frame_size, p1rx_bytes))
> else:
> - self.verify(p1rx_bytes == frame_size - 4,
> + self.verify(p1rx_bytes == frame_size,
> "packet pass assert error, expected %d RX
> bytes, actual %d" % (frame_size - 4, p1rx_bytes))
> else:
> self.verify(p1rx_bytes == frame_size,
> "packet pass assert error, expected %d RX bytes,
> actual %d" % (frame_size, p1rx_bytes))
>
> - self.verify(p0tx_bytes == frame_size,
> + self.verify((p0tx_bytes + 4) == frame_size,
> "packet pass assert error, expected %d TX bytes,
> actual %d" % (frame_size, p0tx_bytes))
>
> return out
> --
> 1.9.3
prev parent reply other threads:[~2015-11-19 7:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 6:51 Jingguo Fu
2015-11-19 7:18 ` Liu, Yong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E10F6A6B4@SHSMSX103.ccr.corp.intel.com \
--to=yong.liu@intel.com \
--cc=dts@dpdk.org \
--cc=jingguox.fu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).