From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 316B1E72 for ; Thu, 19 Nov 2015 08:18:05 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP; 18 Nov 2015 23:18:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,317,1444719600"; d="scan'208";a="854349072" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 18 Nov 2015 23:18:04 -0800 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 18 Nov 2015 23:18:02 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 18 Nov 2015 23:18:02 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.138]) by shsmsx102.ccr.corp.intel.com ([169.254.2.42]) with mapi id 14.03.0248.002; Thu, 19 Nov 2015 15:18:00 +0800 From: "Liu, Yong" To: "Fu, JingguoX" , "dts@dpdk.org" Thread-Topic: [DTS][PATCH] fix result verify issue for crc in dpdk update Thread-Index: AQHRIpbP0MQAJKpePUO84143RPahlZ6i7v5w Date: Thu, 19 Nov 2015 07:18:00 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E10F6A6B4@SHSMSX103.ccr.corp.intel.com> References: <1447915905-21171-1-git-send-email-jingguox.fu@intel.com> In-Reply-To: <1447915905-21171-1-git-send-email-jingguox.fu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [DTS][PATCH] fix result verify issue for crc in dpdk update X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Nov 2015 07:18:05 -0000 Hi Jingguo, This fix may not work on other NICs, you can reference to function send_pac= ket in shutdown_api suite. The function also handled crc and vlan packet length in testpmd. > -----Original Message----- > From: Fu, JingguoX > Sent: Thursday, November 19, 2015 2:52 PM > To: dts@dpdk.org > Cc: Liu, Yong; Xu, HuilongX; Fu, JingguoX > Subject: [DTS][PATCH] fix result verify issue for crc in dpdk update >=20 > Signed-off-by: Jingguo Fu > --- > tests/TestSuite_pmd.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/tests/TestSuite_pmd.py b/tests/TestSuite_pmd.py > index 29dec2b..740504f 100644 > --- a/tests/TestSuite_pmd.py > +++ b/tests/TestSuite_pmd.py > @@ -407,13 +407,13 @@ class TestPmd(TestCase,IxiaPacketGenerator): > self.verify(p1rx_bytes =3D=3D frame_size, > "packet pass assert error, expected %d RX > bytes, actual %d" % (frame_size, p1rx_bytes)) > else: > - self.verify(p1rx_bytes =3D=3D frame_size - 4, > + self.verify(p1rx_bytes =3D=3D frame_size, > "packet pass assert error, expected %d RX > bytes, actual %d" % (frame_size - 4, p1rx_bytes)) > else: > self.verify(p1rx_bytes =3D=3D frame_size, > "packet pass assert error, expected %d RX bytes, > actual %d" % (frame_size, p1rx_bytes)) >=20 > - self.verify(p0tx_bytes =3D=3D frame_size, > + self.verify((p0tx_bytes + 4) =3D=3D frame_size, > "packet pass assert error, expected %d TX bytes, > actual %d" % (frame_size, p0tx_bytes)) >=20 > return out > -- > 1.9.3