test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Gu, YongjieX" <yongjiex.gu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Gu, YongjieX" <yongjiex.gu@intel.com>
Subject: Re: [dts] [PATCH] change the verification of pktbytes in jumboframes	cases
Date: Fri, 27 Nov 2015 08:10:10 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E10F70462@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1448608174-27198-2-git-send-email-yongjiex.gu@intel.com>

Thanks, applied.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of yongjie
> Sent: Friday, November 27, 2015 3:10 PM
> To: dts@dpdk.org
> Cc: Gu, YongjieX
> Subject: [dts] [PATCH] change the verification of pktbytes in jumboframes
> cases
> 
> From: Gu yongjie <yongjiex.gu@intel.com>
> 
> Change the verification of pktbytes,because DPDK removes the crc bytes
> from byte counter.
> 
> Signed-off-by: Gu yongjie <yongjiex.gu@intel.com>
> ---
>  tests/TestSuite_jumboframes.py |    8 ++------
>  1 files changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/TestSuite_jumboframes.py
> b/tests/TestSuite_jumboframes.py
> index a295624..1cceba8 100644
> --- a/tests/TestSuite_jumboframes.py
> +++ b/tests/TestSuite_jumboframes.py
> @@ -93,12 +93,8 @@ class TestJumboframes(TestCase):
>          p1rx_err -= gp1rx_err
> 
>          if received:
> -            if self.nic in ["fortville_eagle", "fortville_spirit",
> "fortville_spirit_single"]:
> -                self.verify((p0tx_pkts == p1rx_pkts) and ((p0tx_bytes + 4)
> == pktsize) and (p1rx_bytes == pktsize),
> -                            "packet pass assert error")
> -            else:
> -                self.verify((p0tx_pkts == p1rx_pkts) and (p0tx_bytes ==
> pktsize) and (p1rx_bytes == pktsize),
> -                            "packet pass assert error")
> +            self.verify((p0tx_pkts == p1rx_pkts) and ((p0tx_bytes + 4) ==
> pktsize) and ((p1rx_bytes + 4) == pktsize),
> +                        "packet pass assert error")
>          else:
>              #self.verify(p0tx_pkts == p1rx_pkts and (p1rx_err == 1 or
> p1rx_pkts == 0),
>              self.verify(p1rx_err == 1 or p0tx_pkts == 0, "packet drop
> assert error")
> --
> 1.7.4.4

  reply	other threads:[~2015-11-27  8:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-27  7:09 [dts] [PATCH] change the verification of pktbytes in pmd cases yongjie
2015-11-27  7:09 ` [dts] [PATCH] change the verification of pktbytes in jumboframes cases yongjie
2015-11-27  8:10   ` Liu, Yong [this message]
2015-11-27  8:09 ` [dts] [PATCH] change the verification of pktbytes in pmd cases Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E10F70462@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=yongjiex.gu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).