From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 4BDA258DB for ; Tue, 1 Dec 2015 07:12:19 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 30 Nov 2015 22:12:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,367,1444719600"; d="scan'208";a="831560211" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 30 Nov 2015 22:12:16 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.110.15) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 30 Nov 2015 22:12:14 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.138]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.223]) with mapi id 14.03.0248.002; Tue, 1 Dec 2015 14:12:12 +0800 From: "Liu, Yong" To: "Tu, LijuanX A" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH]tests uni_pkt: disable vector ixgbe driver and rename i350 to powerville Thread-Index: AQHRK/4XPkDgWB1f6kK0Uo7MNwQUgJ61pQaw Date: Tue, 1 Dec 2015 06:12:11 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E10F72FD1@SHSMSX103.ccr.corp.intel.com> References: <1448949552-3456-1-git-send-email-lijuanx.a.tu@intel.com> In-Reply-To: <1448949552-3456-1-git-send-email-lijuanx.a.tu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-inteldataclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsIiwiaWQiOiIyMTAyYjUzYS1iZjJkLTRlZTQtOWZiMC01Y2NmN2UzMzQ0N2IiLCJwcm9wcyI6W3sibiI6IkludGVsRGF0YUNsYXNzaWZpY2F0aW9uIiwidmFscyI6W3sidmFsdWUiOiJDVFBfSUMifV19XX0sIlN1YmplY3RMYWJlbHMiOltdLCJUTUNWZXJzaW9uIjoiMTUuNC4xMC4xOSIsIlRydXN0ZWRMYWJlbEhhc2giOiJTUFlUMWd3NTFxVGp6Uis1RzZ3S1k1OVlIWDV3SjRrYjA5M2UwMjluWTNRPSJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH]tests uni_pkt: disable vector ixgbe driver and rename i350 to powerville X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Dec 2015 06:12:19 -0000 Hi Lijuan, Some comments below. Thanks. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Lijuan Tu > Sent: Tuesday, December 01, 2015 1:59 PM > To: dts@dpdk.org > Subject: [dts] [PATCH]tests uni_pkt: disable vector ixgbe driver and > rename i350 to powerville >=20 > Signed-off-by: Lijuan Tu > --- > tests/TestSuite_uni_pkt.py | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) >=20 > diff --git a/tests/TestSuite_uni_pkt.py b/tests/TestSuite_uni_pkt.py > index ca72e75..17c11b0 100644 > --- a/tests/TestSuite_uni_pkt.py > +++ b/tests/TestSuite_uni_pkt.py > @@ -63,6 +63,13 @@ class TestUniPacket(TestCase): > self.dut_port =3D valports[0] > tester_port =3D self.tester.get_local_port(self.dut_port) > self.tester_iface =3D self.tester.get_interface(tester_port) > + """ > + Disable vector ixgbe driver in dpdk configuration file. > + """ > + [arch, machine, env, toolchain] =3D self.target.split('-') > + self.dut.send_expect("sed -i -e > 's/CONFIG_RTE_IXGBE_INC_VECTOR=3D.*$/" > + + "CONFIG_RTE_IXGBE_INC_VECTOR=3Dn/' > config/common_%s" % env, "# ", 30) Not only Niantic but also Fortville need disable vector code path. I think this suite should disable vector function based on NIC type. > + self.dut.build_install_dpdk(self.target) > self.dut.send_expect( > "./%s/app/testpmd -c f -n 4 -- -i --txqflags=3D0x0" % > self.target, "testpmd>", 20) > self.dut.send_expect("set fwd rxonly", "testpmd>") > @@ -117,7 +124,7 @@ class TestUniPacket(TestCase): > """ > if "fortville" in self.nic.lower(): > outerL4Type =3D "(outer) L4 type: L4_NONFRAG" > - elif "niantic" in self.nic.lower() or "i350" in self.nic.lower()= : > + elif "niantic" in self.nic.lower() or "powerville" in > self.nic.lower(): > outerL4Type =3D "(outer) L4 type: Unknown" >=20 > pktType =3D { > @@ -135,7 +142,7 @@ class TestUniPacket(TestCase): > if "fortville" in self.nic.lower(): > pktType.pop("MAC_IPihl_PKT") > pktType.pop("MAC_IPihl_SCTP_PKT") > - elif "niantic" in self.nic.lower() or "i350" in self.nic.lower()= : > + elif "niantic" in self.nic.lower() or "powerville" in > self.nic.lower(): > pktType.pop("MAC_IP_ICMP_PKT") > pktType.pop("MAC_IPFRAG_TCP_PKT") >=20 > @@ -148,7 +155,7 @@ class TestUniPacket(TestCase): > if "fortville" in self.nic.lower(): > outerL4Type =3D "(outer) L4 type: L4_NONFRAG" > outerL3Type =3D "(outer) L3 type: IPV6_EXT_UNKNOWN" > - elif "niantic" in self.nic.lower() or "i350" in self.nic.lower()= : > + elif "niantic" in self.nic.lower() or "powerville" in > self.nic.lower(): > outerL4Type =3D "(outer) L4 type: Unknown" > outerL3Type =3D "(outer) L3 type: IPV6" >=20 > @@ -163,7 +170,7 @@ class TestUniPacket(TestCase): > # delete the unsupported packet based on nic type > if "fortville" in self.nic.lower(): > pktType.pop("MAC_IPv6FRAG_PKT_N") > - elif "niantic" in self.nic.lower() or "i350" in self.nic.lower()= : > + elif "niantic" in self.nic.lower() or "powerville" in > self.nic.lower(): > pktType.pop("MAC_IPv6FRAG_PKT_F") >=20 > self.run_test(pktType) > @@ -198,7 +205,7 @@ class TestUniPacket(TestCase): > checked that whether IPv4 in IPv6 tunnel packet can be normally > detected by Niantic and i350. > """ > - if "niantic" not in self.nic.lower() and "i350" not in > self.nic.lower(): > + if "niantic" not in self.nic.lower() and "powerville" not in > self.nic.lower(): There's one excel file named "dpdk_support_test_case.xls" which has tracked= whether cases support in the NIC. I think we can remove the judging condition here. > return >=20 > pktType =3D { > -- > 1.9.1