From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 28CD758DB for ; Wed, 2 Dec 2015 02:26:44 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP; 01 Dec 2015 17:26:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,371,1444719600"; d="scan'208";a="862641934" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga002.jf.intel.com with ESMTP; 01 Dec 2015 17:26:42 -0800 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 1 Dec 2015 17:26:42 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.110.15) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 1 Dec 2015 17:26:42 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.138]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.223]) with mapi id 14.03.0248.002; Wed, 2 Dec 2015 09:26:40 +0800 From: "Liu, Yong" To: "Tu, LijuanX A" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH v2]tests uni_pkt: disable vector ixgbe driver and rename i350 to powerville Thread-Index: AQHRLJ5/RaMj5mGF3ECuAMIhS+/WA562X7yAgACHc/A= Date: Wed, 2 Dec 2015 01:26:39 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E10F7398E@SHSMSX103.ccr.corp.intel.com> References: <1448956333-2525-1-git-send-email-lijuanx.a.tu@intel.com> <565E4561.20203@intel.com> <38D041F150D4184C8114E499040E62340723E748@shsmsx102.ccr.corp.intel.com> In-Reply-To: <38D041F150D4184C8114E499040E62340723E748@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-inteldataclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsIiwiaWQiOiIwM2MyODg0Ny0zN2EwLTRmMmEtOWQ1Zi03NDQ3ZTMzZmE2ZmIiLCJwcm9wcyI6W3sibiI6IkludGVsRGF0YUNsYXNzaWZpY2F0aW9uIiwidmFscyI6W3sidmFsdWUiOiJDVFBfSUMifV19XX0sIlN1YmplY3RMYWJlbHMiOltdLCJUTUNWZXJzaW9uIjoiMTUuNC4xMC4xOSIsIlRydXN0ZWRMYWJlbEhhc2giOiJZVjd1ZVo1N2thNGswZ0xLXC9FWGp5NzlPZXBKeXQwYUV5R2p2MHZjekNkMD0ifQ== x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH v2]tests uni_pkt: disable vector ixgbe driver and rename i350 to powerville X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Dec 2015 01:26:44 -0000 Lijuan, dpdk has default setting for Rx code method. But its mode can be ch= anged by dts execution file. So I mentioned that suite should depend on dts.rx_mode not dpdk default set= ting. > -----Original Message----- > From: Tu, LijuanX A > Sent: Wednesday, December 02, 2015 9:20 AM > To: Liu, Yong; dts@dpdk.org > Subject: RE: [dts] [PATCH v2]tests uni_pkt: disable vector ixgbe driver > and rename i350 to powerville >=20 > Hi yong, >=20 >=20 > > -----Original Message----- > > From: Liu, Yong > > Sent: Wednesday, December 02, 2015 9:12 AM > > To: Tu, LijuanX A; dts@dpdk.org > > Subject: Re: [dts] [PATCH v2]tests uni_pkt: disable vector ixgbe driver > > and rename i350 to powerville > > > > Hi Lijuan, > > One comment about change rx/tx code path. > > > > On 12/01/2015 03:52 PM, Lijuan Tu wrote: > > > Signed-off-by: Lijuan Tu > > > --- > > > tests/TestSuite_uni_pkt.py | 32 +++++++++++++++++++++++++++----- > > > 1 file changed, 27 insertions(+), 5 deletions(-) > > > > > > diff --git a/tests/TestSuite_uni_pkt.py b/tests/TestSuite_uni_pkt.py > > > index ca72e75..60756c9 100644 > > > --- a/tests/TestSuite_uni_pkt.py > > > +++ b/tests/TestSuite_uni_pkt.py > > > @@ -63,6 +63,17 @@ class TestUniPacket(TestCase): > > > self.dut_port =3D valports[0] > > > tester_port =3D self.tester.get_local_port(self.dut_port) > > > self.tester_iface =3D self.tester.get_interface(tester_port= ) > > > + """ > > > + Change config file to disable vector pmd and recompile the > > package. > > > + """ > > > + [arch, machine, env, toolchain] =3D self.target.split('-') > > > + if "fortville" in self.nic.lower(): > > > + self.dut.send_expect("sed -i -e > > 's/CONFIG_RTE_LIBRTE_I40E_INC_VECTOR=3D.*$/" > > > + + > > "CONFIG_RTE_LIBRTE_I40E_INC_VECTOR=3Dn/' config/common_%s" % env, "# ", > > 30) > > > + elif "niantic" in self.nic.lower(): > > > + self.dut.send_expect("sed -i -e > > 's/CONFIG_RTE_IXGBE_INC_VECTOR=3D.*$/" > > > + + "CONFIG_RTE_IXGBE_INC_VECTOR=3Dn/' > > config/common_%s" % env, "# ", 30) > > > + self.dut.build_install_dpdk(self.target) > > > self.dut.send_expect( > > > "./%s/app/testpmd -c f -n 4 -- -i --txqflags=3D0x0" % > > self.target, "testpmd>", 20) > > > self.dut.send_expect("set fwd rxonly", "testpmd>") @@ - > > 117,7 > > > +128,7 @@ class TestUniPacket(TestCase): > > > """ > > > if "fortville" in self.nic.lower(): > > > outerL4Type =3D "(outer) L4 type: L4_NONFRAG" > > > - elif "niantic" in self.nic.lower() or "i350" in > > self.nic.lower(): > > > + elif "niantic" in self.nic.lower() or "powerville" in > > self.nic.lower(): > > > outerL4Type =3D "(outer) L4 type: Unknown" > > > > > > pktType =3D { > > > @@ -135,7 +146,7 @@ class TestUniPacket(TestCase): > > > if "fortville" in self.nic.lower(): > > > pktType.pop("MAC_IPihl_PKT") > > > pktType.pop("MAC_IPihl_SCTP_PKT") > > > - elif "niantic" in self.nic.lower() or "i350" in > > self.nic.lower(): > > > + elif "niantic" in self.nic.lower() or "powerville" in > > self.nic.lower(): > > > pktType.pop("MAC_IP_ICMP_PKT") > > > pktType.pop("MAC_IPFRAG_TCP_PKT") > > > > > > @@ -148,7 +159,7 @@ class TestUniPacket(TestCase): > > > if "fortville" in self.nic.lower(): > > > outerL4Type =3D "(outer) L4 type: L4_NONFRAG" > > > outerL3Type =3D "(outer) L3 type: IPV6_EXT_UNKNOWN" > > > - elif "niantic" in self.nic.lower() or "i350" in > > self.nic.lower(): > > > + elif "niantic" in self.nic.lower() or "powerville" in > > self.nic.lower(): > > > outerL4Type =3D "(outer) L4 type: Unknown" > > > outerL3Type =3D "(outer) L3 type: IPV6" > > > > > > @@ -163,7 +174,7 @@ class TestUniPacket(TestCase): > > > # delete the unsupported packet based on nic type > > > if "fortville" in self.nic.lower(): > > > pktType.pop("MAC_IPv6FRAG_PKT_N") > > > - elif "niantic" in self.nic.lower() or "i350" in > > self.nic.lower(): > > > + elif "niantic" in self.nic.lower() or "powerville" in > > self.nic.lower(): > > > pktType.pop("MAC_IPv6FRAG_PKT_F") > > > > > > self.run_test(pktType) > > > @@ -198,7 +209,7 @@ class TestUniPacket(TestCase): > > > checked that whether IPv4 in IPv6 tunnel packet can be > > normally > > > detected by Niantic and i350. > > > """ > > > - if "niantic" not in self.nic.lower() and "i350" not in > > self.nic.lower(): > > > + if "niantic" not in self.nic.lower() and "powerville" not in > > self.nic.lower(): > > > return > > > > > > pktType =3D { > > > @@ -361,4 +372,15 @@ class TestUniPacket(TestCase): > > > Nothing to do. > > > """ > > > self.dut.kill_all() > > > + """ > > > + Restore the config file and recompile the package. > > > + """ > > > + [arch, machine, env, toolchain] =3D self.target.split('-') > > > + if "fortville" in self.nic.lower(): > > > + self.dut.send_expect("sed -i -e > > 's/CONFIG_RTE_LIBRTE_I40E_INC_VECTOR=3D.*$/" > > > + + > > "CONFIG_RTE_LIBRTE_I40E_INC_VECTOR=3Dn/' config/common_%s" % env, "# ", > > 30) > > > + elif "niantic" in self.nic.lower(): > > > + self.dut.send_expect("sed -i -e > > 's/CONFIG_RTE_IXGBE_INC_VECTOR=3D.*$/" > > > + + "CONFIG_RTE_IXGBE_INC_VECTOR=3Dn/' > > config/common_%s" % env, "# ", 30) > > > + self.dut.build_install_dpdk(self.target) > > Here is still disable vector mode. There's other approach is that use > > dts.rx_mode which is stripped from execution configuration file. > > Only when dts.rx_mode is "default" or "vector", this suite need change > > dpdk configuration. > In i40e driver , the default of " vector " is "n" in dpdk configuration > file > And in ixgbe driver, the default of " vector " is "y" in dpdk > configuration file > > > > > > > pass