test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Pei, Yulong" <yulong.pei@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH] framework: fix interface can not up when switch from	igb_uio to legacy driver.
Date: Thu, 17 Dec 2015 07:59:17 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E10F914BA@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1450254925-24558-1-git-send-email-yulong.pei@intel.com>

Hi Yulong,
Bind nic to other driver will also use this function. Here's need one judgment that bound driver should equal to default driver.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Yulong Pei
> Sent: Wednesday, December 16, 2015 4:35 PM
> To: dts@dpdk.org
> Subject: [dts] [PATCH] framework: fix interface can not up when switch
> from igb_uio to legacy driver.
> 
> when an interface switch from igb_uio driver to legacy linux driver, the
> interface always in
> down state, but it should be in up state.
> 
> Signed-off-by: Yulong Pei <yulong.pei@intel.com>
> ---
>  framework/net_device.py | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/framework/net_device.py b/framework/net_device.py
> index 37495bd..0f0aec7 100644
> --- a/framework/net_device.py
> +++ b/framework/net_device.py
> @@ -722,6 +722,8 @@ class NetDevice(object):
>          self.__send_expect(
>              "echo %s > /sys/bus/pci/drivers/%s/bind" %
>              (nic_pci_num, driver), "# ")
> +        itf = self.get_interface_name()
> +        self.__send_expect("ifconfig %s up" % itf, "# ")
> 
>      def bind_driver_linux_pci_stub(self, bus_id, devfun_id):
>          """
> --
> 2.1.0

      reply	other threads:[~2015-12-17  7:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-16  8:35 Yulong Pei
2015-12-17  7:59 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E10F914BA@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=yulong.pei@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).