From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id DF7867E23 for ; Thu, 17 Dec 2015 13:23:33 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP; 17 Dec 2015 04:23:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,441,1444719600"; d="scan'208";a="619536377" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 17 Dec 2015 04:23:06 -0800 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 17 Dec 2015 04:23:01 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 17 Dec 2015 04:22:58 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.28]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.190]) with mapi id 14.03.0248.002; Thu, 17 Dec 2015 20:22:50 +0800 From: "Liu, Yong" To: "Ding, HengX" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH] L3fwd: Enable RFC2544 for some 2 ports cases Thread-Index: AQHRNlNByTRIKzO9gk6WcPEqPlAfv57PHUmg Date: Thu, 17 Dec 2015 12:22:49 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E10F919C8@SHSMSX103.ccr.corp.intel.com> References: <1450085775-1980-1-git-send-email-hengx.ding@intel.com> In-Reply-To: <1450085775-1980-1-git-send-email-hengx.ding@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-inteldataclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsIiwiaWQiOiI3MmJiMTNlNy0xYWNhLTRiODctYjQyZi04MjdlNjY2ZjFhZWEiLCJwcm9wcyI6W3sibiI6IkludGVsRGF0YUNsYXNzaWZpY2F0aW9uIiwidmFscyI6W3sidmFsdWUiOiJDVFBfSUMifV19XX0sIlN1YmplY3RMYWJlbHMiOltdLCJUTUNWZXJzaW9uIjoiMTUuNC4xMC4xOSIsIlRydXN0ZWRMYWJlbEhhc2giOiJsdlpTenU0ZHMrTHU3dUU2dU9FSFhTWHRVSUNSbnBGU0VqV3RzUFpmR1wvWT0ifQ== x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "Ding, HengX" Subject: Re: [dts] [PATCH] L3fwd: Enable RFC2544 for some 2 ports cases X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Dec 2015 12:23:34 -0000 Hi Heng, One question about RFC2544 test. According to https://tools.ietf.org/html/rfc2544, one minute is enough for = trial. Wait for two minutes maybe too long for validation. And frame should be [64, 128, 256, 512, 1024, 1280, 1518], maybe you can re= ference it. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Ding Heng > Sent: Monday, December 14, 2015 5:36 PM > To: dts@dpdk.org > Cc: Ding, HengX > Subject: [dts] [PATCH] L3fwd: Enable RFC2544 for some 2 ports cases >=20 > Enable RFC2544 test for l3fwd 2 ports cases. In order to save time, only > 1S/1C/1T and 1S/4C/1T cases will be enabled, the others' result will be > set 0. >=20 > Signed-off-by: Ding Heng >=20 > diff --git a/tests/TestSuite_l3fwd.py b/tests/TestSuite_l3fwd.py > index 0e09256..ea4e3ca 100644 > --- a/tests/TestSuite_l3fwd.py > +++ b/tests/TestSuite_l3fwd.py > @@ -521,7 +521,7 @@ class TestL3fwd(TestCase,IxiaPacketGenerator): > L3fwd main 2 ports. > """ >=20 > - header_row =3D ["Frame", "Ports", "S/C/T", "Mpps", "% linerate", > "mode"] > + header_row =3D ["Frame", "mode", "S/C/T", "Mpps", "% linerate", > "LR_tx_pkts(2mins)", "LR_rx_pkts(2mins)", "LR_loss_pkts(2mins)", "% > zero_loss_rate"] > self.l3fwd_test_results['header'] =3D header_row > dts.results_table_add_header(header_row) > self.l3fwd_test_results['data'] =3D [] > @@ -533,7 +533,7 @@ class TestL3fwd(TestCase,IxiaPacketGenerator): > HEADER_SIZE['ip'] - HEADER_SIZE['eth'] > for _port in range(2): > dmac =3D self.dut.get_mac_address(valports[_port]) > - flows =3D ['Ether(dst=3D%s)/%s/("X"*%d)' % (dmac, flow, > payload_size) for flow in self.flows()[_port *2:(_port +1)*2]] > + flows =3D ['Ether(dst=3D"%s")/%s/("X"*%d)' % (dmac, flow= , > payload_size) for flow in self.flows()[_port *2:(_port +1)*2]] > self.tester.scapy_append('wrpcap("dst%d.pcap", > [%s])' %(valports[_port],string.join(flows,','))) > self.tester.scapy_execute() >=20 > @@ -605,13 +605,18 @@ class TestL3fwd(TestCase,IxiaPacketGenerator): > pps /=3D 1000000.0 > linerate =3D self.wirespeed(self.nic, frame_size, 2) > pct =3D pps * 100 / linerate Not sure why not "lpm" mode and 1C/4C need RFC2544 test. Could you clear i= t? > + if mode =3D=3D "lpm" and (cores =3D=3D "1S/1C/1T" or= cores =3D=3D > "1S/4C/1T"): > + zero_loss_rate, tx_pkts, rx_pkts =3D > self.tester.run_rfc2544(tgenInput, delay=3D3) > + loss_pkts =3D tx_pkts - rx_pkts > + else: > + zero_loss_rate=3Dtx_pkts=3Drx_pkts=3Dloss_pkts= =3D0 >=20 > index +=3D 1 >=20 > # Stop l3fwd > self.dut.send_expect("^C", "#") >=20 > - data_row =3D [frame_size, 2, cores, str(pps), str(pc= t), > mode] > + data_row =3D [frame_size, mode, cores, str(pps), > str(pct), tx_pkts, rx_pkts, loss_pkts, zero_loss_rate] > dts.results_table_add_row(data_row) > self.l3fwd_test_results['data'].append(data_row) >=20 > -- > 1.9.3