* [dts] [PATCH V1] add payload for send eth packet
@ 2015-12-07 2:52 Shijie Dong
2015-12-07 3:03 ` Xu, HuilongX
2015-12-22 1:24 ` Liu, Yong
0 siblings, 2 replies; 7+ messages in thread
From: Shijie Dong @ 2015-12-07 2:52 UTC (permalink / raw)
To: dts
scapy can't support send packet only inlcude eth herd in ubutu 15.10
Signed-off-by: Shijie Dong <shijiex.dong@intel.com>
---
tests/TestSuite_mac_filter.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/TestSuite_mac_filter.py b/tests/TestSuite_mac_filter.py
index 1d4e77d..3ca7387 100644
--- a/tests/TestSuite_mac_filter.py
+++ b/tests/TestSuite_mac_filter.py
@@ -86,7 +86,7 @@ class TestWhitelist(TestCase):
"""
itf = self.tester.get_interface(self.tester.get_local_port(portid))
self.tester.scapy_foreground()
- self.tester.scapy_append('sendp([Ether(dst="%s", src="52:00:00:00:00:00")], iface="%s", count=%d)' % (destMac,
+ self.tester.scapy_append('sendp([Ether(dst="%s", src="52:00:00:00:00:00")/Raw(load="X"*26)], iface="%s", count=%d)' % (destMac,
itf, self.frames_to_send))
self.tester.scapy_execute()
time.sleep(5)
--
1.9.3
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dts] [PATCH V1] add payload for send eth packet
2015-12-07 2:52 [dts] [PATCH V1] add payload for send eth packet Shijie Dong
@ 2015-12-07 3:03 ` Xu, HuilongX
2015-12-22 1:24 ` Liu, Yong
1 sibling, 0 replies; 7+ messages in thread
From: Xu, HuilongX @ 2015-12-07 3:03 UTC (permalink / raw)
To: Dong, ShijieX, dts
Hi shijie,
Could you check all test suite have this issue, and send a patch fix them.
Thanks a lot
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Shijie Dong
> Sent: Monday, December 07, 2015 10:52 AM
> To: dts@dpdk.org
> Subject: [dts] [PATCH V1] add payload for send eth packet
>
> scapy can't support send packet only inlcude eth herd in ubutu 15.10
>
> Signed-off-by: Shijie Dong <shijiex.dong@intel.com>
> ---
> tests/TestSuite_mac_filter.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_mac_filter.py b/tests/TestSuite_mac_filter.py
> index 1d4e77d..3ca7387 100644
> --- a/tests/TestSuite_mac_filter.py
> +++ b/tests/TestSuite_mac_filter.py
> @@ -86,7 +86,7 @@ class TestWhitelist(TestCase):
> """
> itf =
> self.tester.get_interface(self.tester.get_local_port(portid))
> self.tester.scapy_foreground()
> - self.tester.scapy_append('sendp([Ether(dst="%s",
> src="52:00:00:00:00:00")], iface="%s", count=%d)' % (destMac,
> + self.tester.scapy_append('sendp([Ether(dst="%s",
> src="52:00:00:00:00:00")/Raw(load="X"*26)], iface="%s", count=%d)' %
> (destMac,
>
> itf, self.frames_to_send))
> self.tester.scapy_execute()
> time.sleep(5)
> --
> 1.9.3
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dts] [PATCH V1] add payload for send eth packet
2015-12-07 2:52 [dts] [PATCH V1] add payload for send eth packet Shijie Dong
2015-12-07 3:03 ` Xu, HuilongX
@ 2015-12-22 1:24 ` Liu, Yong
1 sibling, 0 replies; 7+ messages in thread
From: Liu, Yong @ 2015-12-22 1:24 UTC (permalink / raw)
To: Dong, ShijieX, dts
Applied, since only this case send packet without content. Please take care when preparing your patch, there're some topy issues in the description.
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Shijie Dong
> Sent: Monday, December 07, 2015 10:52 AM
> To: dts@dpdk.org
> Subject: [dts] [PATCH V1] add payload for send eth packet
>
> scapy can't support send packet only inlcude eth herd in ubutu 15.10
>
> Signed-off-by: Shijie Dong <shijiex.dong@intel.com>
> ---
> tests/TestSuite_mac_filter.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_mac_filter.py b/tests/TestSuite_mac_filter.py
> index 1d4e77d..3ca7387 100644
> --- a/tests/TestSuite_mac_filter.py
> +++ b/tests/TestSuite_mac_filter.py
> @@ -86,7 +86,7 @@ class TestWhitelist(TestCase):
> """
> itf =
> self.tester.get_interface(self.tester.get_local_port(portid))
> self.tester.scapy_foreground()
> - self.tester.scapy_append('sendp([Ether(dst="%s",
> src="52:00:00:00:00:00")], iface="%s", count=%d)' % (destMac,
> + self.tester.scapy_append('sendp([Ether(dst="%s",
> src="52:00:00:00:00:00")/Raw(load="X"*26)], iface="%s", count=%d)' %
> (destMac,
>
> itf, self.frames_to_send))
> self.tester.scapy_execute()
> time.sleep(5)
> --
> 1.9.3
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dts] [PATCH V1] add payload for send eth packet
2015-12-04 1:48 ` Dong, ShijieX
@ 2015-12-07 1:14 ` Liu, Yong
0 siblings, 0 replies; 7+ messages in thread
From: Liu, Yong @ 2015-12-07 1:14 UTC (permalink / raw)
To: Dong, ShijieX, dts
Thanks, applied with additional information.
On 12/04/2015 09:48 AM, Dong, ShijieX wrote:
> OS : Ubunto 15.10
> Python :2.7.10
> Scapy :2.2.0
>
> -----Original Message-----
> From: Liu, Yong
> Sent: Friday, December 04, 2015 8:52 AM
> To: Dong, ShijieX; dts@dpdk.org
> Subject: Re: [dts] [PATCH V1] add payload for send eth packet
>
> Hi shide, can you supply the information that which version scapy not support raw packet?
> We can add it into dts document.
>
> On 12/03/2015 06:34 PM, Shijie Dong wrote:
>> scapy can't support send packet only inlcude eth herd in ubutu 15.10
>>
>> Signed-off-by: Shijie Dong <shijiex.dong@intel.com>
>> ---
>> tests/TestSuite_dynamic_config.py | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/TestSuite_dynamic_config.py
>> b/tests/TestSuite_dynamic_config.py
>> index d1ad49c..ba740b1 100644
>> --- a/tests/TestSuite_dynamic_config.py
>> +++ b/tests/TestSuite_dynamic_config.py
>> @@ -111,7 +111,7 @@ class TestDynamicConfig(TestCase):
>>
>> self.tester.scapy_foreground()
>> self.tester.scapy_append(
>> - 'sendp([Ether(dst="%s", src="52:00:00:00:00:00")], iface="%s")' % (destMac, itf))
>> + 'sendp([Ether(dst="%s",
>> + src="52:00:00:00:00:00")/Raw(load="X"*26)], iface="%s")' % (destMac,
>> + itf))
>>
>> self.tester.scapy_execute()
>>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dts] [PATCH V1] add payload for send eth packet
2015-12-04 0:51 ` Liu, Yong
@ 2015-12-04 1:48 ` Dong, ShijieX
2015-12-07 1:14 ` Liu, Yong
0 siblings, 1 reply; 7+ messages in thread
From: Dong, ShijieX @ 2015-12-04 1:48 UTC (permalink / raw)
To: Liu, Yong, dts
OS : Ubunto 15.10
Python :2.7.10
Scapy :2.2.0
-----Original Message-----
From: Liu, Yong
Sent: Friday, December 04, 2015 8:52 AM
To: Dong, ShijieX; dts@dpdk.org
Subject: Re: [dts] [PATCH V1] add payload for send eth packet
Hi shide, can you supply the information that which version scapy not support raw packet?
We can add it into dts document.
On 12/03/2015 06:34 PM, Shijie Dong wrote:
> scapy can't support send packet only inlcude eth herd in ubutu 15.10
>
> Signed-off-by: Shijie Dong <shijiex.dong@intel.com>
> ---
> tests/TestSuite_dynamic_config.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_dynamic_config.py
> b/tests/TestSuite_dynamic_config.py
> index d1ad49c..ba740b1 100644
> --- a/tests/TestSuite_dynamic_config.py
> +++ b/tests/TestSuite_dynamic_config.py
> @@ -111,7 +111,7 @@ class TestDynamicConfig(TestCase):
>
> self.tester.scapy_foreground()
> self.tester.scapy_append(
> - 'sendp([Ether(dst="%s", src="52:00:00:00:00:00")], iface="%s")' % (destMac, itf))
> + 'sendp([Ether(dst="%s",
> + src="52:00:00:00:00:00")/Raw(load="X"*26)], iface="%s")' % (destMac,
> + itf))
>
> self.tester.scapy_execute()
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dts] [PATCH V1] add payload for send eth packet
2015-12-03 10:34 Shijie Dong
@ 2015-12-04 0:51 ` Liu, Yong
2015-12-04 1:48 ` Dong, ShijieX
0 siblings, 1 reply; 7+ messages in thread
From: Liu, Yong @ 2015-12-04 0:51 UTC (permalink / raw)
To: Shijie Dong, dts
Hi shide, can you supply the information that which version scapy not
support raw packet?
We can add it into dts document.
On 12/03/2015 06:34 PM, Shijie Dong wrote:
> scapy can't support send packet only inlcude eth herd in ubutu 15.10
>
> Signed-off-by: Shijie Dong <shijiex.dong@intel.com>
> ---
> tests/TestSuite_dynamic_config.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_dynamic_config.py b/tests/TestSuite_dynamic_config.py
> index d1ad49c..ba740b1 100644
> --- a/tests/TestSuite_dynamic_config.py
> +++ b/tests/TestSuite_dynamic_config.py
> @@ -111,7 +111,7 @@ class TestDynamicConfig(TestCase):
>
> self.tester.scapy_foreground()
> self.tester.scapy_append(
> - 'sendp([Ether(dst="%s", src="52:00:00:00:00:00")], iface="%s")' % (destMac, itf))
> + 'sendp([Ether(dst="%s", src="52:00:00:00:00:00")/Raw(load="X"*26)], iface="%s")' % (destMac, itf))
>
> self.tester.scapy_execute()
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [dts] [PATCH V1] add payload for send eth packet
@ 2015-12-03 10:34 Shijie Dong
2015-12-04 0:51 ` Liu, Yong
0 siblings, 1 reply; 7+ messages in thread
From: Shijie Dong @ 2015-12-03 10:34 UTC (permalink / raw)
To: dts
scapy can't support send packet only inlcude eth herd in ubutu 15.10
Signed-off-by: Shijie Dong <shijiex.dong@intel.com>
---
tests/TestSuite_dynamic_config.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/TestSuite_dynamic_config.py b/tests/TestSuite_dynamic_config.py
index d1ad49c..ba740b1 100644
--- a/tests/TestSuite_dynamic_config.py
+++ b/tests/TestSuite_dynamic_config.py
@@ -111,7 +111,7 @@ class TestDynamicConfig(TestCase):
self.tester.scapy_foreground()
self.tester.scapy_append(
- 'sendp([Ether(dst="%s", src="52:00:00:00:00:00")], iface="%s")' % (destMac, itf))
+ 'sendp([Ether(dst="%s", src="52:00:00:00:00:00")/Raw(load="X"*26)], iface="%s")' % (destMac, itf))
self.tester.scapy_execute()
--
1.9.3
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-12-22 1:24 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-07 2:52 [dts] [PATCH V1] add payload for send eth packet Shijie Dong
2015-12-07 3:03 ` Xu, HuilongX
2015-12-22 1:24 ` Liu, Yong
-- strict thread matches above, loose matches on Subject: below --
2015-12-03 10:34 Shijie Dong
2015-12-04 0:51 ` Liu, Yong
2015-12-04 1:48 ` Dong, ShijieX
2015-12-07 1:14 ` Liu, Yong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).