From: "Liu, Yong" <yong.liu@intel.com>
To: "Tu, LijuanX A" <lijuanx.a.tu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH]framework/tester.py: create packets length with protocol type
Date: Mon, 18 Jan 2016 06:57:21 +0000 [thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E13B0D978@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1453099389-21011-1-git-send-email-lijuanx.a.tu@intel.com>
Lijuan, few comments below.
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Lijuan Tu
> Sent: Monday, January 18, 2016 2:43 PM
> To: dts@dpdk.org
> Subject: [dts] [PATCH]framework/tester.py: create packets length with
> protocol type
>
> Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
> ---
> framework/tester.py | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/framework/tester.py b/framework/tester.py
> index c8cebd6..d3deb3b 100644
> --- a/framework/tester.py
> +++ b/framework/tester.py
> @@ -471,10 +471,11 @@ class Tester(Crb):
> else:
> return None
>
> - def check_random_pkts(self, portList, pktnum=2000, interval=0.01,
> allow_miss=True, params=None):
> + def check_random_pkts(self, portList, pktnum=10000, interval=0.01,
> allow_miss=True, params=None):
> """
> Send several random packets and check rx packets matched
> """
> +# allow_miss=True
Meaningless code, please just remove it.
> # load functions in packet module
> module = __import__("packet")
> pkt_c = getattr(module, "Packet")
> @@ -485,6 +486,7 @@ class Tester(Crb):
> pkts = []
> # packet type random between tcp/udp/ipv6
> random_type = ['TCP', 'UDP', 'IPv6_TCP', 'IPv6_UDP']
> + pkt_minlen = {'TCP': 64, 'UDP': 64, 'IPv6_TCP': 74, 'IPv6_UDP':
> 64}
> # at least wait 2 seconds
> timeout = int(pktnum * (interval + 0.01)) + 2
> for txport, rxport in portList:
> @@ -494,7 +496,7 @@ class Tester(Crb):
> # chose random packet
> pkt_type = random.choice(random_type)
> pkt = pkt_c(pkt_type=pkt_type,
> - pkt_len=random.randint(64, 1514),
> + pkt_len=random.randint(pkt_minlen[pkt_type],
> 1514),
> ran_payload=True)
> # config packet if has parameters
> if params and len(portList) == len(params):
> @@ -509,6 +511,7 @@ class Tester(Crb):
> pkts.append(pkt)
>
> # send and sniff packets
> + sniff_f(intf=txIntf, count=pktnum, timeout=timeout)
Why capture packets send to TX interface? It look like meaningless.
> inst = sniff_f(intf=rxIntf, count=pktnum, timeout=timeout)
> send_f(intf=txIntf, pkts=pkts, interval=interval)
> recv_pkts = load_f(inst)
> --
> 1.9.3
prev parent reply other threads:[~2016-01-18 6:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 6:43 Lijuan Tu
2016-01-18 6:57 ` Liu, Yong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E13B0D978@SHSMSX103.ccr.corp.intel.com \
--to=yong.liu@intel.com \
--cc=dts@dpdk.org \
--cc=lijuanx.a.tu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).