test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Qiu, Michael" <michael.qiu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH] tests: support RRC nic
Date: Thu, 21 Jan 2016 07:09:37 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E13B121A1@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <533710CFB86FA344BFBF2D6802E6028622F1E96C@SHSMSX101.ccr.corp.intel.com>

Michael,
Before fm10k NICs validation, we have add rules to enable PEP redirect to assigned EPL. 
There won't be flood even dst mac incorrect, so skip disable promisc mode. 

> -----Original Message-----
> From: Qiu, Michael
> Sent: Thursday, January 21, 2016 3:04 PM
> To: Liu, Yong; dts@dpdk.org
> Subject: Re: [dts] [PATCH] tests: support RRC nic
> 
> On 1/20/2016 10:21 AM, Yong Liu wrote:
> > RRC validation enabled on checksum offload, jumboframe, mac
> > filter, rss, queue start stop, scatter, tso and vlan.
> >
> > Signed-off-by: Marvin Liu <yong.liu@intel.com>
> >
> > diff --git a/tests/TestSuite_checksum_offload.py
> b/tests/TestSuite_checksum_offload.py
> > index 7a53452..3522c80 100644
> > --- a/tests/TestSuite_checksum_offload.py
> > +++ b/tests/TestSuite_checksum_offload.py
> > @@ -68,7 +68,6 @@ class TestChecksumOffload(TestCase):
> >                                        (self.portMask) + "--disable-hw-
> vlan --enable-rx-cksum --crc-strip", socket=self.ports_socket)
> >              self.dut.send_expect("set verbose 1", "testpmd>")
> >              self.dut.send_expect("set fwd csum", "testpmd>")
> > -            self.dut.send_expect("set promisc all off", "testpmd>")
> 
> Why disable promisc mode?
> 
> Thanks,
> Michael
> >
> >      def checksum_enablehw(self, port):
> >              self.dut.send_expect("csum set ip hw %d" % port, "testpmd>")
> > @@ -89,15 +88,13 @@ class TestChecksumOffload(TestCase):
> >          tx_interface =
> self.tester.get_interface(self.tester.get_local_port(self.dut_ports[1]))
> >          rx_interface =
> self.tester.get_interface(self.tester.get_local_port(self.dut_ports[0]))
> >
> [...]

      reply	other threads:[~2016-01-21  7:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-20  2:20 Yong Liu
2016-01-20  8:43 ` Liu, Yong
2016-01-21  7:04 ` Qiu, Michael
2016-01-21  7:09   ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E13B121A1@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=michael.qiu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).