test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Tu, LijuanX A" <lijuanx.a.tu@intel.com>,
	"Xu, Qian Q" <qian.q.xu@intel.com>,
	"Xu, HuilongX" <huilongx.xu@intel.com>,
	"Pei, Yulong" <yulong.pei@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH]tests vf_rss: use get_port_mac() to get vf mac in	testpmd, add nh=132 to assign sctp packet
Date: Fri, 26 Feb 2016 03:11:09 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E144FC409@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1456363680-12939-1-git-send-email-lijuanx.a.tu@intel.com>

Applied. Thanks.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Lijuan Tu
> Sent: Thursday, February 25, 2016 9:28 AM
> To: Xu, Qian Q; Xu, HuilongX; Pei, Yulong; dts@dpdk.org
> Subject: [dts] [PATCH]tests vf_rss: use get_port_mac() to get vf mac in
> testpmd, add nh=132 to assign sctp packet
> 
> Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
> ---
>  tests/TestSuite_vf_rss.py | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_vf_rss.py b/tests/TestSuite_vf_rss.py
> index 9b6ee6f..0e83832 100644
> --- a/tests/TestSuite_vf_rss.py
> +++ b/tests/TestSuite_vf_rss.py
> @@ -58,7 +58,7 @@ class TestVfRss(TestCase):
>          self.tester.scapy_append('sys.path.append("./")')
>          self.tester.scapy_append('from sctp import *')
>          self.vm_dut_0.send_expect("start", "testpmd>")
> -        mac = self.vm_dut_0.get_mac_address(0)
> +        mac = self.vm0_testpmd.get_port_mac(0)
>          # send packet with different source and dest ip
>          if tran_type == "ipv4-other":
>              for i in range(16):
> @@ -124,12 +124,12 @@ class TestVfRss(TestCase):
>                  time.sleep(.5)
>          elif tran_type == "ipv6-sctp":
>              for i in range(16):
> -                packet =
> r'sendp([Ether(dst="%s")/IPv6(src="3ffe:2501:200:1fff::%d",
> dst="3ffe:2501:200:3::%d")/SCTP(sport=1024,dport=1025,tag=1)], iface="%s")' %
> (
> +                packet =
> r'sendp([Ether(dst="%s")/IPv6(src="3ffe:2501:200:1fff::%d",
> dst="3ffe:2501:200:3::%d", nh=132)/SCTP(sport=1024,dport=1025,tag=1)],
> iface="%s")' % (
>                      mac, i + 1, i + 2, itf)
>                  self.tester.scapy_append(packet)
>                  self.tester.scapy_execute()
>                  time.sleep(.5)
> -                packet =
> r'sendp([Ether(dst="%s")/IPv6(src="3ffe:2501:200:1fff::%d",
> dst="3ffe:2501:200:3::%d")/SCTP(sport=1025,dport=1024,tag=1)], iface="%s")' %
> (
> +                packet =
> r'sendp([Ether(dst="%s")/IPv6(src="3ffe:2501:200:1fff::%d",
> dst="3ffe:2501:200:3::%d", nh=132)/SCTP(sport=1025,dport=1024,tag=1)],
> iface="%s")' % (
>                      mac, i + 2, i + 1, itf)
>                  self.tester.scapy_append(packet)
>                  self.tester.scapy_execute()
> @@ -221,6 +221,7 @@ class TestVfRss(TestCase):
>          self.verify(len(self.dut_ports) >= 1, "Not enough ports available")
> 
>          self.vm0 = None
> +        self.host_testpmd = None
>          self.setup_1pf_1vf_1vm_env_flag = 0
>          self.setup_1pf_1vf_1vm_env(driver='')
> 
> --
> 2.5.0

      reply	other threads:[~2016-02-26  3:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-25  1:28 Lijuan Tu
2016-02-26  3:11 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E144FC409@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=huilongx.xu@intel.com \
    --cc=lijuanx.a.tu@intel.com \
    --cc=qian.q.xu@intel.com \
    --cc=yulong.pei@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).