test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Fu, JingguoX" <jingguox.fu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: Jingguo Fu <jingguox.fu@intel.comwq>
Subject: Re: [dts] [DTS][PATCH 1/2] unit test: add memcpy performance unit test plan
Date: Wed, 9 Mar 2016 01:05:04 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E145056CE@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1457416106-17525-1-git-send-email-jingguox.fu@intel.com>

Jingguo, some comments below.

> -----Original Message-----
> From: Fu, JingguoX
> Sent: Tuesday, March 08, 2016 1:48 PM
> To: dts@dpdk.org
> Cc: Liu, Yong; Xu, Qian Q; Jingguo Fu
> Subject: [DTS][PATCH 1/2] unit test: add memcpy performance unit test
> plan
> 
> From: Jingguo Fu <jingguox.fu@intel.comwq>
> 
>     case name: memcpy_perf_analysis
>           it will show four ratio value for the performance
> 
> Signed-off-by: Jingguo Fu <jingguox.fu@intel.comwq>
> ---
>  test_plans/unit_tests_memcpy_perf_test_plan.rst | 69
> +++++++++++++++++++++++++
>  1 file changed, 69 insertions(+)
>  create mode 100644 test_plans/unit_tests_memcpy_perf_test_plan.rst
> 
> diff --git a/test_plans/unit_tests_memcpy_perf_test_plan.rst
> b/test_plans/unit_tests_memcpy_perf_test_plan.rst
> new file mode 100644
> index 0000000..35b646b
> --- /dev/null
> +++ b/test_plans/unit_tests_memcpy_perf_test_plan.rst
> @@ -0,0 +1,69 @@
> +.. Copyright (c) <2010, 2016>, Intel Corporation
> +   All rights reserved.
> +
> +   Redistribution and use in source and binary forms, with or without
> +   modification, are permitted provided that the following conditions
> +   are met:
> +
> +   - Redistributions of source code must retain the above copyright
> +     notice, this list of conditions and the following disclaimer.
> +
> +   - Redistributions in binary form must reproduce the above copyright
> +     notice, this list of conditions and the following disclaimer in
> +     the documentation and/or other materials provided with the
> +     distribution.
> +
> +   - Neither the name of Intel Corporation nor the names of its
> +     contributors may be used to endorse or promote products derived
> +     from this software without specific prior written permission.
> +
> +   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> +   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> +   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
> +   FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
> +   COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
> +   INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
> +   (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
> +   SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
> +   HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
> +   STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> +   ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
> +   OF THE POSSIBILITY OF SUCH DAMAGE.
> +
> +======================
> +Test suite description
> +======================
> +
> +This document is for dpdk unit test: memcpy performance auto test.
> +For this suite, manily aims to analysis the cache to cache memcopy
Typo, should be "mainly" and  "memcpy".

> +performance after run the memcpy performance unit test.
> +
> +The performance data is divided into four parts. Each part has two
> +colums data for cache to cache performance. After extract the data,

Could you show one basic sample for performance data, it’s hard to understand from your description.

> +compute the geomatric mean for each colum, and then let the second
> +geomatric divide the first goematric mean, then get the ratio of the
> +two geomatric means.
> +
> +if the ratio greater than 1, then the test got a great performance.
> +
> +
> +=============
> +Prerequisites
> +=============
> +
> +Test Case: memcpy_perf_analysis
> +===============================
> +
> +1. run memcpy_perf unit test
> +    ./x86_64-native-linuxapp-gcc/app/test -c f -n 1
> +    memcpy_perf_autotest
> +    quit
> +    performance data stored in  memcpy_perf_auto.log file
> +
> +2. copy log file to current server
> +3. analysis the data
> ++--------------------+-----------------------+------------------+-------
> --------------+
> +| 32B Aligned(ticks) | 32B Aligned CT(ticks) | Unaligned(ticks) |
> Unaligned CT(ticks) |
> ++====================+=======================+==================+=======
> ==============+
> +| 1.893              | 2.509                 | 1.507            | 1.500
> |
> ++--------------------+-----------------------+------------------+-------
> --------------+
Could you give basic description of "CT", it’s hard to understand the meaning of it.

> --
> 1.9.3

  parent reply	other threads:[~2016-03-09  1:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-08  5:48 Jingguo Fu
2016-03-08  5:48 ` [dts] [DTS][PATCH 2/2] unit test: add memcpy performance unit test case Jingguo Fu
2016-03-09  1:05 ` Liu, Yong [this message]
2016-03-10  8:36   ` [dts] [DTS][PATCH 1/2] unit test: add memcpy performance unit test plan Fu, JingguoX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E145056CE@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=jingguox.fu@intel.com \
    --cc=jingguox.fu@intel.comwq \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).