From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id D1D525902 for ; Fri, 18 Mar 2016 08:10:36 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP; 18 Mar 2016 00:10:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,353,1455004800"; d="scan'208";a="68810793" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga004.fm.intel.com with ESMTP; 18 Mar 2016 00:10:36 -0700 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 18 Mar 2016 00:10:35 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 18 Mar 2016 00:10:35 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.24]) by shsmsx102.ccr.corp.intel.com ([169.254.2.232]) with mapi id 14.03.0248.002; Fri, 18 Mar 2016 15:10:33 +0800 From: "Liu, Yong" To: "Xu, HuilongX" , "dts@dpdk.org" CC: "Xu, HuilongX" Thread-Topic: [dts] [PATCH V1] update ixgbe nic tpid command Thread-Index: AQHRgLkagIMLt1K1D0SJ+oBylXjBJ59ex5xg Date: Fri, 18 Mar 2016 07:10:32 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E14EC6C1F@SHSMSX103.ccr.corp.intel.com> References: <1458265788-92427-1-git-send-email-huilongx.xu@intel.com> In-Reply-To: <1458265788-92427-1-git-send-email-huilongx.xu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTc5M2NjYzItMTUwNy00ODU3LWE2ZWEtZDE4Yzg2M2EzYzBmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IksySzJYRmZQaklwanJoYXQ1YWx1ck93WktXYmhVNVRCc1NlVDdVRzNPYXc9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] update ixgbe nic tpid command X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2016 07:10:37 -0000 Hi Huilong, Look like this case only cover inner tpid, is there any case for outer tpid= ? Please remember to update test plan simultaneously. Thanks. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong > Sent: Friday, March 18, 2016 9:50 AM > To: dts@dpdk.org > Cc: Xu, HuilongX > Subject: [dts] [PATCH V1] update ixgbe nic tpid command >=20 > Signed-off-by: xu,huilong > --- > tests/TestSuite_dual_vlan.py | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py > index 84552f5..a4ae23e 100644 > --- a/tests/TestSuite_dual_vlan.py > +++ b/tests/TestSuite_dual_vlan.py > @@ -364,14 +364,15 @@ class TestDualVlan(TestCase): > self.verify(self.nic not in ["fortville_eagle", > "fortville_spirit", "fortville_spirit_single", "hartwell"], "%s NIC not > support tcpid " % self.nic) >=20 > self.mode_config(filter=3D"on", strip=3D"on", qinq=3D"on") > - self.dut.send_expect("vlan set tpid 1234 %s" % dutRxPortId, > "testpmd> ") > + # nic only support inner model, except fortville nic > + self.dut.send_expect("vlan set inner tpid 1234 %s" % dutRxPortId= , > "testpmd> ") > self.vlan_send_packet(outvlan, invlan) >=20 > out =3D self.get_tcpdump_package() > self.verify("vlan %s" % outvlan in out, "vlan tpid disable error= : > " + out) > self.verify("vlan %s" % invlan in out, "vlan tpid disable error: > " + out) >=20 > - self.dut.send_expect("vlan set tpid 0x8100 %s" % dutRxPortId, > "testpmd> ") > + self.dut.send_expect("vlan set inner tpid 0x8100 %s" % > dutRxPortId, "testpmd> ") > self.vlan_send_packet(outvlan, invlan) >=20 > out =3D self.get_tcpdump_package() > -- > 1.9.3