From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 2DEF82BD2 for ; Fri, 29 Apr 2016 19:48:41 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP; 29 Apr 2016 10:48:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,552,1455004800"; d="scan'208";a="94415722" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga004.fm.intel.com with ESMTP; 29 Apr 2016 10:48:29 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 29 Apr 2016 10:48:29 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 29 Apr 2016 10:48:29 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.229]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.184]) with mapi id 14.03.0248.002; Sat, 30 Apr 2016 01:48:28 +0800 From: "Liu, Yong" To: "Xu, HuilongX" , "dts@dpdk.org" CC: "Xu, HuilongX" Thread-Topic: [dts] [PATCH V2][dts 2/2] add allmutlicast and broadcast test case Thread-Index: AQHRnF1C604LCNwOh06TOLLH3mHwiZ+hRKsg Date: Fri, 29 Apr 2016 17:48:26 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E14F0B078@SHSMSX103.ccr.corp.intel.com> References: <1461304956-20509-1-git-send-email-huilongx.xu@intel.com> <1461304956-20509-2-git-send-email-huilongx.xu@intel.com> In-Reply-To: <1461304956-20509-2-git-send-email-huilongx.xu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYThkMzkxYWItZTA2NS00NTU2LWFhNDAtODc2Yjg1NWUyZTQ2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImgwMTlVZzNtQkFXZHczZ0kwc3ZIcmt0RU1xRWZqSUw1ZkJyb20zbGxUUmM9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V2][dts 2/2] add allmutlicast and broadcast test case X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Apr 2016 17:48:41 -0000 Thanks, one question below. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong > Sent: Thursday, April 21, 2016 11:03 PM > To: dts@dpdk.org > Cc: Xu, HuilongX > Subject: [dts] [PATCH V2][dts 2/2] add allmutlicast and broadcast test > case >=20 > Signed-off-by: xu,huilong > --- > tests/TestSuite_dynamic_config.py | 69 ++++++++++++++++++++++++++++++++-= - > ----- > 1 file changed, 58 insertions(+), 11 deletions(-) >=20 > diff --git a/tests/TestSuite_dynamic_config.py > b/tests/TestSuite_dynamic_config.py > index ba740b1..380fa6d 100644 > --- a/tests/TestSuite_dynamic_config.py > +++ b/tests/TestSuite_dynamic_config.py > @@ -1,6 +1,6 @@ > # BSD LICENSE > # > -# Copyright(c) 2010-2015 Intel Corporation. All rights reserved. > +# Copyright(c) 2010-2016 Intel Corporation. All rights reserved. > # All rights reserved. > # > # Redistribution and use in source and binary forms, with or without > @@ -67,18 +67,12 @@ class TestDynamicConfig(TestCase): > print self.dut_ports >=20 > # Verify that enough ports are available > - if self.nic in ["fortville_eagle", "fortville_spirit", > "fortville_spirit_single"]: > - self.verify(len(self.dut_ports) >=3D 2, "Insufficient ports"= ) > - else: > - self.verify(len(self.dut_ports) >=3D 1, "Insufficient ports"= ) > + self.verify(len(self.dut_ports) >=3D 2, "Insufficient ports") >=20 > # Prepare cores and ports > cores =3D self.dut.get_core_list('1S/2C/2T') > coreMask =3D dts.create_mask(cores) > - if self.nic in ["fortville_eagle", "fortville_spirit", > "fortville_spirit_single"]: > - portMask =3D dts.create_mask(self.dut_ports[:2]) > - else: > - portMask =3D dts.create_mask([self.dut_ports[0]]) > + portMask =3D dts.create_mask(self.dut_ports[:2]) One question here, is this case must need two ports? Reduce port requiremen= t is our long time strategy.=20 It will benefit for some NIC which only one port available.=20 >=20 > # launch app > cmd =3D "./%s/build/app/test-pmd/testpmd -c %s -n 3 -- -i --rxpt= =3D0 > \ > @@ -99,8 +93,7 @@ class TestDynamicConfig(TestCase): > self.verify(cmp(ret.lower(), self.dest) =3D=3D 0, "MAC address w= rong") > self.verify("Promiscuous mode: enabled" in out, > "wrong default promiscuous value") > - if self.nic in ["fortville_eagle", "fortville_spirit", > "fortville_spirit_single"]: > - self.dut.send_expect("start", "testpmd> ", 120) > + self.dut.send_expect("start", "testpmd> ", 120) >=20 > def dynamic_config_send_packet(self, portid, > destMac=3D"00:11:22:33:44:55"): > """ > @@ -129,6 +122,7 @@ class TestDynamicConfig(TestCase): > portid =3D self.dut_ports[0] >=20 > # get the current rx statistic > + out =3D self.dut.send_expect("clear port stats all" , "testpmd> = ") > out =3D self.dut.send_expect("show port stats %d" % portid, > "testpmd> ") > cur_rxpkt =3D dts.regexp(out, "RX-packets: ([0-9]+)") >=20 > @@ -211,7 +205,60 @@ class TestDynamicConfig(TestCase): > # check the pakcet increasment > self.verify(int(cur_rxpkt) =3D=3D int( > pre_rxpkt) + 1, "2nd packet increasment error") > + def test_dynamic_config_broadcast(self): > + """ > + Dynamic config disable promiscuous, send a broadcast packet > + dpdk will received packet and fwd by io model. send a general > packet > + and dst mac not port mac, dpdk will not received packet. > + """ > + > + self.dut.send_expect("set promisc all off", "testpmd> ") > + self.dut.send_expect("set fwd io", "testpmd> ") > + self.dut.send_expect("clear port stats all", "testpmd> ") > + > + > self.dynamic_config_send_packet(self.dut_ports[0],"ff:ff:ff:ff:ff:ff") > + out =3D self.dut.send_expect( > + "show port stats %d" % self.dut_ports[1], "testpmd> ") > + > + cur_rxpkt =3D dts.regexp(out, "TX-packets: ([0-9]+)") > + self.verify(int(cur_rxpkt) =3D=3D 1, "1st packet increasment err= or") > + > + self.dut.send_expect("clear port stats all", "testpmd> ") > + > + self.dynamic_config_send_packet(self.dut_ports[0]) > + out =3D self.dut.send_expect( > + "show port stats %d" % self.dut_ports[1], "testpmd> ") > + > + cur_rxpkt =3D dts.regexp(out, "TX-packets: ([0-9]+)") > + self.verify(int(cur_rxpkt) =3D=3D 0, "2st packet increasment err= or") > + > + def test_dynamic_config_allmulticast(self): > + """ > + Dynamic config disable promiscuous,when dpdk enable multicast, > send a > + mulicast packet, dpdk received this packet and fwd by io model. > when dpdk > + disable multicast, dpdk not received this packet > + """ > + > + self.dut.send_expect("set promisc all off", "testpmd> ") > + self.dut.send_expect("set fwd io", "testpmd> ") > + self.dut.send_expect("clear port stats all", "testpmd> ") > + self.dut.send_expect("set allmulti all on", "testpmd> ") > + > self.dynamic_config_send_packet(self.dut_ports[0],"01:00:00:33:00:01") > + out =3D self.dut.send_expect( > + "show port stats %d" % self.dut_ports[1], "testpmd> ") > + > + cur_rxpkt =3D dts.regexp(out, "TX-packets: ([0-9]+)") > + self.verify(int(cur_rxpkt) =3D=3D 1, "1st packet increasment err= or") > + > + self.dut.send_expect("clear port stats all", "testpmd> ") > + self.dut.send_expect("set allmulti all off", "testpmd> ") > + > self.dynamic_config_send_packet(self.dut_ports[0],"01:00:00:33:00:01") > + out =3D self.dut.send_expect( > + "show port stats %d" % self.dut_ports[1], "testpmd> ") >=20 > + cur_rxpkt =3D dts.regexp(out, "TX-packets: ([0-9]+)") > + self.verify(int(cur_rxpkt) =3D=3D 0, "2st packet increasment err= or") > + > def test_dynamic_config_enable_promiscuous(self): > """ > Dynamic config enable promiscuous test > -- > 1.9.3