From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 4FCFA2C37 for ; Fri, 29 Apr 2016 20:19:41 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP; 29 Apr 2016 11:19:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,552,1455004800"; d="scan'208";a="955704875" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 29 Apr 2016 11:19:19 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 29 Apr 2016 11:19:17 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 29 Apr 2016 11:19:17 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.229]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.155]) with mapi id 14.03.0248.002; Sat, 30 Apr 2016 02:19:15 +0800 From: "Liu, Yong" To: "Xu, GangX" , "dts@dpdk.org" CC: "Xu, GangX" Thread-Topic: [dts] [PATCH V1 1/4] add rxtx_callbacks code Thread-Index: AQHRofE++QhmUSS9f0yvA4eVssr0ep+hQsRA Date: Fri, 29 Apr 2016 18:19:15 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E14F0B1D1@SHSMSX103.ccr.corp.intel.com> References: <1461918263-32864-1-git-send-email-gangx.xu@intel.com> In-Reply-To: <1461918263-32864-1-git-send-email-gangx.xu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzg1YTExODMtZDU3NS00NmYxLWI2Y2EtNDkyOWRhMDEwZGU1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ing0N2dBSkZvaUU0cG1pWldvemZoQ0RBR0hhQ0x1bjRwamVaYUVxUHVvK2M9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1 1/4] add rxtx_callbacks code X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Apr 2016 18:19:41 -0000 Gang, few comments below. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang > Sent: Friday, April 29, 2016 1:24 AM > To: dts@dpdk.org > Cc: Xu, GangX > Subject: [dts] [PATCH V1 1/4] add rxtx_callbacks code >=20 > Signed-off-by: xu,gang > --- > tests/TestSuite_rxtx_callbacks.py | 116 > ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 116 insertions(+) > create mode 100644 tests/TestSuite_rxtx_callbacks.py >=20 > diff --git a/tests/TestSuite_rxtx_callbacks.py > b/tests/TestSuite_rxtx_callbacks.py > new file mode 100644 > index 0000000..6da402d > --- /dev/null > +++ b/tests/TestSuite_rxtx_callbacks.py > @@ -0,0 +1,116 @@ > +#BSD LICENSE > +# > +# Copyright(c) 2010-2014 Intel Corporation. All rights reserved. > +# All rights reserved. > +# > +# Redistribution and use in source and binary forms, with or without > +# modification, are permitted provided that the following conditions > +# are met: > +# > +# * Redistributions of source code must retain the above copyright > +# notice, this list of conditions and the following disclaimer. > +# * Redistributions in binary form must reproduce the above copyright > +# notice, this list of conditions and the following disclaimer in > +# the documentation and/or other materials provided with the > +# distribution. > +# * Neither the name of Intel Corporation nor the names of its > +# contributors may be used to endorse or promote products derived > +# from this software without specific prior written permission. > +# > +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR > +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT > +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, > +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > + > + > +""" > +DPDK Test suite. > +Test Netmap_compat. =20 Netmap should not be here. > +""" > +import dts > +import string > +import time > +from test_case import TestCase > +from plotting import Plotting > +from settings import HEADER_SIZE > +from etgen import IxiaPacketGenerator > + > +from packet import Packet, sniff_packets, load_sniff_packets > + > + > +class TestRxtxCallbacks(TestCase): > + > + def set_up_all(self): > + """ > + Run at the start of each test suite. > + timer prerequistites > + """ > + self.dut_ports =3D self.dut.get_ports(self.nic) > + self.verify(len(self.dut_ports) >=3D 2, "Insufficient ports") > + > + cores =3D self.dut.get_core_list("1S/2C/1T") > + self.coremask =3D dts.create_mask(cores) > + > + self.mac =3D self.dut.get_mac_address(self.dut_ports[0]) > + self.path =3D "./examples/rxtx_callbacks/build/rxtx_callbacks" > + > + out =3D self.dut.build_dpdk_apps("./examples/rxtx_callbacks") > + self.verify("Error" not in out, "compilation error 1") > + self.verify("No such file" not in out, "compilation error 2") > + > + def set_up(self): > + """ > + Run before each test case. > + """ > + pass > + > + def test_rxtx_callbacks(self): > + cmd =3D self.path + " -c %s -n %d " % > (self.coremask,self.dut.get_memory_channels()) > + self.dut.send_expect(cmd,"forwarding packets",60) > + > + self.iface_port0 =3D > self.tester.get_interface(self.tester.get_local_port(self.dut_ports[0])) > + self.iface_port1 =3D > self.tester.get_interface(self.tester.get_local_port(self.dut_ports[1])) > + > + self.inst_port1 =3D sniff_packets(self.iface_port1) > + self.scapy_send_package(self.iface_port0) > + > + out_port1 =3D self.get_tcpdump_package(self.inst_port1) > + self.verify(self.mac in out_port1, "Wrong: can't get package > at %s " % self.inst_port1) > + > + > + def scapy_send_package(self,iface): > + """ > + Send a packet to port > + """ Typo issue, package should be packet. > + > self.tester.scapy_append('sendp([Ether(dst=3D"%s")/IP()/UDP()/Raw(\'X\'*1= 8)], > iface=3D"%s")' % (self.mac, iface)) > + self.tester.scapy_execute() > + You can use packet module send_pkt function for sending packets. > + def get_tcpdump_package(self,inst): > + pkts =3D load_sniff_packets(inst) > + dsts =3D [] > + for packet in pkts: > + dst =3D packet.strip_element_layer2("dst") > + dsts.append(dst) > + return dsts > + > + def tear_down(self): > + """ > + Run after each test case. > + """ > + self.dut.kill_all() > + time.sleep(2) > + > + > + def tear_down_all(self): > + """ > + Run after each test suite. > + """ > + pass > + > -- > 1.9.3