test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Rosen, Rami" <rami.rosen@intel.com>
Cc: "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH] framework: Fix a wrong parameter in traffic_generator_loss().
Date: Mon, 23 May 2016 20:50:44 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E2221B8F1@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1463426493-24597-1-git-send-email-rami.rosen@intel.com>

Applied, thanks.

> -----Original Message-----
> From: Rosen, Rami
> Sent: Monday, May 16, 2016 12:22 PM
> To: Liu, Yong
> Cc: dts@dpdk.org; Rosen, Rami
> Subject: [PATCH] framework: Fix a wrong parameter in
> traffic_generator_loss().
> 
> This patch fixes a wrong parameter in traffic_generator_loss() method,
> in framework/tester.py. Using the existing ratePercenti parameter will
> cause
> this error: "NameError: global name 'ratePercenti' is not defined".
> Instead of ratePercenti it should be ratePercent.
> 
> Signed-off-by: Rami Rosen <rami.rosen@intel.com>
> ---
>  framework/tester.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/framework/tester.py b/framework/tester.py
> index 76ceeb4..63f19e9 100644
> --- a/framework/tester.py
> +++ b/framework/tester.py
> @@ -489,7 +489,7 @@ class Tester(Crb):
>          elif not self.check_port_list(portList):
>              self.logger.warning("exception by mixed port types")
>              return None
> -        return self.packet_gen.loss(portList, ratePercenti, delay)
> +        return self.packet_gen.loss(portList, ratePercent, delay)
> 
>      def traffic_generator_latency(self, portList, ratePercent=100,
> delay=5):
>          """
> --
> 2.4.3

      reply	other threads:[~2016-05-23 20:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-16 19:21 Rami Rosen
2016-05-23 20:50 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E2221B8F1@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=rami.rosen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).