test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] framework: Fix a wrong parameter in traffic_generator_loss().
@ 2016-05-16 19:21 Rami Rosen
  2016-05-23 20:50 ` Liu, Yong
  0 siblings, 1 reply; 2+ messages in thread
From: Rami Rosen @ 2016-05-16 19:21 UTC (permalink / raw)
  To: yong.liu; +Cc: dts, Rami Rosen

This patch fixes a wrong parameter in traffic_generator_loss() method,
in framework/tester.py. Using the existing ratePercenti parameter will cause
this error: "NameError: global name 'ratePercenti' is not defined".
Instead of ratePercenti it should be ratePercent.

Signed-off-by: Rami Rosen <rami.rosen@intel.com>
---
 framework/tester.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/tester.py b/framework/tester.py
index 76ceeb4..63f19e9 100644
--- a/framework/tester.py
+++ b/framework/tester.py
@@ -489,7 +489,7 @@ class Tester(Crb):
         elif not self.check_port_list(portList):
             self.logger.warning("exception by mixed port types")
             return None
-        return self.packet_gen.loss(portList, ratePercenti, delay)
+        return self.packet_gen.loss(portList, ratePercent, delay)
 
     def traffic_generator_latency(self, portList, ratePercent=100, delay=5):
         """
-- 
2.4.3

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH] framework: Fix a wrong parameter in traffic_generator_loss().
  2016-05-16 19:21 [dts] [PATCH] framework: Fix a wrong parameter in traffic_generator_loss() Rami Rosen
@ 2016-05-23 20:50 ` Liu, Yong
  0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2016-05-23 20:50 UTC (permalink / raw)
  To: Rosen, Rami; +Cc: dts

Applied, thanks.

> -----Original Message-----
> From: Rosen, Rami
> Sent: Monday, May 16, 2016 12:22 PM
> To: Liu, Yong
> Cc: dts@dpdk.org; Rosen, Rami
> Subject: [PATCH] framework: Fix a wrong parameter in
> traffic_generator_loss().
> 
> This patch fixes a wrong parameter in traffic_generator_loss() method,
> in framework/tester.py. Using the existing ratePercenti parameter will
> cause
> this error: "NameError: global name 'ratePercenti' is not defined".
> Instead of ratePercenti it should be ratePercent.
> 
> Signed-off-by: Rami Rosen <rami.rosen@intel.com>
> ---
>  framework/tester.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/framework/tester.py b/framework/tester.py
> index 76ceeb4..63f19e9 100644
> --- a/framework/tester.py
> +++ b/framework/tester.py
> @@ -489,7 +489,7 @@ class Tester(Crb):
>          elif not self.check_port_list(portList):
>              self.logger.warning("exception by mixed port types")
>              return None
> -        return self.packet_gen.loss(portList, ratePercenti, delay)
> +        return self.packet_gen.loss(portList, ratePercent, delay)
> 
>      def traffic_generator_latency(self, portList, ratePercent=100,
> delay=5):
>          """
> --
> 2.4.3

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-05-23 20:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-16 19:21 [dts] [PATCH] framework: Fix a wrong parameter in traffic_generator_loss() Rami Rosen
2016-05-23 20:50 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).