From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 0A1492B94 for ; Mon, 23 May 2016 22:50:48 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP; 23 May 2016 13:50:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,357,1459839600"; d="scan'208";a="983133993" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 23 May 2016 13:50:49 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 23 May 2016 13:50:47 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 23 May 2016 13:50:47 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.58]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.116]) with mapi id 14.03.0248.002; Tue, 24 May 2016 04:50:45 +0800 From: "Liu, Yong" To: "Rosen, Rami" CC: "dts@dpdk.org" Thread-Topic: [PATCH] framework: Fix a wrong parameter in traffic_generator_loss(). Thread-Index: AQHRr6fdplXMh1iTpUSevqRzzDMayp/HCjIg Date: Mon, 23 May 2016 20:50:44 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E2221B8F1@SHSMSX103.ccr.corp.intel.com> References: <1463426493-24597-1-git-send-email-rami.rosen@intel.com> In-Reply-To: <1463426493-24597-1-git-send-email-rami.rosen@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGQyMzZlMTQtZGU2NC00M2NiLTllNzEtOTkzMmE3OWQ1NzQwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImU5SjdLTGIzbzA2XC9QU2RCZnJVUHlHck5rT3p1U1lKdU9kdGtKdERmdm5vPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH] framework: Fix a wrong parameter in traffic_generator_loss(). X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 May 2016 20:50:49 -0000 Applied, thanks. > -----Original Message----- > From: Rosen, Rami > Sent: Monday, May 16, 2016 12:22 PM > To: Liu, Yong > Cc: dts@dpdk.org; Rosen, Rami > Subject: [PATCH] framework: Fix a wrong parameter in > traffic_generator_loss(). >=20 > This patch fixes a wrong parameter in traffic_generator_loss() method, > in framework/tester.py. Using the existing ratePercenti parameter will > cause > this error: "NameError: global name 'ratePercenti' is not defined". > Instead of ratePercenti it should be ratePercent. >=20 > Signed-off-by: Rami Rosen > --- > framework/tester.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/framework/tester.py b/framework/tester.py > index 76ceeb4..63f19e9 100644 > --- a/framework/tester.py > +++ b/framework/tester.py > @@ -489,7 +489,7 @@ class Tester(Crb): > elif not self.check_port_list(portList): > self.logger.warning("exception by mixed port types") > return None > - return self.packet_gen.loss(portList, ratePercenti, delay) > + return self.packet_gen.loss(portList, ratePercent, delay) >=20 > def traffic_generator_latency(self, portList, ratePercent=3D100, > delay=3D5): > """ > -- > 2.4.3