From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 847272A5E for ; Thu, 7 Jul 2016 07:35:19 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP; 06 Jul 2016 22:35:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,323,1464678000"; d="scan'208";a="1002310667" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 06 Jul 2016 22:35:18 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 6 Jul 2016 22:35:18 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.181]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.150]) with mapi id 14.03.0248.002; Thu, 7 Jul 2016 13:35:16 +0800 From: "Liu, Yong" To: "Tu, LijuanX A" , "dts@dpdk.org" CC: "Tu, LijuanX A" Thread-Topic: [dts] [PATCH v2]vf_vlan: fix crc-strip, renam dot1q , modify vlan rx tests Thread-Index: AQHR00Rw0Zw8Sg+VV0GjK3FOPGKqtqAMfBkw Date: Thu, 7 Jul 2016 05:35:15 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E222501D3@SHSMSX103.ccr.corp.intel.com> References: <1467341616-31579-1-git-send-email-lijuanx.a.tu@intel.com> In-Reply-To: <1467341616-31579-1-git-send-email-lijuanx.a.tu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWM4OGNmMjItYjgxMC00ZDUzLTk5YjMtZWQ3Y2U5NGFkY2M5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkJPVExBSXZcL1VqVyt1OG1TYWM1Y3IzK2xTcGtJYzZTVzFROVFDM3AwNjdzPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH v2]vf_vlan: fix crc-strip, renam dot1q , modify vlan rx tests X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jul 2016 05:35:20 -0000 Applied, thanks. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Lijuan Tu > Sent: Friday, July 01, 2016 10:54 AM > To: dts@dpdk.org > Cc: Tu, LijuanX A > Subject: [dts] [PATCH v2]vf_vlan: fix crc-strip, renam dot1q , modify vla= n > rx tests >=20 > 1, For fortville, dpdk16.07 will quit testpmd if VF can't disable HW CRC > Strip > 2, rename dot1q to vlan > 3, modify vlan rx tests > Enable vlan filter on port A > "vlan set filter vlan 0" > Add vlan x on port A > "rx_vlan add 1 0" > Send packets with vlan x ,and check packet can received > Remove vlan x on port A > "rx_vlan rm 1 0" > Send packets with vlan x ,and check packet can't received > more detail infomation see test plan. >=20 > Signed-off-by: Lijuan Tu > --- > tests/TestSuite_vf_vlan.py | 32 ++++++++++++++++++++++++-------- > 1 file changed, 24 insertions(+), 8 deletions(-) >=20 > diff --git a/tests/TestSuite_vf_vlan.py b/tests/TestSuite_vf_vlan.py > index e32e5bd..fc1527c 100644 > --- a/tests/TestSuite_vf_vlan.py > +++ b/tests/TestSuite_vf_vlan.py > @@ -152,7 +152,10 @@ class TestVfVlan(TestCase): > self.vm0_dut_ports =3D self.vm_dut_0.get_ports('any') >=20 > self.vm0_testpmd =3D PmdOutput(self.vm_dut_0) > - self.vm0_testpmd.start_testpmd(VM_CORES_MASK) > + if self.kdriver =3D=3D "i40e": > + self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '--crc-strip') > + else: > + self.vm0_testpmd.start_testpmd(VM_CORES_MASK) > self.vm0_testpmd.execute_cmd('set fwd mac') > self.vm0_testpmd.execute_cmd('start') >=20 > @@ -176,7 +179,7 @@ class TestVfVlan(TestCase): > pkt.config_layer('ether', {'dst': self.vf0_mac}) > elif pkt_type =3D=3D "VLAN_UDP": > pkt =3D Packet(pkt_type=3D'VLAN_UDP') > - pkt.config_layer('dot1q', {'vlan': vlan}) > + pkt.config_layer('vlan', {'vlan': vlan}) > pkt.config_layer('ether', {'dst': self.vf0_mac}) >=20 > pkt.send_pkt(tx_port=3Dself.tester_intf0) > @@ -197,7 +200,10 @@ class TestVfVlan(TestCase): > self.vm0_dut_ports =3D self.vm_dut_0.get_ports('any') >=20 > self.vm0_testpmd =3D PmdOutput(self.vm_dut_0) > - self.vm0_testpmd.start_testpmd(VM_CORES_MASK) > + if self.kdriver =3D=3D "i40e": > + self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '--crc-strip') > + else: > + self.vm0_testpmd.start_testpmd(VM_CORES_MASK) > self.vm0_testpmd.execute_cmd('set fwd rxonly') > self.vm0_testpmd.execute_cmd('set verbose 1') > self.vm0_testpmd.execute_cmd('start') > @@ -249,7 +255,7 @@ class TestVfVlan(TestCase): > pkts =3D load_sniff_packets(inst) > vlans =3D [] > for pkt in pkts: > - vlan =3D pkt.strip_element_dot1q("vlan") > + vlan =3D pkt.strip_element_vlan("vlan") > vlans.append(vlan) >=20 > self.verify( > @@ -262,7 +268,10 @@ class TestVfVlan(TestCase): > self.vm0_dut_ports =3D self.vm_dut_0.get_ports('any') >=20 > self.vm0_testpmd =3D PmdOutput(self.vm_dut_0) > - self.vm0_testpmd.start_testpmd(VM_CORES_MASK) > + if self.kdriver =3D=3D "i40e": > + self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '--crc-strip') > + else: > + self.vm0_testpmd.start_testpmd(VM_CORES_MASK) > self.vm0_testpmd.execute_cmd('set verbose 1') >=20 > for tx_vlan in tx_vlans: > @@ -283,10 +292,14 @@ class TestVfVlan(TestCase): > self.vm0_dut_ports =3D self.vm_dut_0.get_ports('any') >=20 > self.vm0_testpmd =3D PmdOutput(self.vm_dut_0) > - self.vm0_testpmd.start_testpmd(VM_CORES_MASK) > + if self.kdriver =3D=3D "i40e": > + self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '--crc-strip') > + else: > + self.vm0_testpmd.start_testpmd(VM_CORES_MASK) > self.vm0_testpmd.execute_cmd('set fwd rxonly') > self.vm0_testpmd.execute_cmd('set verbose 1') > self.vm0_testpmd.execute_cmd('vlan set strip on 0') > + self.vm0_testpmd.execute_cmd('vlan set filter on 0') > self.vm0_testpmd.execute_cmd('start') >=20 > # send packet without vlan > @@ -334,7 +347,7 @@ class TestVfVlan(TestCase): > # send packet with vlan > out =3D self.send_and_getout(vlan=3Drandom_vlan, pkt_type=3D"VLA= N_UDP") > self.verify( > - "received 1 packets" in out, "Not received vlan packet > without vlan filter!!!") > + "received 1 packets" not in out, "Received mismatched vlan > packet while vlan filter on") >=20 > self.vm0_testpmd.quit() >=20 > @@ -345,7 +358,10 @@ class TestVfVlan(TestCase): > self.vm0_dut_ports =3D self.vm_dut_0.get_ports('any') >=20 > self.vm0_testpmd =3D PmdOutput(self.vm_dut_0) > - self.vm0_testpmd.start_testpmd(VM_CORES_MASK) > + if self.kdriver =3D=3D "i40e": > + self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '--crc-strip') > + else: > + self.vm0_testpmd.start_testpmd(VM_CORES_MASK) > self.vm0_testpmd.execute_cmd('set fwd rxonly') > self.vm0_testpmd.execute_cmd('set verbose 1') > self.vm0_testpmd.execute_cmd('start') > -- > 1.9.3