From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id ED5F52986 for ; Thu, 7 Jul 2016 07:37:41 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 06 Jul 2016 22:37:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,323,1464678000"; d="scan'208";a="990521130" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga001.jf.intel.com with ESMTP; 06 Jul 2016 22:37:40 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 6 Jul 2016 22:37:40 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 6 Jul 2016 22:37:39 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.181]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.116]) with mapi id 14.03.0248.002; Thu, 7 Jul 2016 13:37:38 +0800 From: "Liu, Yong" To: "Tu, LijuanX A" , "dts@dpdk.org" CC: "Tu, LijuanX A" Thread-Topic: [dts] [PATCH v1]vf tests: enable crc-strip when start testpmd. Thread-Index: AQHR01M1iWZFVMJzpU21//izBBcZsKAMfJ8w Date: Thu, 7 Jul 2016 05:37:36 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E222501EB@SHSMSX103.ccr.corp.intel.com> References: <1467347952-31665-1-git-send-email-lijuanx.a.tu@intel.com> In-Reply-To: <1467347952-31665-1-git-send-email-lijuanx.a.tu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODY5MmQ5ZTYtODllMi00MzdiLThmMDItOWUwNDA3MDU1MDFiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImNZN095VHZWZ20zK2ljeXhJSnprb0JPaXptNFo2c1lkcFJiRVBWV3FDRlk9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH v1]vf tests: enable crc-strip when start testpmd. X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jul 2016 05:37:42 -0000 Thanks Lijuan, applied. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Lijuan Tu > Sent: Friday, July 01, 2016 12:39 PM > To: dts@dpdk.org > Cc: Tu, LijuanX A > Subject: [dts] [PATCH v1]vf tests: enable crc-strip when start testpmd. >=20 > releated tests: > vf_jumboframe, vf_macfilter, vf_packet_rxtx > vf_port_start_stop, vf_rss, vf_to_vf_nic_bridge >=20 > fortville VF can't disable HW crc-strip > testpmd disable crc-strip by default > dpdk 16.07 will quit when disable crc-strip failed. >=20 > Signed-off-by: Lijuan Tu > --- > tests/TestSuite_vf_jumboframe.py | 40 +++++++++++++---------------= - > ----- > tests/TestSuite_vf_macfilter.py | 16 +++++++------- > tests/TestSuite_vf_packet_rxtx.py | 15 ++++++++++--- > tests/TestSuite_vf_port_start_stop.py | 5 ++++- > tests/TestSuite_vf_rss.py | 12 ++++++++-- > tests/TestSuite_vf_to_vf_nic_bridge.py | 10 +++++++-- > 6 files changed, 57 insertions(+), 41 deletions(-) >=20 > diff --git a/tests/TestSuite_vf_jumboframe.py > b/tests/TestSuite_vf_jumboframe.py > index 71aa650..bac4a29 100644 > --- a/tests/TestSuite_vf_jumboframe.py > +++ b/tests/TestSuite_vf_jumboframe.py > @@ -190,12 +190,10 @@ class TestVfJumboFrame(TestCase): > self.dutobj.enable_jumbo(framesize=3DETHER_STANDARD_MTU) > time.sleep(2) >=20 > - self.vm_testpmd.start_testpmd("Default", "--max-pkt-len=3D%d -- > port-topology=3Dloop --txqflags=3D0x0" % (ETHER_STANDARD_MTU)) > if self.kdriver =3D=3D "i40e": > - # forville vf crc setting alias with host > - self.vm_testpmd.execute_cmd("port stop all") > - self.vm_testpmd.execute_cmd("port config all crc-strip on") > - self.vm_testpmd.execute_cmd("port start all") > + self.vm_testpmd.start_testpmd("Default", "--max-pkt-len=3D%d= -- > port-topology=3Dloop --crc-strip --txqflags=3D0x0" % (ETHER_STANDARD_MTU)= ) > + else: > + self.vm_testpmd.start_testpmd("Default", "--max-pkt-len=3D%d= -- > port-topology=3Dloop --txqflags=3D0x0" % (ETHER_STANDARD_MTU)) >=20 > self.vm_testpmd.execute_cmd("set fwd mac") > self.vm_testpmd.execute_cmd("start") > @@ -217,12 +215,10 @@ class TestVfJumboFrame(TestCase): > self.dutobj.enable_jumbo(framesize=3DETHER_JUMBO_FRAME_MTU) > time.sleep(2) >=20 > - self.vm_testpmd.start_testpmd("Default", "--max-pkt-len=3D%s -- > port-topology=3Dloop --txqflags=3D0x0" % (ETHER_JUMBO_FRAME_MTU)) > if self.kdriver =3D=3D "i40e": > - # forville vf crc setting alias with host > - self.vm_testpmd.execute_cmd("port stop all") > - self.vm_testpmd.execute_cmd("port config all crc-strip on") > - self.vm_testpmd.execute_cmd("port start all") > + self.vm_testpmd.start_testpmd("Default", "--max-pkt-len=3D%d= -- > port-topology=3Dloop --crc-strip --txqflags=3D0x0" % (ETHER_JUMBO_FRAME_M= TU)) > + else: > + self.vm_testpmd.start_testpmd("Default", "--max-pkt-len=3D%s= -- > port-topology=3Dloop --txqflags=3D0x0" % (ETHER_JUMBO_FRAME_MTU)) >=20 > self.vm_testpmd.execute_cmd("set fwd mac") > self.vm_testpmd.execute_cmd("start") > @@ -244,12 +240,10 @@ class TestVfJumboFrame(TestCase): > self.dutobj.enable_jumbo(framesize=3DETHER_STANDARD_MTU) > time.sleep(2) >=20 > - self.vm_testpmd.start_testpmd("Default", "--port-topology=3Dloop= -- > txqflags=3D0x0") > if self.kdriver =3D=3D "i40e": > - # forville vf crc setting alias with host > - self.vm_testpmd.execute_cmd("port stop all") > - self.vm_testpmd.execute_cmd("port config all crc-strip on") > - self.vm_testpmd.execute_cmd("port start all") > + self.vm_testpmd.start_testpmd("Default", "--port- > topology=3Dloop --crc-strip --txqflags=3D0x0" ) > + else: > + self.vm_testpmd.start_testpmd("Default", "--port- > topology=3Dloop --txqflags=3D0x0") >=20 > self.vm_testpmd.execute_cmd("set fwd mac") > self.vm_testpmd.execute_cmd("start") > @@ -270,12 +264,10 @@ class TestVfJumboFrame(TestCase): > self.dutobj.enable_jumbo(framesize=3DETHER_JUMBO_FRAME_MTU) > time.sleep(2) >=20 > - self.vm_testpmd.start_testpmd("Default", "--max-pkt-len=3D%s -- > port-topology=3Dloop --txqflags=3D0x0" % (ETHER_JUMBO_FRAME_MTU)) > if self.kdriver =3D=3D "i40e": > - # forville vf crc setting alias with host > - self.vm_testpmd.execute_cmd("port stop all") > - self.vm_testpmd.execute_cmd("port config all crc-strip on") > - self.vm_testpmd.execute_cmd("port start all") > + self.vm_testpmd.start_testpmd("Default", "--max-pkt-len=3D%d= -- > port-topology=3Dloop --crc-strip --txqflags=3D0x0" % (ETHER_JUMBO_FRAME_M= TU)) > + else: > + self.vm_testpmd.start_testpmd("Default", "--max-pkt-len=3D%s= -- > port-topology=3Dloop --txqflags=3D0x0" % (ETHER_JUMBO_FRAME_MTU)) >=20 > self.vm_testpmd.execute_cmd("set fwd mac") > self.vm_testpmd.execute_cmd("start") > @@ -298,12 +290,10 @@ class TestVfJumboFrame(TestCase): > self.dutobj.enable_jumbo(framesize=3DETHER_JUMBO_FRAME_MTU) > time.sleep(2) >=20 > - self.vm_testpmd.start_testpmd("Default", "--max-pkt-len=3D%s -- > port-topology=3Dloop --txqflags=3D0x0" % (ETHER_JUMBO_FRAME_MTU)) > if self.kdriver =3D=3D "i40e": > - # forville vf crc setting alias with host > - self.vm_testpmd.execute_cmd("port stop all") > - self.vm_testpmd.execute_cmd("port config all crc-strip on") > - self.vm_testpmd.execute_cmd("port start all") > + self.vm_testpmd.start_testpmd("Default", "--max-pkt-len=3D%d= -- > port-topology=3Dloop --crc-strip --txqflags=3D0x0" % (ETHER_JUMBO_FRAME_M= TU)) > + else: > + self.vm_testpmd.start_testpmd("Default", "--max-pkt-len=3D%s= -- > port-topology=3Dloop --txqflags=3D0x0" % (ETHER_JUMBO_FRAME_MTU)) >=20 > self.vm_testpmd.execute_cmd("set fwd mac") > self.vm_testpmd.execute_cmd("start") > diff --git a/tests/TestSuite_vf_macfilter.py > b/tests/TestSuite_vf_macfilter.py > index 1f7fbfb..061f7ab 100644 > --- a/tests/TestSuite_vf_macfilter.py > +++ b/tests/TestSuite_vf_macfilter.py > @@ -115,13 +115,13 @@ class TestVfMacFilter(TestCase): >=20 > self.vm0_dut_ports =3D self.vm_dut_0.get_ports('any') > self.vm0_testpmd =3D PmdOutput(self.vm_dut_0) > - self.vm0_testpmd.start_testpmd(VM_CORES_MASK) > + if self.kdriver =3D=3D "i40e": > + self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '--crc-strip') > + else: > + self.vm0_testpmd.start_testpmd(VM_CORES_MASK) > # Get VF's MAC > pmd_vf0_mac =3D self.vm0_testpmd.get_port_mac(0) > vf0_wrongmac =3D "00:11:22:33:48:55" > - self.vm0_testpmd.execute_cmd('port stop all') > - self.vm0_testpmd.execute_cmd('port config all crc-strip on') > - self.vm0_testpmd.execute_cmd('port start all') > self.vm0_testpmd.execute_cmd('set promisc all off') > self.vm0_testpmd.execute_cmd('set fwd mac') > self.vm0_testpmd.execute_cmd('start') > @@ -162,15 +162,15 @@ class TestVfMacFilter(TestCase): >=20 > self.vm0_dut_ports =3D self.vm_dut_0.get_ports('any') > self.vm0_testpmd =3D PmdOutput(self.vm_dut_0) > - self.vm0_testpmd.start_testpmd(VM_CORES_MASK) > + if self.kdriver =3D=3D "i40e": > + self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '--crc-strip') > + else: > + self.vm0_testpmd.start_testpmd(VM_CORES_MASK) >=20 > # Get VF0 port MAC address > pmd_vf0_mac =3D self.vm0_testpmd.get_port_mac(0) > vf0_setmac =3D "00:11:22:33:44:55" > vf0_wrongmac =3D "00:11:22:33:48:55" > - self.vm0_testpmd.execute_cmd('port stop all') > - self.vm0_testpmd.execute_cmd('port config all crc-strip on') > - self.vm0_testpmd.execute_cmd('port start all') > self.vm0_testpmd.execute_cmd('set promisc all off') > ret =3D self.vm0_testpmd.execute_cmd('mac_addr add > 0 %s' %vf0_setmac) > # check the operation is supported or not. > diff --git a/tests/TestSuite_vf_packet_rxtx.py > b/tests/TestSuite_vf_packet_rxtx.py > index 599bc8d..2f9dfc1 100644 > --- a/tests/TestSuite_vf_packet_rxtx.py > +++ b/tests/TestSuite_vf_packet_rxtx.py > @@ -111,7 +111,10 @@ class TestVfPacketRxtx(TestCase): > self.vm0_dut_ports =3D self.vm_dut_0.get_ports('any') > port_id_0 =3D 0 > self.vm0_testpmd =3D PmdOutput(self.vm_dut_0) > - self.vm0_testpmd.start_testpmd(VM_CORES_MASK) > + if self.kdriver =3D=3D "i40e": > + self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '--crc-strip') > + else: > + self.vm0_testpmd.start_testpmd(VM_CORES_MASK) > self.vm0_testpmd.execute_cmd('port stop all') > self.vm0_testpmd.execute_cmd('port config all crc-strip on') > self.vm0_testpmd.execute_cmd('port start all') > @@ -241,7 +244,10 @@ class TestVfPacketRxtx(TestCase): > port_id_1 =3D 1 >=20 > self.vm0_testpmd =3D PmdOutput(self.vm_dut_0) > - self.vm0_testpmd.start_testpmd(VM_CORES_MASK) > + if self.kdriver =3D=3D "i40e": > + self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '--crc-strip') > + else: > + self.vm0_testpmd.start_testpmd(VM_CORES_MASK) > self.vm0_testpmd.execute_cmd('show port info all') > pmd0_vf0_mac =3D self.vm0_testpmd.get_port_mac(port_id_0) > self.vm0_testpmd.execute_cmd('set fwd mac') > @@ -250,7 +256,10 @@ class TestVfPacketRxtx(TestCase): > time.sleep(2) >=20 > self.vm1_testpmd =3D PmdOutput(self.vm_dut_1) > - self.vm1_testpmd.start_testpmd(VM_CORES_MASK) > + if self.kdriver =3D=3D "i40e": > + self.vm1_testpmd.start_testpmd(VM_CORES_MASK, '--crc-strip') > + else: > + self.vm1_testpmd.start_testpmd(VM_CORES_MASK) > self.vm1_testpmd.execute_cmd('show port info all') >=20 > tx_port =3D self.tester.get_local_port(self.dut_ports[0]) > diff --git a/tests/TestSuite_vf_port_start_stop.py > b/tests/TestSuite_vf_port_start_stop.py > index 0cc7ffd..b98d786 100644 > --- a/tests/TestSuite_vf_port_start_stop.py > +++ b/tests/TestSuite_vf_port_start_stop.py > @@ -214,7 +214,10 @@ class TestVfPortStartStop(TestCase): > self.vm0_dut_ports =3D self.vm_dut_0.get_ports('any') >=20 > self.vm0_testpmd =3D PmdOutput(self.vm_dut_0) > - self.vm0_testpmd.start_testpmd(VM_CORES_MASK) > + if self.kdriver =3D=3D "i40e": > + self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '--crc-strip') > + else: > + self.vm0_testpmd.start_testpmd(VM_CORES_MASK) > self.vm0_testpmd.execute_cmd('set fwd mac') >=20 > time.sleep(2) > diff --git a/tests/TestSuite_vf_rss.py b/tests/TestSuite_vf_rss.py > index 0e83832..cb2ffc9 100644 > --- a/tests/TestSuite_vf_rss.py > +++ b/tests/TestSuite_vf_rss.py > @@ -302,10 +302,14 @@ class TestVfRss(TestCase): > self.vm_dut_0.kill_all() >=20 > # test with different rss queues > + if self.kdriver =3D=3D "i40e": > + eal_param =3D '--crc-strip' > + else: > + eal_param =3D '' > for queue in testQueues: >=20 > self.vm0_testpmd.start_testpmd( > - "all", "--rxq=3D%d --txq=3D%d" % (queue, queue), > socket=3Dself.ports_socket) > + "all", "--rxq=3D%d --txq=3D%d %s" % (queue, queue, eal_p= aram), > socket=3Dself.ports_socket) >=20 > for iptype in iptypes: > self.vm_dut_0.send_expect("set verbose 8", "testpmd> ") > @@ -346,11 +350,15 @@ class TestVfRss(TestCase): >=20 > self.vm_dut_0.kill_all() >=20 > + if self.kdriver =3D=3D "i40e": > + eal_param =3D '--crc-strip' > + else: > + eal_param =3D '' > # test with different rss queues > for queue in testQueues: >=20 > self.vm0_testpmd.start_testpmd( > - "all", "--rxq=3D%d --txq=3D%d" % (queue, queue), > socket=3Dself.ports_socket) > + "all", "--rxq=3D%d --txq=3D%d %s" % (queue, queue, eal_p= aram), > socket=3Dself.ports_socket) >=20 > for iptype,rsstype in iptypes.items(): > self.vm_dut_0.send_expect("set verbose 8", "testpmd> ") > diff --git a/tests/TestSuite_vf_to_vf_nic_bridge.py > b/tests/TestSuite_vf_to_vf_nic_bridge.py > index 2da9645..4137404 100644 > --- a/tests/TestSuite_vf_to_vf_nic_bridge.py > +++ b/tests/TestSuite_vf_to_vf_nic_bridge.py > @@ -155,7 +155,10 @@ class TestVF2VFBridge(TestCase): > def test_2vf_d2d_pktgen_stream(self): > self.vm0_ports =3D self.vm0_dut.get_ports('any') > self.vm0_pmd =3D PmdOutput(self.vm0_dut) > - self.vm0_pmd.start_testpmd('all') > + if self.kdriver =3D=3D "i40e": > + self.vm0_pmd.start_testpmd('all', '--crc-strip') > + else: > + self.vm0_pmd.start_testpmd('all') > self.vm0_pmd.execute_cmd('set fwd rxonly') > self.vm0_pmd.execute_cmd('start') >=20 > @@ -214,7 +217,10 @@ class TestVF2VFBridge(TestCase): > def test_2vf_k2d_scapy_stream(self): > self.vm0_ports =3D self.vm0_dut.get_ports('any') > self.vm0_pmd =3D PmdOutput(self.vm0_dut) > - self.vm0_pmd.start_testpmd('all') > + if self.kdriver =3D=3D "i40e": > + self.vm0_pmd.start_testpmd('all', '--crc-strip') > + else: > + self.vm0_pmd.start_testpmd('all') > self.vm0_pmd.execute_cmd('set fwd rxonly') > self.vm0_pmd.execute_cmd('start') > self.vm0_pmd.execute_cmd('clear port stats all') > -- > 1.9.3