From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 7E5194A59 for ; Wed, 27 Jul 2016 11:30:12 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP; 27 Jul 2016 02:30:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,429,1464678000"; d="scan'208";a="740375507" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 27 Jul 2016 02:30:07 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 27 Jul 2016 02:30:07 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.181]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.116]) with mapi id 14.03.0248.002; Wed, 27 Jul 2016 17:30:05 +0800 From: "Liu, Yong" To: "Mo, YufengX" , "dts@dpdk.org" CC: "Mo, YufengX" Thread-Topic: [dts] [PATCH V2]Ethtool: update automation testing script Thread-Index: AQHR59IcZ9bQjVLYakK7R/pZXMWKu6AsAzgw Date: Wed, 27 Jul 2016 09:30:05 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E22262E63@SHSMSX103.ccr.corp.intel.com> References: <1469601712-4962-1-git-send-email-yufengx.mo@intel.com> <1469601712-4962-2-git-send-email-yufengx.mo@intel.com> In-Reply-To: <1469601712-4962-2-git-send-email-yufengx.mo@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTZiZjEyOTItMDAxYy00NDk1LWE4YWMtYjIwOTZhNGJiNzQ0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InIwQ1FkZXNKeDAwakNpRUFvSnZUYjlCUE81NElYTnFIcEZjXC9UZU5zVTF3PSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V2]Ethtool: update automation testing script X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jul 2016 09:30:13 -0000 Thanks, applied. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Yufen Mo > Sent: Wednesday, July 27, 2016 2:42 PM > To: dts@dpdk.org > Cc: Mo, YufengX > Subject: [dts] [PATCH V2]Ethtool: update automation testing script >=20 > From: yufengmx >=20 > *. close eeprom test case on FVL for FVL series firmware not supported > *. reset ring parameter after ring parameter is used > *. set testing content the same user space ethtool dumped >=20 > Signed-off-by: yufengmx > --- > tests/TestSuite_userspace_ethtool.py | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) >=20 > diff --git a/tests/TestSuite_userspace_ethtool.py > b/tests/TestSuite_userspace_ethtool.py > index c718a58..26044a3 100644 > --- a/tests/TestSuite_userspace_ethtool.py > +++ b/tests/TestSuite_userspace_ethtool.py > @@ -128,8 +128,8 @@ class TestUserspaceEthtool(TestCase, > IxiaPacketGenerator): > return 1518 >=20 > def resize_linux_eeprom_file(self, dpdk_eeprom_file, > linux_eeprom_file): > - basePath =3D self.dut.base_dir > - with open( basePath + dpdk_eeprom_file, 'rb') as fpDpdk: > + basePath =3D os.sep + "root" + self.dut.base_dir[1:] + os.sep > + with open( basePath + os.sep + dpdk_eeprom_file, 'rb') as fpDpdk= : > dpdk_bytes =3D fpDpdk.read() > dpdk_length =3D len(dpdk_bytes) >=20 > @@ -220,7 +220,10 @@ class TestUserspaceEthtool(TestCase, > IxiaPacketGenerator): >=20 > portsinfo =3D [] > ori_drivers =3D [] > - > + > + if self.nic.startswith("fortville"): > + return > + > for portid in range(len(self.ports)): > self.dut.send_expect("regs %d regs_%d.bin" % (portid, portid= ), > "EthApp>") > portinfo =3D {'portid': portid, 'reg_file': 'regs_%d.bin' % > portid} > @@ -300,8 +303,8 @@ class TestUserspaceEthtool(TestCase, > IxiaPacketGenerator): > """ > Test ethtool app ring parameter getting and setting > """ > - self.dut.send_expect(self.cmd, "EthApp>", 60) > for index in range(len(self.ports)): > + self.dut.send_expect(self.cmd, "EthApp>", 60) > port =3D self.ports[index] > ori_rx_pkts, ori_tx_pkts =3D self.strip_portstats(port) > _, rx_max, _, tx_max =3D self.strip_ringparam(index) > @@ -315,8 +318,7 @@ class TestUserspaceEthtool(TestCase, > IxiaPacketGenerator): > pkt.send_pkt(tx_port=3Dintf) > rx_pkts, tx_pkts =3D self.strip_portstats(index) > self.verify(rx_pkts =3D=3D ori_rx_pkts + 1, "Failed to forwa= rd > after ring parameter changed") > - > - self.dut.send_expect("quit", "# ") > + self.dut.send_expect("quit", "# ") >=20 > def test_ethtool_vlan(self): > """ > -- > 1.9.3