test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Tu, LijuanX A" <lijuanx.a.tu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH]qemu_kvm: fix timeout on running qemu command
Date: Wed, 10 Aug 2016 07:32:47 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E2226C0AE@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <38D041F150D4184C8114E499040E6234072D7C46@shsmsx102.ccr.corp.intel.com>

Got, this patch is based on next branch and failed to apply on master branch.
It will merge to master branch with next branch later.

> -----Original Message-----
> From: Tu, LijuanX A
> Sent: Wednesday, August 10, 2016 1:54 PM
> To: Liu, Yong; dts@dpdk.org
> Subject: RE: [dts] [PATCH]qemu_kvm: fix timeout on running qemu command
> 
> Master branch need this patch too
> 
>  > -----Original Message-----
>  > From: Liu, Yong
>  > Sent: Wednesday, August 10, 2016 10:11 AM
>  > To: Tu, LijuanX A; dts@dpdk.org
>  > Subject: Re: [dts] [PATCH]qemu_kvm: fix timeout on running qemu command
>  >
>  > Applied into next branch. Lijuan, please add branch section, thus i can
> get
>  > to known it.
>  >
>  > On 08/09/2016 03:20 PM, Lijuan Tu wrote:
>  > > 2s is not enough for running qemu command
>  > >
>  > > Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
>  > > ---
>  > >   framework/qemu_kvm.py | 4 ++--
>  > >   1 file changed, 2 insertions(+), 2 deletions(-)
>  > >
>  > > diff --git a/framework/qemu_kvm.py b/framework/qemu_kvm.py index
>  > > 96923e9..545bb5d 100644
>  > > --- a/framework/qemu_kvm.py
>  > > +++ b/framework/qemu_kvm.py
>  > > @@ -1116,7 +1116,7 @@ class QEMUKvm(VirtBase):
>  > >                   (self.host_dut.NAME, self.vm_name))
>  > >               return None
>  > >
>  > > -        self.host_session.send_expect('nc -U %s' %
> self.monitor_sock_path,
>  > '(qemu)', 2)
>  > > +        self.host_session.send_expect('nc -U %s' %
>  > > + self.monitor_sock_path, '(qemu)')
>  > >
>  > >           cmd = command
>  > >           for arg in args:
>  > > @@ -1126,7 +1126,7 @@ class QEMUKvm(VirtBase):
>  > >           if 'quit' in cmd:
>  > >               out = self.host_session.send_expect('%s' % cmd, '# ')
>  > >           else:
>  > > -            out = self.host_session.send_expect('%s' % cmd, '(qemu)')
>  > > +            out = self.host_session.send_expect('%s' % cmd, '(qemu)',
>  > > + 30)
>  > >           self.host_session.send_expect('^C', "# ")
>  > >           return out
>  > >

      reply	other threads:[~2016-08-10  7:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-09  7:20 Lijuan Tu
2016-08-10  2:11 ` Liu, Yong
2016-08-10  5:53   ` Tu, LijuanX A
2016-08-10  7:32     ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E2226C0AE@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=lijuanx.a.tu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).