test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH]qemu_kvm: fix timeout on running qemu command
@ 2016-08-09  7:20 Lijuan Tu
  2016-08-10  2:11 ` Liu, Yong
  0 siblings, 1 reply; 4+ messages in thread
From: Lijuan Tu @ 2016-08-09  7:20 UTC (permalink / raw)
  To: dts; +Cc: Lijuan Tu

2s is not enough for running qemu command

Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
---
 framework/qemu_kvm.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/framework/qemu_kvm.py b/framework/qemu_kvm.py
index 96923e9..545bb5d 100644
--- a/framework/qemu_kvm.py
+++ b/framework/qemu_kvm.py
@@ -1116,7 +1116,7 @@ class QEMUKvm(VirtBase):
                 (self.host_dut.NAME, self.vm_name))
             return None
 
-        self.host_session.send_expect('nc -U %s' % self.monitor_sock_path, '(qemu)', 2)
+        self.host_session.send_expect('nc -U %s' % self.monitor_sock_path, '(qemu)')
 
         cmd = command
         for arg in args:
@@ -1126,7 +1126,7 @@ class QEMUKvm(VirtBase):
         if 'quit' in cmd:
             out = self.host_session.send_expect('%s' % cmd, '# ')
         else:
-            out = self.host_session.send_expect('%s' % cmd, '(qemu)')
+            out = self.host_session.send_expect('%s' % cmd, '(qemu)', 30)
         self.host_session.send_expect('^C', "# ")
         return out
 
-- 
1.9.3

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH]qemu_kvm: fix timeout on running qemu command
  2016-08-09  7:20 [dts] [PATCH]qemu_kvm: fix timeout on running qemu command Lijuan Tu
@ 2016-08-10  2:11 ` Liu, Yong
  2016-08-10  5:53   ` Tu, LijuanX A
  0 siblings, 1 reply; 4+ messages in thread
From: Liu, Yong @ 2016-08-10  2:11 UTC (permalink / raw)
  To: Lijuan Tu, dts

Applied into next branch. Lijuan, please add branch section, thus i can 
get to known it.

On 08/09/2016 03:20 PM, Lijuan Tu wrote:
> 2s is not enough for running qemu command
>
> Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
> ---
>   framework/qemu_kvm.py | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/framework/qemu_kvm.py b/framework/qemu_kvm.py
> index 96923e9..545bb5d 100644
> --- a/framework/qemu_kvm.py
> +++ b/framework/qemu_kvm.py
> @@ -1116,7 +1116,7 @@ class QEMUKvm(VirtBase):
>                   (self.host_dut.NAME, self.vm_name))
>               return None
>   
> -        self.host_session.send_expect('nc -U %s' % self.monitor_sock_path, '(qemu)', 2)
> +        self.host_session.send_expect('nc -U %s' % self.monitor_sock_path, '(qemu)')
>   
>           cmd = command
>           for arg in args:
> @@ -1126,7 +1126,7 @@ class QEMUKvm(VirtBase):
>           if 'quit' in cmd:
>               out = self.host_session.send_expect('%s' % cmd, '# ')
>           else:
> -            out = self.host_session.send_expect('%s' % cmd, '(qemu)')
> +            out = self.host_session.send_expect('%s' % cmd, '(qemu)', 30)
>           self.host_session.send_expect('^C', "# ")
>           return out
>   

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH]qemu_kvm: fix timeout on running qemu command
  2016-08-10  2:11 ` Liu, Yong
@ 2016-08-10  5:53   ` Tu, LijuanX A
  2016-08-10  7:32     ` Liu, Yong
  0 siblings, 1 reply; 4+ messages in thread
From: Tu, LijuanX A @ 2016-08-10  5:53 UTC (permalink / raw)
  To: Liu, Yong, dts

Master branch need this patch too

 > -----Original Message-----
 > From: Liu, Yong
 > Sent: Wednesday, August 10, 2016 10:11 AM
 > To: Tu, LijuanX A; dts@dpdk.org
 > Subject: Re: [dts] [PATCH]qemu_kvm: fix timeout on running qemu command
 > 
 > Applied into next branch. Lijuan, please add branch section, thus i can get
 > to known it.
 > 
 > On 08/09/2016 03:20 PM, Lijuan Tu wrote:
 > > 2s is not enough for running qemu command
 > >
 > > Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
 > > ---
 > >   framework/qemu_kvm.py | 4 ++--
 > >   1 file changed, 2 insertions(+), 2 deletions(-)
 > >
 > > diff --git a/framework/qemu_kvm.py b/framework/qemu_kvm.py index
 > > 96923e9..545bb5d 100644
 > > --- a/framework/qemu_kvm.py
 > > +++ b/framework/qemu_kvm.py
 > > @@ -1116,7 +1116,7 @@ class QEMUKvm(VirtBase):
 > >                   (self.host_dut.NAME, self.vm_name))
 > >               return None
 > >
 > > -        self.host_session.send_expect('nc -U %s' % self.monitor_sock_path,
 > '(qemu)', 2)
 > > +        self.host_session.send_expect('nc -U %s' %
 > > + self.monitor_sock_path, '(qemu)')
 > >
 > >           cmd = command
 > >           for arg in args:
 > > @@ -1126,7 +1126,7 @@ class QEMUKvm(VirtBase):
 > >           if 'quit' in cmd:
 > >               out = self.host_session.send_expect('%s' % cmd, '# ')
 > >           else:
 > > -            out = self.host_session.send_expect('%s' % cmd, '(qemu)')
 > > +            out = self.host_session.send_expect('%s' % cmd, '(qemu)',
 > > + 30)
 > >           self.host_session.send_expect('^C', "# ")
 > >           return out
 > >

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH]qemu_kvm: fix timeout on running qemu command
  2016-08-10  5:53   ` Tu, LijuanX A
@ 2016-08-10  7:32     ` Liu, Yong
  0 siblings, 0 replies; 4+ messages in thread
From: Liu, Yong @ 2016-08-10  7:32 UTC (permalink / raw)
  To: Tu, LijuanX A, dts

Got, this patch is based on next branch and failed to apply on master branch.
It will merge to master branch with next branch later.

> -----Original Message-----
> From: Tu, LijuanX A
> Sent: Wednesday, August 10, 2016 1:54 PM
> To: Liu, Yong; dts@dpdk.org
> Subject: RE: [dts] [PATCH]qemu_kvm: fix timeout on running qemu command
> 
> Master branch need this patch too
> 
>  > -----Original Message-----
>  > From: Liu, Yong
>  > Sent: Wednesday, August 10, 2016 10:11 AM
>  > To: Tu, LijuanX A; dts@dpdk.org
>  > Subject: Re: [dts] [PATCH]qemu_kvm: fix timeout on running qemu command
>  >
>  > Applied into next branch. Lijuan, please add branch section, thus i can
> get
>  > to known it.
>  >
>  > On 08/09/2016 03:20 PM, Lijuan Tu wrote:
>  > > 2s is not enough for running qemu command
>  > >
>  > > Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
>  > > ---
>  > >   framework/qemu_kvm.py | 4 ++--
>  > >   1 file changed, 2 insertions(+), 2 deletions(-)
>  > >
>  > > diff --git a/framework/qemu_kvm.py b/framework/qemu_kvm.py index
>  > > 96923e9..545bb5d 100644
>  > > --- a/framework/qemu_kvm.py
>  > > +++ b/framework/qemu_kvm.py
>  > > @@ -1116,7 +1116,7 @@ class QEMUKvm(VirtBase):
>  > >                   (self.host_dut.NAME, self.vm_name))
>  > >               return None
>  > >
>  > > -        self.host_session.send_expect('nc -U %s' %
> self.monitor_sock_path,
>  > '(qemu)', 2)
>  > > +        self.host_session.send_expect('nc -U %s' %
>  > > + self.monitor_sock_path, '(qemu)')
>  > >
>  > >           cmd = command
>  > >           for arg in args:
>  > > @@ -1126,7 +1126,7 @@ class QEMUKvm(VirtBase):
>  > >           if 'quit' in cmd:
>  > >               out = self.host_session.send_expect('%s' % cmd, '# ')
>  > >           else:
>  > > -            out = self.host_session.send_expect('%s' % cmd, '(qemu)')
>  > > +            out = self.host_session.send_expect('%s' % cmd, '(qemu)',
>  > > + 30)
>  > >           self.host_session.send_expect('^C', "# ")
>  > >           return out
>  > >

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-08-10  7:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-09  7:20 [dts] [PATCH]qemu_kvm: fix timeout on running qemu command Lijuan Tu
2016-08-10  2:11 ` Liu, Yong
2016-08-10  5:53   ` Tu, LijuanX A
2016-08-10  7:32     ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).