test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: xueqin.lin <xlin15@ecsmtp.sh.intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Lin, Xueqin" <xueqin.lin@intel.com>
Subject: Re: [dts] [PATCH] Remove RSS on sctp packets test due to fm10k HW unsupport
Date: Fri, 12 Aug 2016 05:32:56 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E2226D321@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1470909839-30634-1-git-send-email-xlin15@shecgisg005.sh.intel.com>

Hi Xueqin,
There's one more clear and easy way to remove sctp RSS validation.

if self.kdriver in ["fm10k"]:
	iptypes.pop('ipv6-sctp')

> -----Original Message-----
> From: xueqin.lin [mailto:xlin15@ecsmtp.sh.intel.com]
> Sent: Thursday, August 11, 2016 6:04 PM
> To: Liu, Yong; dts@dpdk.org
> Cc: Lin, Xueqin
> Subject: [dts][PATCH] Remove RSS on sctp packets test due to fm10k HW
> unsupport
> 
> From: Xueqin Lin <xueqin.lin@intel.com>
> 
> Refer to fm10k datasheet 11.27.2.30,RSS on sctp packets is not supported
> by HW.
> 
> ---
>  tests/TestSuite_pmdrss_hash.py | 38 ++++++++++++++++++++++++-------------
> -
>  1 file changed, 24 insertions(+), 14 deletions(-)
> 
> diff --git a/tests/TestSuite_pmdrss_hash.py
> b/tests/TestSuite_pmdrss_hash.py
> index 0cb703b..14e6596 100644
> --- a/tests/TestSuite_pmdrss_hash.py
> +++ b/tests/TestSuite_pmdrss_hash.py
> @@ -545,20 +545,30 @@ class TestPmdrssHash(TestCase):
>          localPort = self.tester.get_local_port(dutPorts[0])
>          itf = self.tester.get_interface(localPort)
>          global reta_num
> -        iptypes = {'ipv4-sctp': 'sctp',
> -                   'ipv4-other': 'ip',
> -                   'ipv4-frag': 'ip',
> -                   'ipv4-udp': 'udp',
> -                   'ipv4-tcp': 'tcp',
> -                   # this hass not support in dpdk 2.0
> -                   # 'l2_payload':'ether',
> -                   'ipv6-other': 'ip',
> -                   'ipv6-sctp': 'ip',
> -                   'ipv6-udp': 'udp',
> -                   'ipv6-tcp': 'tcp',
> -                   'ipv6-frag': 'ip'
> -                   }
> -
> +        if self.kdriver not in ["fm10k"]:
> +            iptypes = { 'ipv4-sctp': 'sctp',
> +                        'ipv4-other': 'ip',
> +                        'ipv4-frag': 'ip',
> +                        'ipv4-udp': 'udp',
> +                        'ipv4-tcp': 'tcp',
> +                        # this hass not support in dpdk 2.0
> +                        # 'l2_payload':'ether',
> +                        'ipv6-other': 'ip',
> +                        'ipv6-sctp': 'ip',
> +                        'ipv6-udp': 'udp',
> +                        'ipv6-tcp': 'tcp',
> +                        'ipv6-frag': 'ip'
> +                        }
> +        else:
> +            iptypes = { 'ipv4-other': 'ip',
> +                        'ipv4-frag': 'ip',
> +                        'ipv4-udp': 'udp',
> +                        'ipv4-tcp': 'tcp',
> +                        'ipv6-other': 'ip',
> +                        'ipv6-udp': 'udp',
> +                        'ipv6-tcp': 'tcp',
> +                        'ipv6-frag': 'ip'
> +                        }
>          self.dut.kill_all()
> 
>          # test with different rss queues
> --
> 2.5.5

       reply	other threads:[~2016-08-12  5:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1470909839-30634-1-git-send-email-xlin15@shecgisg005.sh.intel.com>
2016-08-12  5:32 ` Liu, Yong [this message]
2016-08-12  5:51   ` Lin, Xueqin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E2226D321@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=xlin15@ecsmtp.sh.intel.com \
    --cc=xueqin.lin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).