test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Xu, HuilongX" <huilongx.xu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [dts 1/2][PATCH V1] set dpdk log level to debug level
Date: Fri, 19 Aug 2016 01:13:07 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E2227117C@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <DF2A19295B96364286FEB7F3DDA27A4637B922AA@SHSMSX101.ccr.corp.intel.com>

Huilong, I have known this. What I mean is that not change default configuration for all suites. It may cause unexpected results.
You can change configuration for certain test suite just in the suite. There're lots samples like ieee1588.

Thanks
> -----Original Message-----
> From: Xu, HuilongX
> Sent: Thursday, August 18, 2016 4:24 PM
> To: Liu, Yong; dts@dpdk.org
> Subject: RE: [dts] [dts 1/2][PATCH V1] set dpdk log level to debug level
> 
> Hi yong,
> Dpdk package default highest log level is INFO(The value is 7).
> So we should reset compile switch for update log level to DEBUG(The value
> is 8).
> When we run dpdk app the default log is INFO, unless we set EAL parameter
> --log-level.
> Thanks a lot
> 
> > -----Original Message-----
> > From: Liu, Yong
> > Sent: Thursday, August 18, 2016 3:32 PM
> > To: Xu, HuilongX; dts@dpdk.org
> > Cc: Xu, HuilongX
> > Subject: RE: [dts] [dts 1/2][PATCH V1] set dpdk log level to debug level
> >
> > Huilong,
> > Please move the configuration file change into core_mask suite.
> > We'd better not change any code in dpdk, DTS should validate default
> > dpdk code.
> > If some suites require special setting, it should be included in the
> > test suite.
> >
> > > -----Original Message-----
> > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong
> > > Sent: Thursday, August 18, 2016 10:32 AM
> > > To: dts@dpdk.org
> > > Cc: Xu, HuilongX
> > > Subject: [dts] [dts 1/2][PATCH V1] set dpdk log level to debug level
> > >
> > > Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> > > ---
> > >  framework/project_dpdk.py | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py
> > > index 4e44793..6ea8fb4 100644
> > > --- a/framework/project_dpdk.py
> > > +++ b/framework/project_dpdk.py
> > > @@ -133,6 +133,8 @@ class DPDKdut(Dut):
> > >          Set default RX/TX PMD function, now only take effect on ixgbe.
> > >          """
> > >          [arch, machine, env, toolchain] = self.target.split('-')
> > > +        self.send_expect("sed -i -e 's/CONFIG_RTE_LOG_LEVEL=.*$/"
> > > +                          + "CONFIG_RTE_LOG_LEVEL=RTE_LOG_DEBUG/'
> > > config/common_base", "# ", 30)
> > >          if dts.rx_mode is None:
> > >              mode = 'default'
> > >          else:
> > > --
> > > 1.9.3
> > >

  reply	other threads:[~2016-08-19  1:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-18  2:31 xu,huilong
2016-08-18  2:31 ` [dts] [dts 2/2][PATCH V1] update coremask test case xu,huilong
2016-08-18  7:31 ` [dts] [dts 1/2][PATCH V1] set dpdk log level to debug level Liu, Yong
2016-08-18  8:24   ` Xu, HuilongX
2016-08-19  1:13     ` Liu, Yong [this message]
2016-08-19  5:24       ` Xu, HuilongX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E2227117C@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=huilongx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).