From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id ED205532C for ; Wed, 24 Aug 2016 10:48:59 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP; 24 Aug 2016 01:48:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,570,1464678000"; d="scan'208";a="752839958" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by FMSMGA003.fm.intel.com with ESMTP; 24 Aug 2016 01:48:58 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 24 Aug 2016 01:48:57 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 24 Aug 2016 01:48:57 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.181]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.116]) with mapi id 14.03.0248.002; Wed, 24 Aug 2016 16:48:55 +0800 From: "Liu, Yong" To: "Xu, HuilongX" , "Tu, LijuanX A" , "dts@dpdk.org" CC: "Tu, LijuanX A" Thread-Topic: [dts] [PATCH V1] update fortville vlan filte case Thread-Index: AQHR/QbyMJLyMy+SL0CS7AW9v5fHrKBWKZewgAACXbCAAaKDoA== Date: Wed, 24 Aug 2016 08:48:55 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E22274505@SHSMSX103.ccr.corp.intel.com> References: <1471933137-23368-1-git-send-email-lijuanx.a.tu@intel.com> <86228AFD5BCD8E4EBFD2B90117B5E81E222734A7@SHSMSX103.ccr.corp.intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmMwNTZkOGItMmY2MC00NDVlLTgyZjktZDc5ZWNjZGIwODRhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlJNbVNhVXFwd2FUeGdlQjFzc1FLRDZWbnpyTERzKzh3TzdkOVhjQ2E0Ymc9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] update fortville vlan filte case X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Aug 2016 08:49:00 -0000 Huilong, that's fine. Please send V2 patch with these comments. > -----Original Message----- > From: Xu, HuilongX > Sent: Tuesday, August 23, 2016 3:53 PM > To: Liu, Yong; Tu, LijuanX A; dts@dpdk.org > Cc: Tu, LijuanX A > Subject: RE: [dts] [PATCH V1] update fortville vlan filte case >=20 > Hi yong, > I am sorry, this patch from me. > FVL Nic the vlan filter and promisc use same switch. So when we test vlan > filter must disable promisc. >=20 > > -----Original Message----- > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Liu, Yong > > Sent: Tuesday, August 23, 2016 3:44 PM > > To: Tu, LijuanX A; dts@dpdk.org > > Cc: Tu, LijuanX A > > Subject: Re: [dts] [PATCH V1] update fortville vlan filte case > > > > Lijuan, please add more information in the git log. > > We couldn't get the point that why need to disable promisc mode > > mandatory. > > > > > > > -----Original Message----- > > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Lijuan Tu > > > Sent: Tuesday, August 23, 2016 2:19 PM > > > To: dts@dpdk.org > > > Cc: Tu, LijuanX A > > > Subject: [dts] [PATCH V1] update fortville vlan filte case > > > > > > FVL nic must disabel promisc for vlan filter. > > > > > > Signed-off-by: Lijuan Tu > > > --- > > > tests/TestSuite_vlan.py | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/tests/TestSuite_vlan.py b/tests/TestSuite_vlan.py > > > index 70a9813..43b025d 100644 > > > --- a/tests/TestSuite_vlan.py > > > +++ b/tests/TestSuite_vlan.py > > > @@ -77,6 +77,7 @@ class TestVlan(TestCase): > > > > > > if self.nic in ["fortville_eagle", "fortville_spirit", > > > "fortville_spirit_single", "fortpark_TLV"]: > > > self.dut.send_expect("vlan set filter on %s" % > > dutRxPortId, > > > "testpmd> ") > > > + self.dut.send_expect("set promisc all off", "testpmd> "= ) > > > > > > self.dut.send_expect("vlan set strip off %s" % dutRxPortId, > > > "testpmd> ") > > > self.verify('Set mac packet forwarding mode' in out, "set fw= d > > > rxonly error") > > > -- > > > 1.9.3