* [dts] [PATCH V1] update fortville vlan filte case
@ 2016-08-23 6:18 Lijuan Tu
2016-08-23 7:44 ` Liu, Yong
0 siblings, 1 reply; 4+ messages in thread
From: Lijuan Tu @ 2016-08-23 6:18 UTC (permalink / raw)
To: dts; +Cc: Lijuan Tu
FVL nic must disabel promisc for vlan filter.
Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
---
tests/TestSuite_vlan.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/TestSuite_vlan.py b/tests/TestSuite_vlan.py
index 70a9813..43b025d 100644
--- a/tests/TestSuite_vlan.py
+++ b/tests/TestSuite_vlan.py
@@ -77,6 +77,7 @@ class TestVlan(TestCase):
if self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortpark_TLV"]:
self.dut.send_expect("vlan set filter on %s" % dutRxPortId, "testpmd> ")
+ self.dut.send_expect("set promisc all off", "testpmd> ")
self.dut.send_expect("vlan set strip off %s" % dutRxPortId, "testpmd> ")
self.verify('Set mac packet forwarding mode' in out, "set fwd rxonly error")
--
1.9.3
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dts] [PATCH V1] update fortville vlan filte case 2016-08-23 6:18 [dts] [PATCH V1] update fortville vlan filte case Lijuan Tu @ 2016-08-23 7:44 ` Liu, Yong 2016-08-23 7:53 ` Xu, HuilongX 0 siblings, 1 reply; 4+ messages in thread From: Liu, Yong @ 2016-08-23 7:44 UTC (permalink / raw) To: Tu, LijuanX A, dts; +Cc: Tu, LijuanX A Lijuan, please add more information in the git log. We couldn't get the point that why need to disable promisc mode mandatory. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Lijuan Tu > Sent: Tuesday, August 23, 2016 2:19 PM > To: dts@dpdk.org > Cc: Tu, LijuanX A > Subject: [dts] [PATCH V1] update fortville vlan filte case > > FVL nic must disabel promisc for vlan filter. > > Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com> > --- > tests/TestSuite_vlan.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/TestSuite_vlan.py b/tests/TestSuite_vlan.py > index 70a9813..43b025d 100644 > --- a/tests/TestSuite_vlan.py > +++ b/tests/TestSuite_vlan.py > @@ -77,6 +77,7 @@ class TestVlan(TestCase): > > if self.nic in ["fortville_eagle", "fortville_spirit", > "fortville_spirit_single", "fortpark_TLV"]: > self.dut.send_expect("vlan set filter on %s" % dutRxPortId, > "testpmd> ") > + self.dut.send_expect("set promisc all off", "testpmd> ") > > self.dut.send_expect("vlan set strip off %s" % dutRxPortId, > "testpmd> ") > self.verify('Set mac packet forwarding mode' in out, "set fwd > rxonly error") > -- > 1.9.3 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dts] [PATCH V1] update fortville vlan filte case 2016-08-23 7:44 ` Liu, Yong @ 2016-08-23 7:53 ` Xu, HuilongX 2016-08-24 8:48 ` Liu, Yong 0 siblings, 1 reply; 4+ messages in thread From: Xu, HuilongX @ 2016-08-23 7:53 UTC (permalink / raw) To: Liu, Yong, Tu, LijuanX A, dts; +Cc: Tu, LijuanX A Hi yong, I am sorry, this patch from me. FVL Nic the vlan filter and promisc use same switch. So when we test vlan filter must disable promisc. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Liu, Yong > Sent: Tuesday, August 23, 2016 3:44 PM > To: Tu, LijuanX A; dts@dpdk.org > Cc: Tu, LijuanX A > Subject: Re: [dts] [PATCH V1] update fortville vlan filte case > > Lijuan, please add more information in the git log. > We couldn't get the point that why need to disable promisc mode > mandatory. > > > > -----Original Message----- > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Lijuan Tu > > Sent: Tuesday, August 23, 2016 2:19 PM > > To: dts@dpdk.org > > Cc: Tu, LijuanX A > > Subject: [dts] [PATCH V1] update fortville vlan filte case > > > > FVL nic must disabel promisc for vlan filter. > > > > Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com> > > --- > > tests/TestSuite_vlan.py | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tests/TestSuite_vlan.py b/tests/TestSuite_vlan.py > > index 70a9813..43b025d 100644 > > --- a/tests/TestSuite_vlan.py > > +++ b/tests/TestSuite_vlan.py > > @@ -77,6 +77,7 @@ class TestVlan(TestCase): > > > > if self.nic in ["fortville_eagle", "fortville_spirit", > > "fortville_spirit_single", "fortpark_TLV"]: > > self.dut.send_expect("vlan set filter on %s" % > dutRxPortId, > > "testpmd> ") > > + self.dut.send_expect("set promisc all off", "testpmd> ") > > > > self.dut.send_expect("vlan set strip off %s" % dutRxPortId, > > "testpmd> ") > > self.verify('Set mac packet forwarding mode' in out, "set fwd > > rxonly error") > > -- > > 1.9.3 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dts] [PATCH V1] update fortville vlan filte case 2016-08-23 7:53 ` Xu, HuilongX @ 2016-08-24 8:48 ` Liu, Yong 0 siblings, 0 replies; 4+ messages in thread From: Liu, Yong @ 2016-08-24 8:48 UTC (permalink / raw) To: Xu, HuilongX, Tu, LijuanX A, dts; +Cc: Tu, LijuanX A Huilong, that's fine. Please send V2 patch with these comments. > -----Original Message----- > From: Xu, HuilongX > Sent: Tuesday, August 23, 2016 3:53 PM > To: Liu, Yong; Tu, LijuanX A; dts@dpdk.org > Cc: Tu, LijuanX A > Subject: RE: [dts] [PATCH V1] update fortville vlan filte case > > Hi yong, > I am sorry, this patch from me. > FVL Nic the vlan filter and promisc use same switch. So when we test vlan > filter must disable promisc. > > > -----Original Message----- > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Liu, Yong > > Sent: Tuesday, August 23, 2016 3:44 PM > > To: Tu, LijuanX A; dts@dpdk.org > > Cc: Tu, LijuanX A > > Subject: Re: [dts] [PATCH V1] update fortville vlan filte case > > > > Lijuan, please add more information in the git log. > > We couldn't get the point that why need to disable promisc mode > > mandatory. > > > > > > > -----Original Message----- > > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Lijuan Tu > > > Sent: Tuesday, August 23, 2016 2:19 PM > > > To: dts@dpdk.org > > > Cc: Tu, LijuanX A > > > Subject: [dts] [PATCH V1] update fortville vlan filte case > > > > > > FVL nic must disabel promisc for vlan filter. > > > > > > Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com> > > > --- > > > tests/TestSuite_vlan.py | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/tests/TestSuite_vlan.py b/tests/TestSuite_vlan.py > > > index 70a9813..43b025d 100644 > > > --- a/tests/TestSuite_vlan.py > > > +++ b/tests/TestSuite_vlan.py > > > @@ -77,6 +77,7 @@ class TestVlan(TestCase): > > > > > > if self.nic in ["fortville_eagle", "fortville_spirit", > > > "fortville_spirit_single", "fortpark_TLV"]: > > > self.dut.send_expect("vlan set filter on %s" % > > dutRxPortId, > > > "testpmd> ") > > > + self.dut.send_expect("set promisc all off", "testpmd> ") > > > > > > self.dut.send_expect("vlan set strip off %s" % dutRxPortId, > > > "testpmd> ") > > > self.verify('Set mac packet forwarding mode' in out, "set fwd > > > rxonly error") > > > -- > > > 1.9.3 ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-24 8:48 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-08-23 6:18 [dts] [PATCH V1] update fortville vlan filte case Lijuan Tu 2016-08-23 7:44 ` Liu, Yong 2016-08-23 7:53 ` Xu, HuilongX 2016-08-24 8:48 ` Liu, Yong
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).