From: "Liu, Yong" <yong.liu@intel.com>
To: "Xu, GangX" <gangx.xu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xu, GangX" <gangx.xu@intel.com>, "Wan, Qun" <qun.wan@intel.com>
Subject: Re: [dts] [PATCH V2 06/10] add ip_pipeline link_identification test plan
Date: Fri, 26 Aug 2016 02:19:03 +0000 [thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E22275EC9@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1472113463-4298-6-git-send-email-gangx.xu@intel.com>
Gang, some suggestions for create efficiency test plan, please check my comments below.
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang
> Sent: Thursday, August 25, 2016 4:24 PM
> To: dts@dpdk.org
> Cc: Xu, GangX
> Subject: [dts] [PATCH V2 06/10] add ip_pipeline link_identification test
> plan
>
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
> .../ip_pipeline_link_identification_test_plan.rst | 293
> +++++++++++++++++++++
> 1 file changed, 293 insertions(+)
> create mode 100644
> test_plans/ip_pipeline_link_identification_test_plan.rst
>
> diff --git a/test_plans/ip_pipeline_link_identification_test_plan.rst
> b/test_plans/ip_pipeline_link_identification_test_plan.rst
> new file mode 100644
> index 0000000..89a9bd7
> --- /dev/null
> +++ b/test_plans/ip_pipeline_link_identification_test_plan.rst
> @@ -0,0 +1,293 @@
> +Description
> +Link identification has 2 goals, first is to create a brand new option in
> CFG file's LINK
> +section, so a link can be confgiured specific physical port using the PCI
> address. So the
> +user can either use original "-p" option, or the new LINK section item to
> identify the
> +physical port he/she wants to use; Second is to maintain the original "-
> p" option as it is.
> +That is, the following logic shall be applied so that two ways will not
> mix.
Please segment this description, it's too long for reading.
> +
> +--------------------------------------------------------------------
> + |a. "-p" cmd option exists | b. "-p" cmd option not exist
> +--------------------------------------------------------------------
> +1 |EAL section "pci_whitelist" |EAL section "pci_whitelist" is
> + |option is allowed and optional |NOT allowed
> +--------------------------------------------------------------------
> +2 |LINK section "pci_bdf" option |LINK section "pci_bdf" option
> + |is NOT allowed |is MANDATORY
> +-------------------------------------------------------------------------
> --
> +1. Regression for all the old CFG files(regression team should cover it)
> +-------------------------------------------------------------------------
> --
Large table is not kind for reading. Please add line feeds to make sure table length in 79 characters.
> +
> +----------------------------------------------------------------
> +2. CFG file containing 1 "pci_whitelist" section with "-p" exist shall
> work
Case name should be more abstractive, like "Test: cfg whitelist co-existed with portmask param"
Add test logic description just after test case definition. It will look like
"Add pci whitelist in cfg file and start ip_pipeline with one port masked. Ip_pipline will startup normally with cfg file specified port"
> +([root@dpdk_testserver03 ip_pipeline]# ./build/ip_pipeline -p 1 -
> f ./config/pt1_2ports_link_iden.cfg
Remove your own platform information, only keep command line here.
> +Parse error in section "EAL", entry "pci_whitelist": too many elements
> +
> +Aborted (core dumped))
No need to record this kind of output log, one description like below is enough.
"Ip_pipeline will be aborted for ..."
> +----------------------------------------------------------------
> +Config file as follows
No need to attach everything in the test plan. If only option pci_whitelist is care in this suite,
list this option is enough.
> +[PIPELINE0]
> +type = MASTER
> +core = 0
> +
> +[PIPELINE1]
> +type = PASS-THROUGH
> +core = s1c1
> +pktq_in = RXQ0.0 RXQ1.0
> +pktq_out = TXQ1.0 TXQ0.0
> +
> +[EAL]
> +pci_whitelist = 0000:85:00.0
> +Run the command ./build/ip_pipeline -p 1 -
> f ./config/pt1_2ports_link_iden.cfg, check that the app runs successfully
> +
The description not match previous one. Please check it.
> +----------------------------------------------------------------
> +3. CFG file containing 2 "pci_whitelist" sections with "-p" exists
> +([root@dpdk_testserver03 ip_pipeline]# ./build/ip_pipeline -p 3 -
> f ./config/pt1_2ports_link_iden.cfg
> +Parse error in section "EAL", entry "pci_whitelist": too many elements
> +
> +Aborted (core dumped))
> +----------------------------------------------------------------
> +Config file as follows
> +
> +
> +Run the command ./build/ip_pipeline -p 3 -
> f ./config/pt1_2ports_link_iden.cfg, check that the app runs successfully
> +
> +----------------------------------------------------------------
> +4. CFG file containing 4 "pci_whitelist" sections with "-p" exists
> +----------------------------------------------------------------
> +Config file as follows
> +[PIPELINE0]
> +type = MASTER
> +core = 0
> +
> +[PIPELINE1]
> +type = PASS-THROUGH
> +core = s1c1
> +pktq_in = RXQ0.0 RXQ1.0 RXQ2.0 RXQ3.0
> +pktq_out = TXQ0.0 TXQ1.0 TXQ2.0 TXQ3.0
> +
> +[EAL]
> +pci_whitelist = 0000:83:00.0
> +pci_whitelist = 0000:83:00.1
> +pci_whitelist = 0000:85:00.0
> +pci_whitelist = 0000:85:00.1
> +Run the command ./build/ip_pipeline -p f -
> f ./config/pt1_2ports_link_iden.cfg, check that the app runs successfully
> +
> +----------------------------------------------------------------
> +5. CFG file containing "pci_bdf" in LINK section shall NOT work with "-p"
> exists
> +([root@dpdk_testserver03 ip_pipeline]# ./build/ip_pipeline -p 3 -
> f ./config/pt1_2ports_link_iden.cfg
> +Parse error in section "LINK0", entry "pci_bdf": entry not allowed
> (port_mask is provided)
> +
> +Aborted (core dumped))
> +----------------------------------------------------------------
> +Config file as follows
> +[PIPELINE0]
> +type = MASTER
> +core = 0
> +
> +[PIPELINE1]
> +type = PASS-THROUGH
> +core = s1c1
> +pktq_in = RXQ0.0 RXQ1.0
> +pktq_out = TXQ1.0 TXQ0.0
> +
> +[LINK0]
> +pci_bdf = 0000:85:00.0
> +
> +[LINK1]
> +pci_bdf = 0000:85:00.1
> +Run the command ./build/ip_pipeline -p 3 -
> f ./config/pt1_2ports_link_iden.cfg, check that the app runs successfully,
> if yes, test fail, otherwise, test pass
> +
> +----------------------------------------------------------------
> +6. CFG file containing "pci_bdf" in LINK section and EAL section shall
> NOT work with "-p" exists(EAL and LINK not matches)
> +([root@dpdk_testserver03 ip_pipeline]# ./build/ip_pipeline -p 3 -
> f ./config/pt1_2ports_link_iden.cfg
> +Parse error in section "LINK0", entry "pci_bdf": entry not allowed
> (port_mask is provided)
> +
> +Aborted (core dumped))
> +----------------------------------------------------------------
> +Config file as follows
> +[PIPELINE0]
> +type = MASTER
> +core = 0
> +
> +[PIPELINE1]
> +type = PASS-THROUGH
> +core = s1c1
> +pktq_in = RXQ0.0 RXQ1.0
> +pktq_out = TXQ1.0 TXQ0.0
> +
> +[EAL]
> +pci_whitelist = 0000:83:00.0
> +pci_whitelist = 0000:83:00.1
> +
> +[LINK0]
> +pci_bdf = 0000:85:00.0
> +
> +[LINK1]
> +pci_bdf = 0000:85:00.1
> +Run the command ./build/ip_pipeline -p 3 -
> f ./config/pt1_2ports_link_iden.cfg, check that the app runs successfully,
> if yes, test fail, otherwise, test pass
> +
> +----------------------------------------------------------------
> +7. CFG file containing "pci_bdf" in LINK section and EAL section shall
> NOT work with "-p" exists(EAL and LINK matches)
> +([root@dpdk_testserver03 ip_pipeline]# ./build/ip_pipeline -p 3 -
> f ./config/pt1_2ports_link_iden.cfg
> +Parse error in section "LINK0", entry "pci_bdf": entry not allowed
> (port_mask is provided)
> +
> +Aborted (core dumped))
> +----------------------------------------------------------------
> +Config file as follows
> +[PIPELINE0]
> +type = MASTER
> +core = 0
> +
> +[PIPELINE1]
> +type = PASS-THROUGH
> +core = s1c1
> +pktq_in = RXQ0.0 RXQ1.0
> +pktq_out = TXQ1.0 TXQ0.0
> +
> +[EAL]
> +pci_whitelist = 0000:85:00.0
> +pci_whitelist = 0000:85:00.1
> +
> +[LINK0]
> +pci_bdf = 0000:85:00.0
> +
> +[LINK1]
> +pci_bdf = 0000:85:00.1
> +Run the command ./build/ip_pipeline -p 3 -
> f ./config/pt1_2ports_link_iden.cfg, check that the app runs successfully,
> if yes, test fail, otherwise, test pass
> +
> +----------------------------------------------------------------
> +8. CFG file containing "pci_whitelist" in EAL section shall NOT work with
> "-p" absence
> +([root@dpdk_testserver03 ip_pipeline]# ./build/ip_pipeline -
> f ./config/pt1_2ports_link_iden.cfg
> +Parse error in section "EAL", entry "pci_whitelist": entry to be
> generated by the application (port_mask not provided)
> +
> +Aborted (core dumped))
> +----------------------------------------------------------------
> +Config file as follows
> +[PIPELINE0]
> +type = MASTER
> +core = 0
> +
> +[PIPELINE1]
> +type = PASS-THROUGH
> +core = s1c1
> +pktq_in = RXQ0.0 RXQ1.0
> +pktq_out = TXQ1.0 TXQ0.0
> +
> +[EAL]
> +pci_whitelist = 0000:85:00.0
> +pci_whitelist = 0000:85:00.1
> +Run the command ./build/ip_pipeline -f ./config/pt1_2ports_link_iden.cfg,
> check that the app runs successfully, if yes, test fail, otherwise, test
> pass
> +
> +
> +----------------------------------------------------------------
> +9. CFG file containing "pci_bdf" in 1 LINK sections shall work with "-p"
> absence
> +----------------------------------------------------------------
> +Config file as follows
> +[PIPELINE0]
> +type = MASTER
> +core = 0
> +
> +[PIPELINE1]
> +type = PASS-THROUGH
> +core = s1c1
> +pktq_in = RXQ0.0
> +pktq_out = TXQ0.0
> +
> +[LINK0]
> +pci_bdf = 0000:85:00.0
> +
> +Run the command ./build/ip_pipeline -f ./config/pt1_2ports_link_iden.cfg,
> check that the app runs successfully, if yes, test pass, otherwise, test
> fail
> +
> +----------------------------------------------------------------
> +10. CFG file containing "pci_bdf" in 2 LINK sections shall work with "-p"
> absence
> +----------------------------------------------------------------
> +Config file as follows
> +[PIPELINE0]
> +type = MASTER
> +core = 0
> +
> +[PIPELINE1]
> +type = PASS-THROUGH
> +core = s1c1
> +pktq_in = RXQ0.0 RXQ1.0
> +pktq_out = TXQ1.0 TXQ0.0
> +
> +[LINK0]
> +pci_bdf = 0000:85:00.0
> +
> +[LINK1]
> +pci_bdf = 0000:85:00.1
> +Run the command ./build/ip_pipeline -f ./config/pt1_2ports_link_iden.cfg,
> check that the app runs successfully, if yes, test pass, otherwise, test
> fail
> +
> +----------------------------------------------------------------
> +11. CFG file containing "pci_bdf" in 4 LINK sections shall work with "-p"
> absence
> +----------------------------------------------------------------
> +Config file as follows
> +[PIPELINE0]
> +type = MASTER
> +core = 0
> +
> +[PIPELINE1]
> +type = PASS-THROUGH
> +core = s1c1
> +pktq_in = RXQ0.0 RXQ1.0 RXQ2.0 RXQ3.0
> +pktq_out = TXQ0.0 TXQ1.0 TXQ2.0 TXQ3.0
> +
> +[LINK0]
> +pci_bdf = 0000:83:00.0
> +
> +[LINK1]
> +pci_bdf = 0000:83:00.1
> +
> +[LINK2]
> +pci_bdf = 0000:85:00.0
> +
> +[LINK3]
> +pci_bdf = 0000:85:00.1
> +Run the command ./build/ip_pipeline -f ./config/pt1_2ports_link_iden.cfg,
> check that the app runs successfully, if yes, test pass, otherwise, test
> fail
> +
> +----------------------------------------------------------------
> +12. CFG file containing "pci_bdf" in 1 LINK sections and 2 LINKS exists
> shall work with "-p" absence
> +----------------------------------------------------------------
> +Config file as follows
> +[PIPELINE0]
> +type = MASTER
> +core = 0
> +
> +[PIPELINE1]
> +type = PASS-THROUGH
> +core = s1c1
> +pktq_in = RXQ0.0 RXQ1.0
> +pktq_out = TXQ0.0 TXQ1.0
> +
> +[LINK0]
> +pci_bdf = 0000:85:00.0
> +
> +[LINK1]
> +pci_bdf = 0000:85:00.1
> +Run the command ./build/ip_pipeline -f ./config/pt1_2ports_link_iden.cfg,
> check that the app runs successfully, if yes, test pass, otherwise, test
> fail
> +
> +----------------------------------------------------------------
> +13. CFG file containing "pci_bdf" in 1 LINK sections and 2 LINKS exists
> shall NOT work with "-p" exists
> +[root@dpdk_testserver03 ip_pipeline]# ./build/ip_pipeline -p 3 -f
> ~/config/link_identification/link_iden_case_13.cfg
> +Parse error in section "LINK0", entry "pci_bdf": entry not allowed
> (port_mask is provided)
> +
> +Aborted (core dumped)
> +----------------------------------------------------------------
> +Config file as follows
> +[PIPELINE0]
> +type = MASTER
> +core = 0
> +
> +[PIPELINE1]
> +type = PASS-THROUGH
> +core = s1c1
> +pktq_in = RXQ0.0 RXQ1.0
> +pktq_out = TXQ0.0 TXQ1.0
> +
> +[LINK0]
> +pci_bdf = 0000:85:00.0
> +
> +[LINK1]
> +pci_bdf = 0000:85:00.1
> +Run the command ./build/ip_pipeline -p 3 -
> f ./config/pt1_2ports_link_iden.cfg, check that the app runs successfully,
> if yes, test pass, otherwise, test fail
> --
> 1.9.3
next prev parent reply other threads:[~2016-08-26 2:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 8:24 [dts] [PATCH V2 01/10] add ip_pipeline cfg test code xu,gang
2016-08-25 8:24 ` [dts] [PATCH V2 02/10] add ip_pipeline cfg test plan xu,gang
2016-08-26 1:28 ` Liu, Yong
2016-08-25 8:24 ` [dts] [PATCH V2 03/10] add ip_pipeline cpu utilization test code xu,gang
2016-08-25 8:24 ` [dts] [PATCH V2 04/10] add ip_pipeline cpu utilization test plan xu,gang
2016-08-25 8:24 ` [dts] [PATCH V2 05/10] add ip_pipeline link_identification test code xu,gang
2016-08-25 8:24 ` [dts] [PATCH V2 06/10] add ip_pipeline link_identification test plan xu,gang
2016-08-26 2:19 ` Liu, Yong [this message]
2016-08-25 8:24 ` [dts] [dst][PATCH V2 07/10] add ip_pipeline parser_cleanup test code xu,gang
2016-08-25 8:24 ` [dts] [PATCH V2 08/10] add ip_pipeline parser_cleanup test plan xu,gang
2016-08-25 8:24 ` [dts] [PATCH V2 09/10] add ip_pipeline source_sink test code xu,gang
2016-08-25 8:24 ` [dts] [PATCH V2 10/10] add ip_pipeline source_sink test plan xu,gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E22275EC9@SHSMSX103.ccr.corp.intel.com \
--to=yong.liu@intel.com \
--cc=dts@dpdk.org \
--cc=gangx.xu@intel.com \
--cc=qun.wan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).