From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 6EE5E58CB for ; Fri, 26 Aug 2016 04:19:07 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 25 Aug 2016 19:19:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,578,1464678000"; d="scan'208";a="1020518437" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga001.jf.intel.com with ESMTP; 25 Aug 2016 19:19:06 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 25 Aug 2016 19:19:05 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 25 Aug 2016 19:19:05 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.181]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.8]) with mapi id 14.03.0248.002; Fri, 26 Aug 2016 10:19:02 +0800 From: "Liu, Yong" To: "Xu, GangX" , "dts@dpdk.org" CC: "Xu, GangX" , "Wan, Qun" Thread-Topic: [dts] [PATCH V2 06/10] add ip_pipeline link_identification test plan Thread-Index: AQHR/qrHCLB04VnENUeQZzFhAOf+qKBafpdg Date: Fri, 26 Aug 2016 02:19:03 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E22275EC9@SHSMSX103.ccr.corp.intel.com> References: <1472113463-4298-1-git-send-email-gangx.xu@intel.com> <1472113463-4298-6-git-send-email-gangx.xu@intel.com> In-Reply-To: <1472113463-4298-6-git-send-email-gangx.xu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzZjMjlhYjgtMmRmYy00MWIyLTkwYjUtNWQ5MTFmMzNkOWY5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IldvSHVvRUlIZjBqY2hFSVk3OWFzd2ZjckwyXC9SMkpwd09JNldtdTN2YTU0PSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V2 06/10] add ip_pipeline link_identification test plan X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Aug 2016 02:19:08 -0000 Gang, some suggestions for create efficiency test plan, please check my com= ments below. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang > Sent: Thursday, August 25, 2016 4:24 PM > To: dts@dpdk.org > Cc: Xu, GangX > Subject: [dts] [PATCH V2 06/10] add ip_pipeline link_identification test > plan >=20 > Signed-off-by: xu,gang > --- > .../ip_pipeline_link_identification_test_plan.rst | 293 > +++++++++++++++++++++ > 1 file changed, 293 insertions(+) > create mode 100644 > test_plans/ip_pipeline_link_identification_test_plan.rst >=20 > diff --git a/test_plans/ip_pipeline_link_identification_test_plan.rst > b/test_plans/ip_pipeline_link_identification_test_plan.rst > new file mode 100644 > index 0000000..89a9bd7 > --- /dev/null > +++ b/test_plans/ip_pipeline_link_identification_test_plan.rst > @@ -0,0 +1,293 @@ > +Description > +Link identification has 2 goals, first is to create a brand new option i= n > CFG file's LINK > +section, so a link can be confgiured specific physical port using the PC= I > address. So the > +user can either use original "-p" option, or the new LINK section item t= o > identify the > +physical port he/she wants to use; Second is to maintain the original "- > p" option as it is. > +That is, the following logic shall be applied so that two ways will not > mix. Please segment this description, it's too long for reading. > + > +-------------------------------------------------------------------- > + |a. "-p" cmd option exists | b. "-p" cmd option not exist > +-------------------------------------------------------------------- > +1 |EAL section "pci_whitelist" |EAL section "pci_whitelist" is > + |option is allowed and optional |NOT allowed > +-------------------------------------------------------------------- > +2 |LINK section "pci_bdf" option |LINK section "pci_bdf" option > + |is NOT allowed |is MANDATORY > +------------------------------------------------------------------------= - > -- > +1. Regression for all the old CFG files(regression team should cover it) > +------------------------------------------------------------------------= - > -- Large table is not kind for reading. Please add line feeds to make sure tab= le length in 79 characters. > + > +---------------------------------------------------------------- > +2. CFG file containing 1 "pci_whitelist" section with "-p" exist shall > work Case name should be more abstractive, like "Test: cfg whitelist co-existed = with portmask param" Add test logic description just after test case definition. It will look l= ike "Add pci whitelist in cfg file and start ip_pipeline with one port masked. = Ip_pipline will startup normally with cfg file specified port" > +([root@dpdk_testserver03 ip_pipeline]# ./build/ip_pipeline -p 1 - > f ./config/pt1_2ports_link_iden.cfg Remove your own platform information, only keep command line here. > +Parse error in section "EAL", entry "pci_whitelist": too many elements > + > +Aborted (core dumped)) No need to record this kind of output log, one description like below is en= ough. "Ip_pipeline will be aborted for ..." > +---------------------------------------------------------------- > +Config file as follows No need to attach everything in the test plan. If only option pci_whitelist= is care in this suite, list this option is enough. > +[PIPELINE0] > +type =3D MASTER > +core =3D 0 > + > +[PIPELINE1] > +type =3D PASS-THROUGH > +core =3D s1c1 > +pktq_in =3D RXQ0.0 RXQ1.0 > +pktq_out =3D TXQ1.0 TXQ0.0 > + > +[EAL] > +pci_whitelist =3D 0000:85:00.0 > +Run the command ./build/ip_pipeline -p 1 - > f ./config/pt1_2ports_link_iden.cfg, check that the app runs successfully > + The description not match previous one. Please check it. > +---------------------------------------------------------------- > +3. CFG file containing 2 "pci_whitelist" sections with "-p" exists > +([root@dpdk_testserver03 ip_pipeline]# ./build/ip_pipeline -p 3 - > f ./config/pt1_2ports_link_iden.cfg > +Parse error in section "EAL", entry "pci_whitelist": too many elements > + > +Aborted (core dumped)) > +---------------------------------------------------------------- > +Config file as follows > + > + > +Run the command ./build/ip_pipeline -p 3 - > f ./config/pt1_2ports_link_iden.cfg, check that the app runs successfully > + > +---------------------------------------------------------------- > +4. CFG file containing 4 "pci_whitelist" sections with "-p" exists > +---------------------------------------------------------------- > +Config file as follows > +[PIPELINE0] > +type =3D MASTER > +core =3D 0 > + > +[PIPELINE1] > +type =3D PASS-THROUGH > +core =3D s1c1 > +pktq_in =3D RXQ0.0 RXQ1.0 RXQ2.0 RXQ3.0 > +pktq_out =3D TXQ0.0 TXQ1.0 TXQ2.0 TXQ3.0 > + > +[EAL] > +pci_whitelist =3D 0000:83:00.0 > +pci_whitelist =3D 0000:83:00.1 > +pci_whitelist =3D 0000:85:00.0 > +pci_whitelist =3D 0000:85:00.1 > +Run the command ./build/ip_pipeline -p f - > f ./config/pt1_2ports_link_iden.cfg, check that the app runs successfully > + > +---------------------------------------------------------------- > +5. CFG file containing "pci_bdf" in LINK section shall NOT work with "-p= " > exists > +([root@dpdk_testserver03 ip_pipeline]# ./build/ip_pipeline -p 3 - > f ./config/pt1_2ports_link_iden.cfg > +Parse error in section "LINK0", entry "pci_bdf": entry not allowed > (port_mask is provided) > + > +Aborted (core dumped)) > +---------------------------------------------------------------- > +Config file as follows > +[PIPELINE0] > +type =3D MASTER > +core =3D 0 > + > +[PIPELINE1] > +type =3D PASS-THROUGH > +core =3D s1c1 > +pktq_in =3D RXQ0.0 RXQ1.0 > +pktq_out =3D TXQ1.0 TXQ0.0 > + > +[LINK0] > +pci_bdf =3D 0000:85:00.0 > + > +[LINK1] > +pci_bdf =3D 0000:85:00.1 > +Run the command ./build/ip_pipeline -p 3 - > f ./config/pt1_2ports_link_iden.cfg, check that the app runs successfully= , > if yes, test fail, otherwise, test pass > + > +---------------------------------------------------------------- > +6. CFG file containing "pci_bdf" in LINK section and EAL section shall > NOT work with "-p" exists(EAL and LINK not matches) > +([root@dpdk_testserver03 ip_pipeline]# ./build/ip_pipeline -p 3 - > f ./config/pt1_2ports_link_iden.cfg > +Parse error in section "LINK0", entry "pci_bdf": entry not allowed > (port_mask is provided) > + > +Aborted (core dumped)) > +---------------------------------------------------------------- > +Config file as follows > +[PIPELINE0] > +type =3D MASTER > +core =3D 0 > + > +[PIPELINE1] > +type =3D PASS-THROUGH > +core =3D s1c1 > +pktq_in =3D RXQ0.0 RXQ1.0 > +pktq_out =3D TXQ1.0 TXQ0.0 > + > +[EAL] > +pci_whitelist =3D 0000:83:00.0 > +pci_whitelist =3D 0000:83:00.1 > + > +[LINK0] > +pci_bdf =3D 0000:85:00.0 > + > +[LINK1] > +pci_bdf =3D 0000:85:00.1 > +Run the command ./build/ip_pipeline -p 3 - > f ./config/pt1_2ports_link_iden.cfg, check that the app runs successfully= , > if yes, test fail, otherwise, test pass > + > +---------------------------------------------------------------- > +7. CFG file containing "pci_bdf" in LINK section and EAL section shall > NOT work with "-p" exists(EAL and LINK matches) > +([root@dpdk_testserver03 ip_pipeline]# ./build/ip_pipeline -p 3 - > f ./config/pt1_2ports_link_iden.cfg > +Parse error in section "LINK0", entry "pci_bdf": entry not allowed > (port_mask is provided) > + > +Aborted (core dumped)) > +---------------------------------------------------------------- > +Config file as follows > +[PIPELINE0] > +type =3D MASTER > +core =3D 0 > + > +[PIPELINE1] > +type =3D PASS-THROUGH > +core =3D s1c1 > +pktq_in =3D RXQ0.0 RXQ1.0 > +pktq_out =3D TXQ1.0 TXQ0.0 > + > +[EAL] > +pci_whitelist =3D 0000:85:00.0 > +pci_whitelist =3D 0000:85:00.1 > + > +[LINK0] > +pci_bdf =3D 0000:85:00.0 > + > +[LINK1] > +pci_bdf =3D 0000:85:00.1 > +Run the command ./build/ip_pipeline -p 3 - > f ./config/pt1_2ports_link_iden.cfg, check that the app runs successfully= , > if yes, test fail, otherwise, test pass > + > +---------------------------------------------------------------- > +8. CFG file containing "pci_whitelist" in EAL section shall NOT work wit= h > "-p" absence > +([root@dpdk_testserver03 ip_pipeline]# ./build/ip_pipeline - > f ./config/pt1_2ports_link_iden.cfg > +Parse error in section "EAL", entry "pci_whitelist": entry to be > generated by the application (port_mask not provided) > + > +Aborted (core dumped)) > +---------------------------------------------------------------- > +Config file as follows > +[PIPELINE0] > +type =3D MASTER > +core =3D 0 > + > +[PIPELINE1] > +type =3D PASS-THROUGH > +core =3D s1c1 > +pktq_in =3D RXQ0.0 RXQ1.0 > +pktq_out =3D TXQ1.0 TXQ0.0 > + > +[EAL] > +pci_whitelist =3D 0000:85:00.0 > +pci_whitelist =3D 0000:85:00.1 > +Run the command ./build/ip_pipeline -f ./config/pt1_2ports_link_iden.cfg= , > check that the app runs successfully, if yes, test fail, otherwise, test > pass > + > + > +---------------------------------------------------------------- > +9. CFG file containing "pci_bdf" in 1 LINK sections shall work with "-p" > absence > +---------------------------------------------------------------- > +Config file as follows > +[PIPELINE0] > +type =3D MASTER > +core =3D 0 > + > +[PIPELINE1] > +type =3D PASS-THROUGH > +core =3D s1c1 > +pktq_in =3D RXQ0.0 > +pktq_out =3D TXQ0.0 > + > +[LINK0] > +pci_bdf =3D 0000:85:00.0 > + > +Run the command ./build/ip_pipeline -f ./config/pt1_2ports_link_iden.cfg= , > check that the app runs successfully, if yes, test pass, otherwise, test > fail > + > +---------------------------------------------------------------- > +10. CFG file containing "pci_bdf" in 2 LINK sections shall work with "-p= " > absence > +---------------------------------------------------------------- > +Config file as follows > +[PIPELINE0] > +type =3D MASTER > +core =3D 0 > + > +[PIPELINE1] > +type =3D PASS-THROUGH > +core =3D s1c1 > +pktq_in =3D RXQ0.0 RXQ1.0 > +pktq_out =3D TXQ1.0 TXQ0.0 > + > +[LINK0] > +pci_bdf =3D 0000:85:00.0 > + > +[LINK1] > +pci_bdf =3D 0000:85:00.1 > +Run the command ./build/ip_pipeline -f ./config/pt1_2ports_link_iden.cfg= , > check that the app runs successfully, if yes, test pass, otherwise, test > fail > + > +---------------------------------------------------------------- > +11. CFG file containing "pci_bdf" in 4 LINK sections shall work with "-p= " > absence > +---------------------------------------------------------------- > +Config file as follows > +[PIPELINE0] > +type =3D MASTER > +core =3D 0 > + > +[PIPELINE1] > +type =3D PASS-THROUGH > +core =3D s1c1 > +pktq_in =3D RXQ0.0 RXQ1.0 RXQ2.0 RXQ3.0 > +pktq_out =3D TXQ0.0 TXQ1.0 TXQ2.0 TXQ3.0 > + > +[LINK0] > +pci_bdf =3D 0000:83:00.0 > + > +[LINK1] > +pci_bdf =3D 0000:83:00.1 > + > +[LINK2] > +pci_bdf =3D 0000:85:00.0 > + > +[LINK3] > +pci_bdf =3D 0000:85:00.1 > +Run the command ./build/ip_pipeline -f ./config/pt1_2ports_link_iden.cfg= , > check that the app runs successfully, if yes, test pass, otherwise, test > fail > + > +---------------------------------------------------------------- > +12. CFG file containing "pci_bdf" in 1 LINK sections and 2 LINKS exists > shall work with "-p" absence > +---------------------------------------------------------------- > +Config file as follows > +[PIPELINE0] > +type =3D MASTER > +core =3D 0 > + > +[PIPELINE1] > +type =3D PASS-THROUGH > +core =3D s1c1 > +pktq_in =3D RXQ0.0 RXQ1.0 > +pktq_out =3D TXQ0.0 TXQ1.0 > + > +[LINK0] > +pci_bdf =3D 0000:85:00.0 > + > +[LINK1] > +pci_bdf =3D 0000:85:00.1 > +Run the command ./build/ip_pipeline -f ./config/pt1_2ports_link_iden.cfg= , > check that the app runs successfully, if yes, test pass, otherwise, test > fail > + > +---------------------------------------------------------------- > +13. CFG file containing "pci_bdf" in 1 LINK sections and 2 LINKS exists > shall NOT work with "-p" exists > +[root@dpdk_testserver03 ip_pipeline]# ./build/ip_pipeline -p 3 -f > ~/config/link_identification/link_iden_case_13.cfg > +Parse error in section "LINK0", entry "pci_bdf": entry not allowed > (port_mask is provided) > + > +Aborted (core dumped) > +---------------------------------------------------------------- > +Config file as follows > +[PIPELINE0] > +type =3D MASTER > +core =3D 0 > + > +[PIPELINE1] > +type =3D PASS-THROUGH > +core =3D s1c1 > +pktq_in =3D RXQ0.0 RXQ1.0 > +pktq_out =3D TXQ0.0 TXQ1.0 > + > +[LINK0] > +pci_bdf =3D 0000:85:00.0 > + > +[LINK1] > +pci_bdf =3D 0000:85:00.1 > +Run the command ./build/ip_pipeline -p 3 - > f ./config/pt1_2ports_link_iden.cfg, check that the app runs successfully= , > if yes, test pass, otherwise, test fail > -- > 1.9.3