test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Tu, LijuanX A" <lijuanx.a.tu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Tu, LijuanX A" <lijuanx.a.tu@intel.com>
Subject: Re: [dts] [PATCH 1/2] vxlan: fix vlan load pcap error
Date: Mon, 5 Sep 2016 03:42:24 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E6022C1F2@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1472784976-15927-1-git-send-email-lijuanx.a.tu@intel.com>

Lijuan, send_pcap function just loaded pcap and sent it out. There's no need to load internal module, is this one bug in scapy?

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Lijuan Tu
> Sent: Friday, September 02, 2016 10:56 AM
> To: dts@dpdk.org
> Cc: Tu, LijuanX A
> Subject: [dts] [PATCH 1/2] vxlan: fix vlan load pcap error
> 
> vxlan is not supported by scapy,
> and thus the packets are interpreted as raw packets.
> 
> Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
> ---
>  tests/TestSuite_vxlan.py | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py
> index c1d0200..d5274fc 100644
> --- a/tests/TestSuite_vxlan.py
> +++ b/tests/TestSuite_vxlan.py
> @@ -24,7 +24,7 @@ from scapy.config import conf
>  from scapy.route import *
> 
>  from test_case import TestCase
> -from settings import HEADER_SIZE
> +from settings import HEADER_SIZE, FOLDERS
>  from etgen import IxiaPacketGenerator
> 
>  #
> @@ -236,6 +236,11 @@ class VxlanTestConfig(object):
>          """
>          Send vxlan pcap file by iface
>          """
> +        # load vxlan module to scapy
> +        cwd = os.getcwd()
> +        dir_vxlan_module = cwd + r'/' + FOLDERS['Depends']
> +        self.test_case.tester.scapy_append("sys.path.append('%s')" %
> dir_vxlan_module)
> +        self.test_case.tester.scapy_append("from vxlan import Vxlan")
>          self.test_case.tester.scapy_append(
>              'pcap = rdpcap("%s")' % self.pcap_file)
>          self.test_case.tester.scapy_append(
> --
> 1.9.3

  parent reply	other threads:[~2016-09-05  3:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-02  2:53 [dts] [PATCH 0/2] fix vxlan_sample tso test failed Lijuan Tu
2016-09-02  2:56 ` [dts] [PATCH 1/2] vxlan: fix vlan load pcap error Lijuan Tu
2016-09-05  0:15   ` Xu, HuilongX
2016-09-05  3:42   ` Liu, Yong [this message]
2016-09-02  2:59 ` [dts] [PATCH 2/2] vxlan_sample: check l3 and l4 checksum on tso test Lijuan Tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E6022C1F2@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=lijuanx.a.tu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).