test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Xu, GangX" <gangx.xu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xu, GangX" <gangx.xu@intel.com>
Subject: Re: [dts] [PATCH V1 1/3] solve dts compile error on freesbd
Date: Tue, 6 Sep 2016 06:13:21 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E6022CC2F@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1472550717-9922-1-git-send-email-gangx.xu@intel.com>

Hi Gang, NIC object should input three parameter. If NIC object initialized with incorrect parameters, it may cause error when called some methods.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang
> Sent: Tuesday, August 30, 2016 5:52 PM
> To: dts@dpdk.org
> Cc: Xu, GangX
> Subject: [dts] [PATCH V1 1/3] solve dts compile error on freesbd
> 
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>  framework/dut.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/framework/dut.py b/framework/dut.py
> index 2f4e53a..d92713b 100644
> --- a/framework/dut.py
> +++ b/framework/dut.py
> @@ -726,7 +726,7 @@ class Dut(Crb):
>                                                        skipped))
>                  continue
> 
> -            port = GetNicObj(self, pci_bus, '')
> +            port = GetNicObj(self, '',pci_bus, '')
>              intf = port.get_interface_name()
> 
>              macaddr = port.get_mac_addr()
> --
> 1.9.3

      parent reply	other threads:[~2016-09-06  6:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-30  9:51 xu,gang
2016-08-30  9:51 ` [dts] [PATCH V1 2/3] " xu,gang
2016-08-30  9:51 ` [dts] [PATCH V1 3/3] " xu,gang
2016-08-31  0:16 ` [dts] [PATCH V1 1/3] solve dts compile error on FreeBSD Xu, HuilongX
2016-09-06  6:13 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E6022CC2F@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=gangx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).