Re: [dts] [PATCH V1 5/6] add xstats test code

["Liu, Yong" <yong.liu@intel.com>]

Hi gang, need enlarge the scope of test plan.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang
> Sent: Monday, August 15, 2016 12:47 PM
> To: dts@dpdk.org
> Cc: Xu, GangX
> Subject: [dts] [PATCH V1 5/6] add xstats test code
> 
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>  tests/TestSuite_xstats.py | 103
> ++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 103 insertions(+)
>  create mode 100644 tests/TestSuite_xstats.py
> 
> diff --git a/tests/TestSuite_xstats.py b/tests/TestSuite_xstats.py
> new file mode 100644
> index 0000000..6bbcabb
> --- /dev/null
> +++ b/tests/TestSuite_xstats.py
> @@ -0,0 +1,103 @@
> +#BSD LICENSE
> +#
> +# Copyright(c) 2010-2016 Intel Corporation. All rights reserved.
> +# All rights reserved.
> +#
> +# Redistribution and use in source and binary forms, with or without
> +# modification, are permitted provided that the following conditions
> +# are met:
> +#
> +#   * Redistributions of source code must retain the above copyright
> +#     notice, this list of conditions and the following disclaimer.
> +#   * Redistributions in binary form must reproduce the above copyright
> +#     notice, this list of conditions and the following disclaimer in
> +#     the documentation and/or other materials provided with the
> +#     distribution.
> +#   * Neither the name of Intel Corporation nor the names of its
> +#     contributors may be used to endorse or promote products derived
> +#     from this software without specific prior written permission.
> +#
> +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
> +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
> +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
> +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> +
> +
> +"""
> +DPDK Test suite.
> +Test xstats.
> +"""
> +
> +import dts
> +import string
> +import time
> +import re
> +from test_case import TestCase
> +from plotting import Plotting
> +from settings import HEADER_SIZE
> +from etgen import IxiaPacketGenerator
> +from packet import Packet, sniff_packets, load_sniff_packets
> +
> +class TestXstats(TestCase):
> +
> +    def set_up_all(self):
> +        """
> +        Run at the start of each test suite.
> +        """
> +        self.dut_ports = self.dut.get_ports(self.nic)
> +        self.verify(len(self.dut_ports) >= 2, "Insufficient ports")
> +        cores = self.dut.get_core_list("1S/4C/1T")
> +        self.coremask = dts.create_mask(cores)
> +
> +        self.path = "./x86_64-native-linuxapp-gcc/app/testpmd"
Binary path may change when use different kinds of target. Please use PmdOutPut module to manager testpmd application.
There're lots of reference in DTS suites.

> +
> +    def set_up(self):
> +        """
> +        Run before each test case.
> +        """
> +        pass
> +
> +    def test_xstats(self):
> +        cmd = self.path + " -c %s -n %d -- -i" %
> (self.coremask,self.dut.get_memory_channels())
> +
> +        self.dut.send_expect(cmd,"Done",30)
> +        xstats_port = self.dut_ports[0]
> +        self.dut.send_expect("start","io packet forwarding",5)
> +        self.dut.send_expect("show port xstats %s" %
> xstats_port,"rx_mbuf_allocation_errors:",10)
> +        self.scapy_send_package()
> +        out = self.dut.send_expect("show port xstats %s" %
> xstats_port,"rx_mbuf_allocation_errors:",10)
> +        print out
> +        p = re.compile(r'\d+')
> +        result = p.findall(out)
> +        self.verify("100" in result, "Test failure:rx_good_packets error")
> +
Only basic statics is not enough for xstats overall validation. 
>From the output of extended statistics, we need to validate most of them.


###### NIC extended statistics for port 0
rx_good_packets: 0
tx_good_packets: 0
rx_good_bytes: 0
tx_good_bytes: 0
rx_errors: 0
tx_errors: 0
rx_mbuf_allocation_errors: 0
rx_q0packets: 0
rx_q0bytes: 0
rx_q0errors: 0
tx_q0packets: 0
tx_q0bytes: 0
rx_crc_errors: 0
rx_illegal_byte_errors: 0
rx_error_bytes: 0
mac_local_errors: 2
mac_remote_errors: 1
rx_length_errors: 0
tx_xon_packets: 0
rx_xon_packets: 0
tx_xoff_packets: 0
rx_xoff_packets: 0
rx_size_64_packets: 0
rx_size_65_to_127_packets: 0
rx_size_128_to_255_packets: 0
rx_size_256_to_511_packets: 0
rx_size_512_to_1023_packets: 0
rx_size_1024_to_max_packets: 0
rx_broadcast_packets: 0
rx_multicast_packets: 0
rx_fragment_errors: 0
rx_undersize_errors: 0
rx_oversize_errors: 0
rx_jabber_errors: 0
rx_management_packets: 0
rx_management_dropped: 0
tx_management_packets: 0
rx_total_packets: 0
rx_total_bytes: 0
tx_total_packets: 0
tx_size_64_packets: 0
tx_size_65_to_127_packets: 0
tx_size_128_to_255_packets: 0
tx_size_256_to_511_packets: 0
tx_size_512_to_1023_packets: 0
tx_size_1024_to_max_packets: 0
tx_multicast_packets: 0
tx_broadcast_packets: 0
rx_mac_short_packet_dropped: 0
rx_l3_l4_xsum_error: 0
flow_director_added_filters: 0
flow_director_removed_filters: 0
flow_director_filter_add_errors: 0
flow_director_filter_remove_errors: 0
flow_director_matched_filters: 0
flow_director_missed_filters: 0
rx_fcoe_crc_errors: 0
rx_fcoe_dropped: 0
rx_fcoe_mbuf_allocation_errors: 0
rx_fcoe_packets: 0
tx_fcoe_packets: 0
rx_fcoe_bytes: 0
tx_fcoe_bytes: 0
rx_fcoe_no_direct_data_placement: 0
rx_fcoe_no_direct_data_placement_ext_buff: 0
tx_flow_control_xon_packets: 0
rx_flow_control_xon_packets: 0
tx_flow_control_xoff_packets: 0
rx_flow_control_xoff_packets: 0
rx_total_missed_packets: 0
rx_priority0_mbuf_allocation_errors: 0
rx_priority1_mbuf_allocation_errors: 0
rx_priority2_mbuf_allocation_errors: 0
rx_priority3_mbuf_allocation_errors: 0
rx_priority4_mbuf_allocation_errors: 0
rx_priority5_mbuf_allocation_errors: 0
rx_priority6_mbuf_allocation_errors: 0
rx_priority7_mbuf_allocation_errors: 0
rx_priority0_dropped: 0
rx_priority1_dropped: 0
rx_priority2_dropped: 0
rx_priority3_dropped: 0
rx_priority4_dropped: 0
rx_priority5_dropped: 0
rx_priority6_dropped: 0
rx_priority7_dropped: 0
rx_priority0_xon_packets: 0
rx_priority1_xon_packets: 0
rx_priority2_xon_packets: 0
rx_priority3_xon_packets: 0
rx_priority4_xon_packets: 0
rx_priority5_xon_packets: 0
rx_priority6_xon_packets: 0
rx_priority7_xon_packets: 0
rx_priority0_xoff_packets: 0
rx_priority1_xoff_packets: 0
rx_priority2_xoff_packets: 0
rx_priority3_xoff_packets: 0
rx_priority4_xoff_packets: 0
rx_priority5_xoff_packets: 0
rx_priority6_xoff_packets: 0
rx_priority7_xoff_packets: 0
tx_priority0_xon_packets: 0
tx_priority1_xon_packets: 0
tx_priority2_xon_packets: 0
tx_priority3_xon_packets: 0
tx_priority4_xon_packets: 0
tx_priority5_xon_packets: 0
tx_priority6_xon_packets: 0
tx_priority7_xon_packets: 0
tx_priority0_xoff_packets: 0
tx_priority1_xoff_packets: 0
tx_priority2_xoff_packets: 0
tx_priority3_xoff_packets: 0
tx_priority4_xoff_packets: 0
tx_priority5_xoff_packets: 0
tx_priority6_xoff_packets: 0
tx_priority7_xoff_packets: 0
tx_priority0_xon_to_xoff_packets: 0
tx_priority1_xon_to_xoff_packets: 0
tx_priority2_xon_to_xoff_packets: 0
tx_priority3_xon_to_xoff_packets: 0
tx_priority4_xon_to_xoff_packets: 0
tx_priority5_xon_to_xoff_packets: 0
tx_priority6_xon_to_xoff_packets: 0
tx_priority7_xon_to_xoff_packets: 0

> +    def scapy_send_package(self):
> +        """
> +        Send a packet to port
> +        """
> +        txport = self.tester.get_local_port(self.dut_ports[0])
> +        mac = self.dut.get_mac_address(self.dut_ports[0])
> +        txItf = self.tester.get_interface(txport)
> +
> self.tester.scapy_append('sendp([Ether(dst="%s")/IP()/UDP()/Raw(\'X\'*18)],
> iface="%s",count=100)' % (mac, txItf))
> +        self.tester.scapy_execute()
> +
> +
> +    def tear_down(self):
> +        """
> +        Run after each test case.
> +        """
> +        self.dut.kill_all()
> +        time.sleep(2)
> +
> +    def tear_down_all(self):
> +        """
> +        Run after each test suite.
> +        """
> +        pass
> --
> 1.9.3
>