[dts] [PATCH V2 1/5] fix TestSuite ieee1588

[dts] [PATCH V2 1/5] fix TestSuite ieee1588

[xu,gang]

wait for subprocess end in scapy_execute()

Signed-off-by: xu,gang <gangx.xu@intel.com>
---
 tests/TestSuite_ieee1588.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/TestSuite_ieee1588.py b/tests/TestSuite_ieee1588.py
index bfbb23b..7976c9f 100644
--- a/tests/TestSuite_ieee1588.py
+++ b/tests/TestSuite_ieee1588.py
@@ -92,6 +92,7 @@ class TestIeee1588(TestCase):
         self.tester.scapy_append('time.sleep(1)')
 
         self.tester.scapy_execute()
+        time.sleep(10)
         out = self.tester.scapy_get_result()
         self.verify("0x88f7" in out, "Ether type is not PTP")
         # self.verify("\\x00\\x02" in out, "Payload wrong in PTP")
-- 
1.9.3

[dts] [PATCH V2 2/5] fix TestSuite unit_tests_mbuf

[xu,gang]

it is run time more then a minute 

Signed-off-by: xu,gang <gangx.xu@intel.com>
---
 tests/TestSuite_unit_tests_mbuf.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_unit_tests_mbuf.py b/tests/TestSuite_unit_tests_mbuf.py
index c4dfaab..9493139 100644
--- a/tests/TestSuite_unit_tests_mbuf.py
+++ b/tests/TestSuite_unit_tests_mbuf.py
@@ -71,7 +71,7 @@ class TestUnitTestsMbuf(TestCase):
         """
 
         self.dut.send_expect("./app/test/test -n 1 -c ffff", "R.*T.*E.*>.*>", 60)
-        out = self.dut.send_expect("mbuf_autotest", "RTE>>", 60)
+        out = self.dut.send_expect("mbuf_autotest", "RTE>>", 180)
         self.dut.send_expect("quit", "# ")
         self.verify("Test OK" in out, "Test failed")
 
-- 
1.9.3

Re: [dts] [PATCH V2 2/5] fix TestSuite unit_tests_mbuf

[Liu, Yong]

Gang, please give more information like platform/cpu/OS.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang
> Sent: Wednesday, September 21, 2016 6:19 PM
> To: dts@dpdk.org
> Cc: Xu, GangX
> Subject: [dts] [PATCH V2 2/5] fix TestSuite unit_tests_mbuf
> 
> it is run time more then a minute
> 
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>  tests/TestSuite_unit_tests_mbuf.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_unit_tests_mbuf.py
> b/tests/TestSuite_unit_tests_mbuf.py
> index c4dfaab..9493139 100644
> --- a/tests/TestSuite_unit_tests_mbuf.py
> +++ b/tests/TestSuite_unit_tests_mbuf.py
> @@ -71,7 +71,7 @@ class TestUnitTestsMbuf(TestCase):
>          """
> 
>          self.dut.send_expect("./app/test/test -n 1 -c ffff",
> "R.*T.*E.*>.*>", 60)
> -        out = self.dut.send_expect("mbuf_autotest", "RTE>>", 60)
> +        out = self.dut.send_expect("mbuf_autotest", "RTE>>", 180)
>          self.dut.send_expect("quit", "# ")
>          self.verify("Test OK" in out, "Test failed")
> 
> --
> 1.9.3

[dts] [PATCH V2 3/5] fix TestSuite unit_tests_ringpmd

[xu,gang]

it is run time more then a minute
Signed-off-by: xu,gang <gangx.xu@intel.com>
---
 tests/TestSuite_unit_tests_ringpmd.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_unit_tests_ringpmd.py b/tests/TestSuite_unit_tests_ringpmd.py
index 2c83bcd..05305ff 100644
--- a/tests/TestSuite_unit_tests_ringpmd.py
+++ b/tests/TestSuite_unit_tests_ringpmd.py
@@ -71,12 +71,12 @@ class TestUnitTestsRingPmd(TestCase):
         """
         dev_str = "--vdev=eth_ring0 --vdev=eth_ring1"
 
-        self.dut.send_expect("./%s/app/test -n 1 -c ffff" % self.target, "R.*T.*E.*>.*>", 10)
+        self.dut.send_expect("./%s/app/test -n 1 -c ffff" % self.target, "R.*T.*E.*>.*>", 120)
         out = self.dut.send_expect("ring_pmd_autotest", "RTE>>", 120)
         self.dut.send_expect("quit", "# ")
         self.verify("Test OK" in out, "Default no eth_ring devices Test failed")
 
-        self.dut.send_expect("./%s/app/test -n 1 -c ffff %s" % (self.target, dev_str), "R.*T.*E.*>.*>", 10)
+        self.dut.send_expect("./%s/app/test -n 1 -c ffff %s" % (self.target, dev_str), "R.*T.*E.*>.*>", 120)
         out = self.dut.send_expect("ring_pmd_autotest", "RTE>>", 120)
         self.dut.send_expect("quit", "# ")
         self.verify("Test OK" in out, "Two eth_ring devices test failed")
-- 
1.9.3

Re: [dts] [PATCH V2 3/5] fix TestSuite unit_tests_ringpmd

[Liu, Yong]

Gang, please give more information like platform/cpu/OS and how many time needed for application start up.
As I known, dpdk has been optimized initialize sequence. It should not take so long time for start-up.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang
> Sent: Wednesday, September 21, 2016 6:19 PM
> To: dts@dpdk.org
> Cc: Xu, GangX
> Subject: [dts] [PATCH V2 3/5] fix TestSuite unit_tests_ringpmd
> 
> it is run time more then a minute
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>  tests/TestSuite_unit_tests_ringpmd.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_unit_tests_ringpmd.py
> b/tests/TestSuite_unit_tests_ringpmd.py
> index 2c83bcd..05305ff 100644
> --- a/tests/TestSuite_unit_tests_ringpmd.py
> +++ b/tests/TestSuite_unit_tests_ringpmd.py
> @@ -71,12 +71,12 @@ class TestUnitTestsRingPmd(TestCase):
>          """
>          dev_str = "--vdev=eth_ring0 --vdev=eth_ring1"
> 
> -        self.dut.send_expect("./%s/app/test -n 1 -c ffff" % self.target,
> "R.*T.*E.*>.*>", 10)
> +        self.dut.send_expect("./%s/app/test -n 1 -c ffff" % self.target,
> "R.*T.*E.*>.*>", 120)
>          out = self.dut.send_expect("ring_pmd_autotest", "RTE>>", 120)
>          self.dut.send_expect("quit", "# ")
>          self.verify("Test OK" in out, "Default no eth_ring devices Test
> failed")
> 
> -        self.dut.send_expect("./%s/app/test -n 1 -c ffff %s" %
> (self.target, dev_str), "R.*T.*E.*>.*>", 10)
> +        self.dut.send_expect("./%s/app/test -n 1 -c ffff %s" %
> (self.target, dev_str), "R.*T.*E.*>.*>", 120)
>          out = self.dut.send_expect("ring_pmd_autotest", "RTE>>", 120)
>          self.dut.send_expect("quit", "# ")
>          self.verify("Test OK" in out, "Two eth_ring devices test failed")
> --
> 1.9.3

[dts] [PATCH V2 4/5] fix TestSuite coremask

[xu,gang]

copy standard error to standard output,that wo can read in out file

Signed-off-by: xu,gang <gangx.xu@intel.com>
---
 tests/TestSuite_coremask.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_coremask.py b/tests/TestSuite_coremask.py
index 9fd039d..2458d8f 100644
--- a/tests/TestSuite_coremask.py
+++ b/tests/TestSuite_coremask.py
@@ -104,7 +104,7 @@ class TestCoremask(TestCase):
         Check coremask parsing for more cores than available.
         """
 
-        command_line = """./%s/app/test -c %s -n %d --log-level 8|tee out"""
+        command_line = """./%s/app/test -c %s -n %d --log-level 8 2 > &1 |tee out"""
 
         # Default big coremask value 128
         big_coremask_size = 128
-- 
1.9.3

Re: [dts] [PATCH V2 4/5] fix TestSuite coremask

[Liu, Yong]

Hi gang, please add which kind of information moved to stderr in your comment.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang
> Sent: Wednesday, September 21, 2016 6:19 PM
> To: dts@dpdk.org
> Cc: Xu, GangX
> Subject: [dts] [PATCH V2 4/5] fix TestSuite coremask
> 
> copy standard error to standard output,that wo can read in out file
> 
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>  tests/TestSuite_coremask.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_coremask.py b/tests/TestSuite_coremask.py
> index 9fd039d..2458d8f 100644
> --- a/tests/TestSuite_coremask.py
> +++ b/tests/TestSuite_coremask.py
> @@ -104,7 +104,7 @@ class TestCoremask(TestCase):
>          Check coremask parsing for more cores than available.
>          """
> 
> -        command_line = """./%s/app/test -c %s -n %d --log-level 8|tee
> out"""
> +        command_line = """./%s/app/test -c %s -n %d --log-level 8 2 > &1
> |tee out"""
> 
>          # Default big coremask value 128
>          big_coremask_size = 128
> --
> 1.9.3

[dts] [PATCH V2 5/5] increased huge page memory size on FreeBSD

[xu,gang]

increased huge page memory size on FreeBSD
some test suite need big huge page memory

Signed-off-by: xu,gang <gangx.xu@intel.com>
---
 framework/dut.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/dut.py b/framework/dut.py
index 86923d1..6fb046b 100644
--- a/framework/dut.py
+++ b/framework/dut.py
@@ -320,7 +320,7 @@ class Dut(Crb):
         Setup Freebsd hugepages.
         """
         if hugepages is -1:
-            hugepages = 2048
+            hugepages = 4096
 
         num_buffers = hugepages / 1024
         if num_buffers:
-- 
1.9.3

Re: [dts] [PATCH V2 5/5] increased huge page memory size on FreeBSD

[Liu, Yong]

Thanks, applied with more information added in.

On 09/21/2016 06:18 PM, xu,gang wrote:
> increased huge page memory size on FreeBSD
> some test suite need big huge page memory
>
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>   framework/dut.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/framework/dut.py b/framework/dut.py
> index 86923d1..6fb046b 100644
> --- a/framework/dut.py
> +++ b/framework/dut.py
> @@ -320,7 +320,7 @@ class Dut(Crb):
>           Setup Freebsd hugepages.
>           """
>           if hugepages is -1:
> -            hugepages = 2048
> +            hugepages = 4096
>   
>           num_buffers = hugepages / 1024
>           if num_buffers:

Re: [dts] [PATCH V2 1/5] fix TestSuite ieee1588

[Liu, Yong]

Hi gang, these patches have no relationships to each other. There's no 
need to create one patch set for them. You can send patches out one by one.
If scapy sniff function is not stable, you can try to use packet module 
for packet sniff. Again, we need the root cause of this issue.

On 09/21/2016 06:18 PM, xu,gang wrote:
> wait for subprocess end in scapy_execute()
>
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>   tests/TestSuite_ieee1588.py | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/tests/TestSuite_ieee1588.py b/tests/TestSuite_ieee1588.py
> index bfbb23b..7976c9f 100644
> --- a/tests/TestSuite_ieee1588.py
> +++ b/tests/TestSuite_ieee1588.py
> @@ -92,6 +92,7 @@ class TestIeee1588(TestCase):
>           self.tester.scapy_append('time.sleep(1)')
>   
>           self.tester.scapy_execute()
> +        time.sleep(10)
>           out = self.tester.scapy_get_result()
>           self.verify("0x88f7" in out, "Ether type is not PTP")
>           # self.verify("\\x00\\x02" in out, "Payload wrong in PTP")

[dts] [PATCH V2 2/5] fix TestSuite unit_tests_mbuf

[xu,gang]

it have use more time for run on FreeBSD

Signed-off-by: xu,gang <gangx.xu@intel.com>
---
 tests/TestSuite_unit_tests_mbuf.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_unit_tests_mbuf.py b/tests/TestSuite_unit_tests_mbuf.py
index c4dfaab..9493139 100644
--- a/tests/TestSuite_unit_tests_mbuf.py
+++ b/tests/TestSuite_unit_tests_mbuf.py
@@ -71,7 +71,7 @@ class TestUnitTestsMbuf(TestCase):
         """
 
         self.dut.send_expect("./app/test/test -n 1 -c ffff", "R.*T.*E.*>.*>", 60)
-        out = self.dut.send_expect("mbuf_autotest", "RTE>>", 60)
+        out = self.dut.send_expect("mbuf_autotest", "RTE>>", 180)
         self.dut.send_expect("quit", "# ")
         self.verify("Test OK" in out, "Test failed")
 
-- 
1.9.3

[dts] [PATCH V2 4/5] fix TestSuite coremask

[xu,gang]

on FreeBSD this command output is divided into standard errors and the standard output
copy standard error to standard output import out file, check all them

Signed-off-by: xu,gang <gangx.xu@intel.com>
---
 tests/TestSuite_coremask.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_coremask.py b/tests/TestSuite_coremask.py
index 9fd039d..2458d8f 100644
--- a/tests/TestSuite_coremask.py
+++ b/tests/TestSuite_coremask.py
@@ -104,7 +104,7 @@ class TestCoremask(TestCase):
         Check coremask parsing for more cores than available.
         """
 
-        command_line = """./%s/app/test -c %s -n %d --log-level 8|tee out"""
+        command_line = """./%s/app/test -c %s -n %d --log-level 8 2 > &1 |tee out"""
 
         # Default big coremask value 128
         big_coremask_size = 128
-- 
1.9.3

Re: [dts] [PATCH V2 4/5] fix TestSuite coremask

[Liu, Yong]

Thanks applied.

On 09/22/2016 10:45 AM, xu,gang wrote:
> on FreeBSD this command output is divided into standard errors and the standard output
> copy standard error to standard output import out file, check all them
>
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>   tests/TestSuite_coremask.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_coremask.py b/tests/TestSuite_coremask.py
> index 9fd039d..2458d8f 100644
> --- a/tests/TestSuite_coremask.py
> +++ b/tests/TestSuite_coremask.py
> @@ -104,7 +104,7 @@ class TestCoremask(TestCase):
>           Check coremask parsing for more cores than available.
>           """
>   
> -        command_line = """./%s/app/test -c %s -n %d --log-level 8|tee out"""
> +        command_line = """./%s/app/test -c %s -n %d --log-level 8 2 > &1 |tee out"""
>   
>           # Default big coremask value 128
>           big_coremask_size = 128