* [dts] [PATCH V1 2/3] fix TestSuite unit_tests_lpm on FreeBSD
2016-09-28 8:45 [dts] [PATCH V1 1/3] fix TestSuite coremask on FreeBSD xu,gang
@ 2016-09-28 8:45 ` xu,gang
2016-09-29 5:30 ` Liu, Yong
2016-09-28 8:45 ` [dts] [PATCH V1 3/3] fix TestSuite unit_tests_mbuf " xu,gang
2016-09-29 5:26 ` [dts] [PATCH V1 1/3] fix TestSuite coremask " Liu, Yong
2 siblings, 1 reply; 6+ messages in thread
From: xu,gang @ 2016-09-28 8:45 UTC (permalink / raw)
To: dts; +Cc: xu,gang
build branch for FreeBSD in TestSuite unit_tests_lpm
old code not support FreeBSD
Signed-off-by: xu,gang <gangx.xu@intel.com>
---
tests/TestSuite_unit_tests_lpm.py | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/tests/TestSuite_unit_tests_lpm.py b/tests/TestSuite_unit_tests_lpm.py
index dadb492..d892916 100644
--- a/tests/TestSuite_unit_tests_lpm.py
+++ b/tests/TestSuite_unit_tests_lpm.py
@@ -83,16 +83,21 @@ class TestUnitTestsLpmIpv6(TestCase):
"""
[arch, machine, env, toolchain] = self.target.split('-')
self.verify(arch == "x86_64", "lpm6 request huge memory")
-
- hugepage_ori = self.dut.get_total_huge_pages()
- self.dut.set_huge_pages(4096)
- hugepage_num = self.dut.get_total_huge_pages()
- self.verify(hugepage_num >= 4096, "failed to request huge memory")
+ if env == 'bsdapp':
+ pass
+ else:
+ hugepage_ori = self.dut.get_total_huge_pages()
+ self.dut.set_huge_pages(4096)
+ hugepage_num = self.dut.get_total_huge_pages()
+ self.verify(hugepage_num >= 4096, "failed to request huge memory")
self.dut.send_expect("./app/test/test -n 1 -c ffff", "R.*T.*E.*>.*>", 60)
out = self.dut.send_expect("lpm6_autotest", "RTE>>", 3600)
self.dut.send_expect("quit", "# ")
- self.dut.set_huge_pages(hugepage_ori)
+ if env == 'bsdapp':
+ pass
+ else:
+ self.dut.set_huge_pages(hugepage_ori)
self.verify("Test OK" in out, "Test failed")
def tear_down(self):
--
1.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dts] [PATCH V1 2/3] fix TestSuite unit_tests_lpm on FreeBSD
2016-09-28 8:45 ` [dts] [PATCH V1 2/3] fix TestSuite unit_tests_lpm " xu,gang
@ 2016-09-29 5:30 ` Liu, Yong
0 siblings, 0 replies; 6+ messages in thread
From: Liu, Yong @ 2016-09-29 5:30 UTC (permalink / raw)
To: xu,gang, dts
Applied, please make submit title and log more readable.
On 09/28/2016 04:45 PM, xu,gang wrote:
> build branch for FreeBSD in TestSuite unit_tests_lpm
> old code not support FreeBSD
>
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
> tests/TestSuite_unit_tests_lpm.py | 17 +++++++++++------
> 1 file changed, 11 insertions(+), 6 deletions(-)
>
> diff --git a/tests/TestSuite_unit_tests_lpm.py b/tests/TestSuite_unit_tests_lpm.py
> index dadb492..d892916 100644
> --- a/tests/TestSuite_unit_tests_lpm.py
> +++ b/tests/TestSuite_unit_tests_lpm.py
> @@ -83,16 +83,21 @@ class TestUnitTestsLpmIpv6(TestCase):
> """
> [arch, machine, env, toolchain] = self.target.split('-')
> self.verify(arch == "x86_64", "lpm6 request huge memory")
> -
> - hugepage_ori = self.dut.get_total_huge_pages()
> - self.dut.set_huge_pages(4096)
> - hugepage_num = self.dut.get_total_huge_pages()
> - self.verify(hugepage_num >= 4096, "failed to request huge memory")
> + if env == 'bsdapp':
> + pass
> + else:
> + hugepage_ori = self.dut.get_total_huge_pages()
> + self.dut.set_huge_pages(4096)
> + hugepage_num = self.dut.get_total_huge_pages()
> + self.verify(hugepage_num >= 4096, "failed to request huge memory")
>
> self.dut.send_expect("./app/test/test -n 1 -c ffff", "R.*T.*E.*>.*>", 60)
> out = self.dut.send_expect("lpm6_autotest", "RTE>>", 3600)
> self.dut.send_expect("quit", "# ")
> - self.dut.set_huge_pages(hugepage_ori)
> + if env == 'bsdapp':
> + pass
> + else:
> + self.dut.set_huge_pages(hugepage_ori)
> self.verify("Test OK" in out, "Test failed")
>
> def tear_down(self):
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dts] [PATCH V1 3/3] fix TestSuite unit_tests_mbuf on FreeBSD
2016-09-28 8:45 [dts] [PATCH V1 1/3] fix TestSuite coremask on FreeBSD xu,gang
2016-09-28 8:45 ` [dts] [PATCH V1 2/3] fix TestSuite unit_tests_lpm " xu,gang
@ 2016-09-28 8:45 ` xu,gang
2016-09-29 5:18 ` Liu, Yong
2016-09-29 5:26 ` [dts] [PATCH V1 1/3] fix TestSuite coremask " Liu, Yong
2 siblings, 1 reply; 6+ messages in thread
From: xu,gang @ 2016-09-28 8:45 UTC (permalink / raw)
To: dts; +Cc: xu,gang
wo need more time to running the command on FreeBSD
Signed-off-by: xu,gang <gangx.xu@intel.com>
---
tests/TestSuite_unit_tests_mbuf.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/TestSuite_unit_tests_mbuf.py b/tests/TestSuite_unit_tests_mbuf.py
index c4dfaab..7ff1f66 100644
--- a/tests/TestSuite_unit_tests_mbuf.py
+++ b/tests/TestSuite_unit_tests_mbuf.py
@@ -71,7 +71,7 @@ class TestUnitTestsMbuf(TestCase):
"""
self.dut.send_expect("./app/test/test -n 1 -c ffff", "R.*T.*E.*>.*>", 60)
- out = self.dut.send_expect("mbuf_autotest", "RTE>>", 60)
+ out = self.dut.send_expect("mbuf_autotest", "RTE>>", 120)
self.dut.send_expect("quit", "# ")
self.verify("Test OK" in out, "Test failed")
--
1.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dts] [PATCH V1 3/3] fix TestSuite unit_tests_mbuf on FreeBSD
2016-09-28 8:45 ` [dts] [PATCH V1 3/3] fix TestSuite unit_tests_mbuf " xu,gang
@ 2016-09-29 5:18 ` Liu, Yong
0 siblings, 0 replies; 6+ messages in thread
From: Liu, Yong @ 2016-09-29 5:18 UTC (permalink / raw)
To: Xu, GangX, dts; +Cc: Xu, GangX
Gang, mbuf autotest spent less than 10 seconds in my platform. Compare to 120 seconds, it's about twelve times.
Could you please check which function took much more time than linux OS?
This maybe one potential bug.
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang
> Sent: Wednesday, September 28, 2016 4:45 PM
> To: dts@dpdk.org
> Cc: Xu, GangX
> Subject: [dts] [PATCH V1 3/3] fix TestSuite unit_tests_mbuf on FreeBSD
>
> wo need more time to running the command on FreeBSD
>
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
> tests/TestSuite_unit_tests_mbuf.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_unit_tests_mbuf.py
> b/tests/TestSuite_unit_tests_mbuf.py
> index c4dfaab..7ff1f66 100644
> --- a/tests/TestSuite_unit_tests_mbuf.py
> +++ b/tests/TestSuite_unit_tests_mbuf.py
> @@ -71,7 +71,7 @@ class TestUnitTestsMbuf(TestCase):
> """
>
> self.dut.send_expect("./app/test/test -n 1 -c ffff",
> "R.*T.*E.*>.*>", 60)
> - out = self.dut.send_expect("mbuf_autotest", "RTE>>", 60)
> + out = self.dut.send_expect("mbuf_autotest", "RTE>>", 120)
> self.dut.send_expect("quit", "# ")
> self.verify("Test OK" in out, "Test failed")
>
> --
> 1.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dts] [PATCH V1 1/3] fix TestSuite coremask on FreeBSD
2016-09-28 8:45 [dts] [PATCH V1 1/3] fix TestSuite coremask on FreeBSD xu,gang
2016-09-28 8:45 ` [dts] [PATCH V1 2/3] fix TestSuite unit_tests_lpm " xu,gang
2016-09-28 8:45 ` [dts] [PATCH V1 3/3] fix TestSuite unit_tests_mbuf " xu,gang
@ 2016-09-29 5:26 ` Liu, Yong
2 siblings, 0 replies; 6+ messages in thread
From: Liu, Yong @ 2016-09-29 5:26 UTC (permalink / raw)
To: xu,gang, dts
Applied. Since these three patches have no dependencies on each other,
please not bind them into one patch set.
I can merge them separately and you do not need to rework all patches.
On 09/28/2016 04:45 PM, xu,gang wrote:
> delete space in command in order to implementation copy StDErr to StDput
>
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
> tests/TestSuite_coremask.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_coremask.py b/tests/TestSuite_coremask.py
> index 2458d8f..d93e07a 100644
> --- a/tests/TestSuite_coremask.py
> +++ b/tests/TestSuite_coremask.py
> @@ -104,7 +104,7 @@ class TestCoremask(TestCase):
> Check coremask parsing for more cores than available.
> """
>
> - command_line = """./%s/app/test -c %s -n %d --log-level 8 2 > &1 |tee out"""
> + command_line = """./%s/app/test -c %s -n %d --log-level 8 2>&1 |tee out"""
>
> # Default big coremask value 128
> big_coremask_size = 128
^ permalink raw reply [flat|nested] 6+ messages in thread