From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id A7B1B378E for ; Thu, 29 Sep 2016 10:36:34 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP; 29 Sep 2016 01:36:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,414,1470726000"; d="scan'208";a="885002075" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga003.jf.intel.com with ESMTP; 29 Sep 2016 01:36:34 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 29 Sep 2016 01:36:28 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.234]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.95]) with mapi id 14.03.0248.002; Thu, 29 Sep 2016 16:36:19 +0800 From: "Liu, Yong" To: "Xu, HuilongX" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH V1] fix lpm ipv6 unit case on 1G hugepage machine Thread-Index: AQHSE8jLKDL0IpuwpEW+uklle7IABaCQE2uA//+Cy4CAAJmAEA== Date: Thu, 29 Sep 2016 08:36:18 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E602E2E9C@SHSMSX103.ccr.corp.intel.com> References: <1474435711-23476-1-git-send-email-huilongx.xu@intel.com> <57ECB941.7030107@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDM5MmNhZmUtNTQ1ZC00ODNlLWFjMDEtZDBkYWZlNTk3Njc1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik9mU29vK1NQVG1mN0Z4eG5tTW5ORlUzOFlyd2VEQkxqUGxwY0R6UlBmOWc9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] fix lpm ipv6 unit case on 1G hugepage machine X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Sep 2016 08:36:35 -0000 Huilong, case execution should be blocked. You can skip hugepage operation = based on gang's patch which has been merged. > -----Original Message----- > From: Xu, HuilongX > Sent: Thursday, September 29, 2016 3:20 PM > To: Liu, Yong; dts@dpdk.org > Subject: RE: [dts] [PATCH V1] fix lpm ipv6 unit case on 1G hugepage > machine >=20 > Yes, > Set hugepage will failed in FreeBSD, but not influence the case exec in > FreeBSD. > I think maybe we can rework hugepage config on dts framework next time. > Thanks a lot >=20 > > -----Original Message----- > > From: Liu, Yong > > Sent: Thursday, September 29, 2016 2:49 PM > > To: Xu, HuilongX; dts@dpdk.org > > Subject: Re: [dts] [PATCH V1] fix lpm ipv6 unit case on 1G hugepage > > machine > > > > > > > > On 09/21/2016 01:28 PM, xu,huilong wrote: > > > Signed-off-by: xu,huilong > > > --- > > > tests/TestSuite_unit_tests_lpm.py | 15 ++++++++++----- > > > 1 file changed, 10 insertions(+), 5 deletions(-) > > > > > > diff --git a/tests/TestSuite_unit_tests_lpm.py > > b/tests/TestSuite_unit_tests_lpm.py > > > index dadb492..7394d19 100644 > > > --- a/tests/TestSuite_unit_tests_lpm.py > > > +++ b/tests/TestSuite_unit_tests_lpm.py > > > @@ -83,11 +83,16 @@ class TestUnitTestsLpmIpv6(TestCase): > > > """ > > > [arch, machine, env, toolchain] =3D self.target.split('-') > > > self.verify(arch =3D=3D "x86_64", "lpm6 request huge memory= ") > > > - > > > - hugepage_ori =3D self.dut.get_total_huge_pages() > > > - self.dut.set_huge_pages(4096) > > > - hugepage_num =3D self.dut.get_total_huge_pages() > > > - self.verify(hugepage_num >=3D 4096, "failed to request huge > > memory") > > > + # lpm ipv6 should leaest 8g huge page > > > + min_hugepagesz =3D 8 * 1024 * 1024 > > > + > > > + hugepage_ori =3D int(self.dut.get_total_huge_pages()) > > > + hugepages_size =3D int(self.dut.send_expect("awk > > '/Hugepagesize/ {print $2}' /proc/meminfo", "# ")) > > > + Convert messy string into integer will raise exception, case execution will= be blocked here. > > This command can't work on FreeBSD. Again, it's better to let framework > > handle huge allocation/destroy. > > It's hard to each suite handle the difference for distributions. > > > > > + if (hugepages_size * hugepage_ori < min_hugepagesz): > > > + self.dut.set_huge_pages(min_hugepagesz / hugepages_size) > > > + hugepage_num =3D self.dut.get_total_huge_pages() > > > + self.verify(hugepage_num =3D=3D min_hugepagesz / > > hugepages_size, "failed to request huge memory") > > > > > > self.dut.send_expect("./app/test/test -n 1 -c ffff", > > "R.*T.*E.*>.*>", 60) > > > out =3D self.dut.send_expect("lpm6_autotest", "RTE>>", 3600= )