test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Xu, HuilongX" <huilongx.xu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xu, HuilongX" <huilongx.xu@intel.com>
Subject: Re: [dts] [PATCH V1 2/3] update vxlan ipv4/ipv6 packet detect packet	type info
Date: Fri, 18 Nov 2016 03:11:18 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E6032B5EE@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1479438482-4875-2-git-send-email-huilongx.xu@intel.com>



> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong
> Sent: Friday, November 18, 2016 11:08 AM
> To: dts@dpdk.org
> Cc: Xu, HuilongX
> Subject: [dts] [PATCH V1 2/3] update vxlan ipv4/ipv6 packet detect packet
> type info
> 
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> ---
>  tests/TestSuite_nvgre.py | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/TestSuite_nvgre.py b/tests/TestSuite_nvgre.py
> index c1df309..015aa9f 100644
> --- a/tests/TestSuite_nvgre.py
> +++ b/tests/TestSuite_nvgre.py
> @@ -164,14 +164,14 @@ class NvgreTestConfig(object):
>          """
>          if self.outer_ip_proto != 47:
>              if self.outer_l3_type == 'IPv4':
> -                return '(outer) L3 type: IPV4_EXT_UNKNOWN'
> +                return 'L3_IPV4_EXT_UNKNOWN'

If outer and inner packet layer use same string, we can't distinguish between them.
What cause the output message change?

>              else:
> -                return '(outer) L3 type: IPV6_EXT_UNKNOWN'
> +                return 'L3_IPV6_EXT_UNKNOWN'
>          else:
>              if self.inner_l3_type == 'IPv4':
> -                return 'Inner L3 type: IPV4_EXT_UNKNOWN'
> +                return 'L3_IPV4_EXT_UNKNOWN'
>              else:
> -                return 'Inner L3 type: IPV6_EXT_UNKNOWN'
> +                return 'L3_IPV6_EXT_UNKNOWN'
> 
>      def create_pcap(self):
>          """
> --
> 1.9.3

  reply	other threads:[~2016-11-18  3:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-18  3:08 [dts] [PATCH V1 1/3] " xu,huilong
2016-11-18  3:08 ` [dts] [PATCH V1 2/3] " xu,huilong
2016-11-18  3:11   ` Liu, Yong [this message]
2016-11-18  3:16     ` Xu, HuilongX
2016-11-22  9:16       ` Liu, Yong
2016-11-18  3:08 ` [dts] [PATCH V1 3/3] update all packet type info for fortville and niantic nic xu,huilong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E6032B5EE@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=huilongx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).