Re: [dts] [PATCH V1] add test suite l2fwd-jobstats

["Liu, Yong" <yong.liu@intel.com>]

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang
> Sent: Friday, November 18, 2016 10:59 AM
> To: dts@dpdk.org
> Cc: Xu, GangX
> Subject: [dts] [PATCH V1] add test suite l2fwd-jobstats
> 
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>  test_plans/l2fwd-jobstats_test_plan.rst |  84 +++++++++++++++++++++++
>  tests/TestSuite_l2fwd-jobstats.py       | 115
> ++++++++++++++++++++++++++++++++
>  2 files changed, 199 insertions(+)
>  create mode 100644 test_plans/l2fwd-jobstats_test_plan.rst
>  create mode 100644 tests/TestSuite_l2fwd-jobstats.py
> 
> diff --git a/test_plans/l2fwd-jobstats_test_plan.rst b/test_plans/l2fwd-
> jobstats_test_plan.rst
> new file mode 100644
> index 0000000..d61a9e7
> --- /dev/null
> +++ b/test_plans/l2fwd-jobstats_test_plan.rst
> @@ -0,0 +1,84 @@
> +..  BSD LICENSE
> +    Copyright(c) 2010-2015 Intel Corporation. All rights reserved.
> +    All rights reserved.
> +
> +    Redistribution and use in source and binary forms, with or without
> +    modification, are permitted provided that the following conditions
> +    are met:
> +
> +    * Redistributions of source code must retain the above copyright
> +    notice, this list of conditions and the following disclaimer.
> +    * Redistributions in binary form must reproduce the above copyright
> +    notice, this list of conditions and the following disclaimer in
> +    the documentation and/or other materials provided with the
> +    distribution.
> +    * Neither the name of Intel Corporation nor the names of its
> +    contributors may be used to endorse or promote products derived
> +    from this software without specific prior written permission.
> +
> +    THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> +    "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> +    LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
> +    A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
> +    OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
> +    SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> +    LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> +    DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> +    THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> +    (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> +    OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> +
> +L2 Forwarding Sample Application (in Real and Virtualized Environments)
> with core load statistics.
> +=========================================================================
> =========================
> +
> +The L2 Forwarding sample application is a simple example of packet
> processing using
> +the Data Plane Development Kit (DPDK) which
> +also takes advantage of Single Root I/O Virtualization (SR-IOV) features
> in a virtualized environment.

Jobstats seem not related to SR-IOV,  you need to describe what's the usage of job stats library. 

> +
> +.. note::
> +
> +    This application is a variation of L2 Forwarding sample application.
> It demonstrate possible
> +    scheme of job stats library usage therefore some parts of this
> document is identical with original
> +    L2 forwarding application.
> +
> +Overview
> +--------
> +
> +The L2 Forwarding sample application, which can operate in real and
> virtualized environments,
> +performs L2 forwarding for each packet that is received.
> +The destination port is the adjacent port from the enabled portmask, that
> is,
> +if the first four ports are enabled (portmask 0xf),
> +ports 1 and 2 forward into each other, and ports 3 and 4 forward into
> each other.
> +Also, the MAC addresses are affected as follows:
> +
> +*   The source MAC address is replaced by the TX port MAC address
> +
> +*   The destination MAC address is replaced by  02:00:00:00:00:TX_PORT_ID
> +
> +Running the Application
> +-----------------------
> +
> +The application requires a number of command line options:
> +
> +.. code-block:: console
> +
> +    ./build/l2fwd-jobstats [EAL options] -- -p PORTMASK [-q NQ] [-l]
> +
> +where,
> +
> +*   p PORTMASK: A hexadecimal bitmask of the ports to configure
> +
> +*   q NQ: A number of queues (=ports) per lcore (default is 1)
> +
> +*   l: Use locale thousands separator when formatting big numbers.
> +
> +To run the application in linuxapp environment with 4 lcores, 16 ports, 8
> RX queues per lcore and
> +thousands  separator printing, issue the command:
> +
> +.. code-block:: console
> +
> +    $ ./build/l2fwd-jobstats -c f -n 4 -- -q 8 -p ffff -l
> +
> +Refer to the *DPDK Getting Started Guide* for general information on
> running applications
> +and the Environment Abstraction Layer (EAL) options.
> +
> diff --git a/tests/TestSuite_l2fwd-jobstats.py b/tests/TestSuite_l2fwd-
> jobstats.py
> new file mode 100644
> index 0000000..493c507
> --- /dev/null
> +++ b/tests/TestSuite_l2fwd-jobstats.py
> @@ -0,0 +1,115 @@
> +#BSD LICENSE
> +#
> +# Copyright(c) 2010-2016 Intel Corporation. All rights reserved.
> +# All rights reserved.
> +#
> +# Redistribution and use in source and binary forms, with or without
> +# modification, are permitted provided that the following conditions
> +# are met:
> +#
> +#   * Redistributions of source code must retain the above copyright
> +#     notice, this list of conditions and the following disclaimer.
> +#   * Redistributions in binary form must reproduce the above copyright
> +#     notice, this list of conditions and the following disclaimer in
> +#     the documentation and/or other materials provided with the
> +#     distribution.
> +#   * Neither the name of Intel Corporation nor the names of its
> +#     contributors may be used to endorse or promote products derived
> +#     from this software without specific prior written permission.
> +#
> +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
> +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
> +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
> +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> +
> +
> +"""
> +DPDK Test suite.
> +Test l2fwd-jobstats
> +"""
> +
> +import dts
Please remove dts dependency. 

> +import string
> +import time
> +import re
> +import utils
> +from test_case import TestCase
> +from plotting import Plotting
> +from settings import HEADER_SIZE
> +from etgen import IxiaPacketGenerator
> +from packet import Packet, sniff_packets, load_sniff_packets
> +
> +class TestL2fwdJobstats(TestCase):
> +
> +    def set_up_all(self):
> +        """
> +        Run at the start of each test suite.
> +        """
> +
> +        self.dut_ports = self.dut.get_ports(self.nic)
> +        self.verify(len(self.dut_ports) >= 2, "Insufficient ports")
> +        cores = self.dut.get_core_list("1S/4C/1T")
> +        self.coremask = utils.create_mask(cores)
> +        self.portmask = utils.create_mask(self.dut_ports)
> +        self.path = "./examples/l2fwd-jobstats/build/l2fwd-jobstats"
> +
> +        # build sample app
> +        out = self.dut.build_dpdk_apps("./examples/l2fwd-jobstats")
> +        self.verify("Error" not in out, "compilation error 1")
> +        self.verify("No such file" not in out, "compilation error 2")
> +
> +    def set_up(self):
> +        """
> +        Run before each test case.
> +        """
> +        pass
> +
> +    def test_l2fwd_jobstats(self):
> +        """
> +        Verify netmap compatibility with one port
> +        """
> +        cmd = self.path + " -c %s -n %d -- -q 8 -p %s -l" %
> (self.coremask, self.dut.get_memory_channels(), self.portmask)
> +
> +        #start netmap_compat with one port
> +        self.dut.send_expect(cmd,"Port statistics",60)
> +
> +        self.scapy_send_packet()
> +        out = self.dut.get_session_output(timeout=10)
> +        p = re.compile(r'\d+')
> +        result = p.findall(out)
> +        amount = 100 * len(self.dut_ports)
> +        self.verify(str(amount) in result, "Wrong: can't get <%s>
> package")
> +
> +    def scapy_send_packet(self):

Please replace scapy command with send_pkt function in framework/packet.py.

> +        """
> +        Send a packet to port
> +        """
> +        for i in range(len(self.dut_ports)):
> +            txport = self.tester.get_local_port(self.dut_ports[i])
> +            mac = self.dut.get_mac_address(self.dut_ports[i])
> +            txItf = self.tester.get_interface(txport)
> +
> self.tester.scapy_append('sendp([Ether(dst="%s")/IP()/UDP()/Raw(\'X\'*18)],
> iface="%s",count=100)' % (mac, txItf))
> +            self.tester.scapy_execute()
> 
> +
> +    def tear_down(self):
> +        """
> +        Run after each test case.
> +        """
> +        self.dut.kill_all()
> +        time.sleep(2)
> +        pass
> +
> +    def tear_down_all(self):
> +        """
> +        Run after each test suite.
> +        """
> +        pass
> +
> --
> 1.9.3