From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id B32DA37B2 for ; Fri, 18 Nov 2016 04:49:09 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP; 17 Nov 2016 19:49:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,655,1473145200"; d="scan'208";a="1086908457" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga002.fm.intel.com with ESMTP; 17 Nov 2016 19:49:08 -0800 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 17 Nov 2016 19:49:07 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 17 Nov 2016 19:49:07 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.96]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.239]) with mapi id 14.03.0248.002; Fri, 18 Nov 2016 11:49:05 +0800 From: "Liu, Yong" To: "Xu, GangX" , "dts@dpdk.org" CC: "Xu, GangX" Thread-Topic: [dts] [PATCH V1] add test suite hotplug Thread-Index: AQHSQUqcDeKaPdGXJUqFBK4u8c1YIaDeGRfQ Date: Fri, 18 Nov 2016 03:49:04 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E6032B739@SHSMSX103.ccr.corp.intel.com> References: <1479439238-5259-1-git-send-email-gangx.xu@intel.com> In-Reply-To: <1479439238-5259-1-git-send-email-gangx.xu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjEyNjg0YzYtMDVhNy00Y2ExLWFlOWMtZWRjZWNlMDYxZWY2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlhVOThmUEpYMTRPRVwvVllWTFpvWjBPK0xiSXcrVWxXWng5NDNuMFdTRE1BPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] add test suite hotplug X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2016 03:49:10 -0000 Gang, some comments below. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang > Sent: Friday, November 18, 2016 11:21 AM > To: dts@dpdk.org > Cc: Xu, GangX > Subject: [dts] [PATCH V1] add test suite hotplug >=20 > Signed-off-by: xu,gang > --- > tests/TestSuite_hotplug.py | 141 > +++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 141 insertions(+) > create mode 100644 tests/TestSuite_hotplug.py >=20 > diff --git a/tests/TestSuite_hotplug.py b/tests/TestSuite_hotplug.py > new file mode 100644 > index 0000000..277fc7a > --- /dev/null > +++ b/tests/TestSuite_hotplug.py > @@ -0,0 +1,141 @@ > +#BSD LICENSE > +# > +# Copyright(c) 2010-2016 Intel Corporation. All rights reserved. > +# All rights reserved. > +# > +# Redistribution and use in source and binary forms, with or without > +# modification, are permitted provided that the following conditions > +# are met: > +# > +# * Redistributions of source code must retain the above copyright > +# notice, this list of conditions and the following disclaimer. > +# * Redistributions in binary form must reproduce the above copyright > +# notice, this list of conditions and the following disclaimer in > +# the documentation and/or other materials provided with the > +# distribution. > +# * Neither the name of Intel Corporation nor the names of its > +# contributors may be used to endorse or promote products derived > +# from this software without specific prior written permission. > +# > +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR > +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT > +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, > +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > + > + > +""" > +DPDK Test suite. > +Test port hot plug. > +""" > + > +import dts Please remove this module dependency.=20 > +import string > +import time > +import re > +import utils > +from test_case import TestCase > +from plotting import Plotting > +from settings import HEADER_SIZE > +from etgen import IxiaPacketGenerator > +from packet import Packet, sniff_packets, load_sniff_packets > + > +class TestPortHotPlug(TestCase): > + """ > + This feature only supports igb_uio now and not support freebsd > + """ > + def set_up_all(self): > + """ > + Run at the start of each test suite. > + """ > + > + self.dut_ports =3D self.dut.get_ports(self.nic) > + self.verify(len(self.dut_ports) >=3D 2, "Insufficient ports") > + cores =3D self.dut.get_core_list("1S/4C/1T") > + self.coremask =3D utils.create_mask(cores) > + self.port =3D len(self.dut_ports) - 1 Need blank line here.=20 > + def set_up(self): > + """ > + Run before each test case. > + """ > + self.dut.send_expect("./tools/dpdk-devbind.py -u %s" % > self.dut.ports_info[self.port]['pci'],"#",60) > + > + def attach(self, port): Please add some comments for this function. > + self.dut.send_expect("port attach %s" % > self.dut.ports_info[port]['pci'],"is attached",60) > + self.dut.send_expect("port start %s" % port,"Link Up",60) > + self.dut.send_expect("show port info %s" % port,"testpmd>",60) > + > + def detach(self, port): Please add some comments for this function. > + self.dut.send_expect("port stop %s" % port,"Link Down",60) > + self.dut.send_expect("port close %s" % port,"Closing ports...",6= 0) > + self.dut.send_expect("port detach %s" % port,"is detached",60) > + > + def test_after_attach(self): Please add some comments for this function. Like what's testing and what's = the expect result. > + cmd =3D "./x86_64-native-linuxapp-gcc/app/testpmd -c %s -n %s --= - > i" % (self.coremask,self.dut.get_memory_channels()) > + self.dut.send_expect(cmd,"testpmd>",60) > + session_secondary =3D self.dut.new_session() > + session_secondary.send_expect("./tools/dpdk-devbind.py -- > bind=3Digb_uio %s" % self.dut.ports_info[self.port]['pci'], "#", 60) > + self.attach(self.port) > + self.dut.send_expect("start","testpmd>",60) > + self.dut.send_expect("port detach %s" % self.port,"Please close > port first",60) > + self.dut.send_expect("stop","testpmd>",60) > + self.detach(self.port) > + self.attach(self.port) > + > + self.dut.send_expect("start","testpmd>",60) > + self.dut.send_expect("port detach %s" % self.port,"Please close > port first",60) > + self.send_packe(self.port) > + out =3D self.dut.send_expect("show port stats %s" % > self.port ,"testpmd>",60) > + print out > + packet =3D re.search("RX-packets:\s*(\d*)",out) > + sum_packet =3D packet.group(1) > + self.verify(sum_packet >=3D 100, "Insufficient the received > package") > + self.dut.send_expect("quit","#",60) > + > + def send_packe(self, port): This maybe typo, should be send_packe.=20 > + txport =3D self.tester.get_local_port(self.dut_ports[port]) > + txItf =3D self.tester.get_interface(txport) > + mac =3D self.dut.ports_info[port]['mac'] > + > self.tester.scapy_append('sendp([Ether(dst=3D"%s")/IP()/UDP()/Raw(\'X\'*1= 8)], > iface=3D"%s",count=3D100)' % (mac,txItf)) > + self.tester.scapy_execute() Please use send_packet function in packet module. > + > + def test_before_attach(self): > + session_secondary =3D self.dut.new_session() > + session_secondary.send_expect("./tools/dpdk-devbind.py -- > bind=3Digb_uio %s" % self.dut.ports_info[self.port]['pci'], "#", 60) > + > + cmd =3D "./x86_64-native-linuxapp-gcc/app/testpmd -c %s -n %s --= - > i" % (self.coremask,self.dut.get_memory_channels()) > + self.dut.send_expect(cmd,"testpmd>",60) > + self.detach(self.port) > + self.attach(self.port) > + self.dut.send_expect("start","testpmd>",60) > + self.dut.send_expect("port detach %s" % self.port, "Please close > port first",60) > + self.send_packe(self.port) > + out =3D self.dut.send_expect("show port stats %s" % > self.port ,"testpmd>",60) > + print out > + packet =3D re.search("RX-packets:\s*(\d*)",out) > + sum_packet =3D packet.group(1) > + self.verify(sum_packet >=3D 100, "Insufficient the received > package") > + self.dut.send_expect("quit","#",60) > + > + > + def tear_down(self): > + """ > + Run after each test case. > + """ > + self.dut.send_expect("./tools/dpdk-devbind.py --bind=3Digb_uio %= s" % > self.dut.ports_info[self.port]['pci'],"#",60) Need bind back to self.drivername which may be changed to vfio-pci or uio_p= ci_generic.=20 > + self.dut.kill_all() > + time.sleep(2) > + > + > + def tear_down_all(self): > + """ > + Run after each test suite. > + """ > + pass > + > -- > 1.9.3