From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 5FA80F72 for ; Fri, 18 Nov 2016 09:19:50 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 18 Nov 2016 00:19:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,656,1473145200"; d="scan'208";a="787913004" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 18 Nov 2016 00:19:48 -0800 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 18 Nov 2016 00:19:48 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 18 Nov 2016 00:19:48 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.96]) by shsmsx102.ccr.corp.intel.com ([169.254.2.239]) with mapi id 14.03.0248.002; Fri, 18 Nov 2016 16:19:44 +0800 From: "Liu, Yong" To: "Tu, LijuanX A" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH v1]vf_packet_rxtx: optimize test case Thread-Index: AQHSPwZvSm4No7bI506LXTJuYLCEdaDeOEnggAANwnCAAAwD0A== Date: Fri, 18 Nov 2016 08:19:44 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E6032BAB2@SHSMSX103.ccr.corp.intel.com> References: <1479190026-22844-1-git-send-email-lijuanx.a.tu@intel.com> <86228AFD5BCD8E4EBFD2B90117B5E81E6032B7BD@SHSMSX103.ccr.corp.intel.com> <38D041F150D4184C8114E499040E62343D1996C3@shsmsx102.ccr.corp.intel.com> In-Reply-To: <38D041F150D4184C8114E499040E62343D1996C3@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTYzYzlkZWUtODU0YS00YWVlLWJhMmEtODYwN2E3MmQ4MTEyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjZtSEpGOU9tVUxLWXlIXC9RMU5YRzRub0xPZFwvMEd0Y3FSaFNlMkl0Q3dtUT0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH v1]vf_packet_rxtx: optimize test case X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2016 08:19:51 -0000 Thanks for clear, please add these information in git log. We can keep on t= racking crc discussion. > -----Original Message----- > From: Tu, LijuanX A > Sent: Friday, November 18, 2016 2:35 PM > To: Liu, Yong; dts@dpdk.org > Subject: RE: [dts] [PATCH v1]vf_packet_rxtx: optimize test case >=20 > 1, all nic should enable vf crc-strip ,not just forville, for HW not > support > 2, enable pf (igb_uio) crc-strip (DPDK-1755) > To make share pf & vf behavior the same > 3, fix grammatical error >=20 > > -----Original Message----- > > From: Liu, Yong > > Sent: Friday, November 18, 2016 1:21 PM > > To: Tu, LijuanX A; dts@dpdk.org > > Cc: Tu, LijuanX A > > Subject: RE: [dts] [PATCH v1]vf_packet_rxtx: optimize test case > > > > Lijuan, few comments. > > > > > -----Original Message----- > > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Lijuan Tu > > > Sent: Tuesday, November 15, 2016 2:07 PM > > > To: dts@dpdk.org > > > Cc: Tu, LijuanX A > > > Subject: [dts] [PATCH v1]vf_packet_rxtx: optimize test case > > > > > > Signed-off-by: Lijuan Tu > > > --- > > > tests/TestSuite_vf_packet_rxtx.py | 47 > > > ++++++++++++++++------------------ > > > ----- > > > 1 file changed, 19 insertions(+), 28 deletions(-) > > > > > > diff --git a/tests/TestSuite_vf_packet_rxtx.py > > > b/tests/TestSuite_vf_packet_rxtx.py > > > index 25b03eb..62d3a3c 100644 > > > --- a/tests/TestSuite_vf_packet_rxtx.py > > > +++ b/tests/TestSuite_vf_packet_rxtx.py > > > @@ -46,12 +46,13 @@ class TestVfPacketRxtx(TestCase): > > > vf0_prop =3D {'opt_host': self.sriov_vfs_port_0[0].pci} > > > vf1_prop =3D {'opt_host': self.sriov_vfs_port_1[0].pci} > > > > > > + > > > if driver =3D=3D 'igb_uio': > > > # start testpmd without the two VFs on the host > > > self.host_testpmd =3D PmdOutput(self.dut) > > > eal_param =3D '-b %(vf0)s -b %(vf1)s' % {'vf0': > > > self.sriov_vfs_port_0[0].pci, > > > 'vf1': > > > self.sriov_vfs_port_1[0].pci} > > > - self.host_testpmd.start_testpmd("1S/2C/2T", > > > eal_param=3Deal_param) > > > + self.host_testpmd.start_testpmd("1S/2C/2T", > > > + "--crc-strip", > > > eal_param=3Deal_param) > > > > > > # set up VM0 ENV > > > self.vm0 =3D QEMUKvm(self.dut, 'vm0', 'vf_packet_rxtx')= @@ > > > -69,9 +70,10 @@ class TestVfPacketRxtx(TestCase): > > > def destroy_2pf_2vf_1vm_env(self): > > > if getattr(self, 'vm0', None): > > > #destroy testpmd in vm0 > > > - self.vm0_testpmd.execute_cmd('stop') > > > - self.vm0_testpmd.execute_cmd('quit', '# ') > > > - self.vm0_testpmd =3D None > > > + if getattr(self, 'vm0_testpmd', None): > > > + self.vm0_testpmd.execute_cmd('stop') > > > + self.vm0_testpmd.execute_cmd('quit', '# ') > > > + self.vm0_testpmd =3D None > > > self.vm0_dut_ports =3D None > > > #destroy vm0 > > > self.vm0.stop() > > > @@ -81,13 +83,13 @@ class TestVfPacketRxtx(TestCase): > > > self.host_testpmd.execute_cmd('quit', '# ') > > > self.host_testpmd =3D None > > > > > > - if getattr(self, 'used_dut_port_0', None): > > > + if getattr(self, 'used_dut_port_0', None) !=3D None: > > Look like nothing changed, why changed it? > [lijuan] X =3D getattr(self, 'used_dut_port_0', None) > Here : used_dut_port_0 =3D=3D 0 ,so X =3D=3D 0 , > So judgment is False, but actual it's true, we hope it will destroy > vfs. > The judgment is want to check whether used_dut_port_0 defined .if > not defined ,we will not destroy vfs. > > > > > self.dut.destroy_sriov_vfs_by_port(self.used_dut_port_0= ) > > > port =3D self.dut.ports_info[self.used_dut_port_0]['por= t'] > > > port.bind_driver() > > > self.used_dut_port_0 =3D None > > > > > > - if getattr(self, 'used_dut_port_1', None): > > > + if getattr(self, 'used_dut_port_1', None) !=3D None: > > > self.dut.destroy_sriov_vfs_by_port(self.used_dut_port_1= ) > > > port =3D self.dut.ports_info[self.used_dut_port_1]['por= t'] > > > port.bind_driver() > > > @@ -110,14 +112,7 @@ class TestVfPacketRxtx(TestCase): > > > self.vm0_dut_ports =3D self.vm_dut_0.get_ports('any') > > > port_id_0 =3D 0 > > > self.vm0_testpmd =3D PmdOutput(self.vm_dut_0) > > > - if self.kdriver =3D=3D "i40e": > > > - self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '--crc- > strip') > > > - else: > > > - self.vm0_testpmd.start_testpmd(VM_CORES_MASK) > > > - self.vm0_testpmd.execute_cmd('port stop all') > > > - self.vm0_testpmd.execute_cmd('port config all crc-strip on'= ) > > > - self.vm0_testpmd.execute_cmd('port start all') > > > - self.vm0_testpmd.execute_cmd('show port info all') > > > + self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '--crc-strip'= ) > > Please give some comment of this change, why other NICs now support > crc-strip > > by testpmd parameter? > [lijuan] Nics (Niantic fortivlle sageville powerville) all can't disable > crc-strip, but fortiville deal it as error , and other as warning. > Dpdk disable crc-strip as default. But how to deal with crc-strip is stil= l > in discussing. > Refer: http://dpdk.org/dev/patchwork/patch/16980/ > > > > > pmd_vf0_mac =3D self.vm0_testpmd.get_port_mac(port_id_0) > > > self.vm0_testpmd.execute_cmd('set fwd mac') > > > self.vm0_testpmd.execute_cmd('start') > > > @@ -199,8 +194,9 @@ class TestVfPacketRxtx(TestCase): > > > > > > def destroy_3vf_2vm_env(self): > > > if getattr(self, 'vm0', None): > > > - self.vm0_testpmd.execute_cmd('stop') > > > - self.vm0_testpmd.execute_cmd('quit', '# ') > > > + if getattr(self, 'vm0_testpmd', None): > > > + self.vm0_testpmd.execute_cmd('stop') > > > + self.vm0_testpmd.execute_cmd('quit', '# ') > > > self.vm0_testpmd =3D None > > > self.vm0_dut_ports =3D None > > > self.vm_dut_0 =3D None > > > @@ -208,19 +204,20 @@ class TestVfPacketRxtx(TestCase): > > > self.vm0 =3D None > > > > > > if getattr(self, 'vm1', None): > > > - self.vm1_testpmd.execute_cmd('stop') > > > - self.vm1_testpmd.execute_cmd('quit', '# ') > > > + if getattr(self, 'vm1_testpmd', None): > > > + self.vm1_testpmd.execute_cmd('stop') > > > + self.vm1_testpmd.execute_cmd('quit', '# ') > > > self.vm1_testpmd =3D None > > > self.vm1_dut_ports =3D None > > > self.vm_dut_1 =3D None > > > self.vm1.stop() > > > self.vm1 =3D None > > > > > > - if getattr(self, 'host_testpmd', None): > > > + if getattr(self, 'host_testpmd', None) !=3D None: > > > self.host_testpmd.execute_cmd('quit', '# ') > > > self.host_testpmd =3D None > > > > > > - if getattr(self, 'used_dut_port', None): > > > + if getattr(self, 'used_dut_port', None) !=3D None: > > > self.dut.destroy_sriov_vfs_by_port(self.used_dut_port) > > > port =3D self.dut.ports_info[self.used_dut_port]['port'= ] > > > port.bind_driver() > > > @@ -243,10 +240,7 @@ class TestVfPacketRxtx(TestCase): > > > port_id_1 =3D 1 > > > > > > self.vm0_testpmd =3D PmdOutput(self.vm_dut_0) > > > - if self.kdriver =3D=3D "i40e": > > > - self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '--crc- > strip') > > > - else: > > > - self.vm0_testpmd.start_testpmd(VM_CORES_MASK) > > > + self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '--crc-strip'= ) > > > self.vm0_testpmd.execute_cmd('show port info all') > > > pmd0_vf0_mac =3D self.vm0_testpmd.get_port_mac(port_id_0) > > > self.vm0_testpmd.execute_cmd('set fwd mac') @@ -255,10 > +249,7 > > > @@ class TestVfPacketRxtx(TestCase): > > > time.sleep(2) > > > > > > self.vm1_testpmd =3D PmdOutput(self.vm_dut_1) > > > - if self.kdriver =3D=3D "i40e": > > > - self.vm1_testpmd.start_testpmd(VM_CORES_MASK, '--crc- > strip') > > > - else: > > > - self.vm1_testpmd.start_testpmd(VM_CORES_MASK) > > > + self.vm1_testpmd.start_testpmd(VM_CORES_MASK, '--crc-strip'= ) > > > self.vm1_testpmd.execute_cmd('show port info all') > > > > > > tx_port =3D self.tester.get_local_port(self.dut_ports[0]) > > > -- > > > 1.9.3