test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Xu, GangX" <gangx.xu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xu, GangX" <gangx.xu@intel.com>
Subject: Re: [dts] [PATCH V2]  fix IndexError on FreeBSD
Date: Tue, 29 Nov 2016 09:01:51 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E603326FA@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1480385007-19394-1-git-send-email-gangx.xu@intel.com>

Gang, 
Unbind driver is critical step in execution process. This action must be monitored and called properly.
NIC method "get_interface_name" maybe called in suite, if that will cause all later suites crashed.
My suggestion is that remove interface/mac/ipv6 address strip code in function "scan_ports_uncached_freebsd". 
All those information should be available in function "rescan_ports_uncached_freebsd".


> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang
> Sent: Tuesday, November 29, 2016 10:03 AM
> To: dts@dpdk.org
> Cc: Xu, GangX
> Subject: [dts] [PATCH V2] fix IndexError on FreeBSD
> 
> restore interface before get interface
> 
> 
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>  nics/net_device.py | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/nics/net_device.py b/nics/net_device.py
> index bbe4bed..0eac48d 100644
> --- a/nics/net_device.py
> +++ b/nics/net_device.py
> @@ -218,7 +218,11 @@ class NetDevice(object):
>          """
>          Get the interface name by the default way on freebsd.
>          """
> -        pci_str = "%s:%s:%s" % (domain_id, bus_id, devfun_id)
> +        pci_str = "%s:%s:%s" % (domain_id, bus_id, devfun_id)
> +        put = self.__send_expect("kldstat", "# ",20)
> +        if "nic_uio.ko" in put:
> +            self.__send_expect("kldunload contigmem.ko", "# ",20)
> +            self.__send_expect("kldunload nic_uio.ko", "# ",20)
>          out = self.__send_expect("pciconf -l", "# ")
>          rexp = r"(\w*)@pci0:%s" % pci_str
>          pattern = re.compile(rexp)
> --
> 1.9.3

      reply	other threads:[~2016-11-29  9:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-29  2:03 xu,gang
2016-11-29  9:01 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E603326FA@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=gangx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).