[dts] [PATCH V2] fix IndexError on FreeBSD

[dts] [PATCH V2] fix IndexError on FreeBSD

[xu,gang]

restore interface before get interface  


Signed-off-by: xu,gang <gangx.xu@intel.com>
---
 nics/net_device.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/nics/net_device.py b/nics/net_device.py
index bbe4bed..0eac48d 100644
--- a/nics/net_device.py
+++ b/nics/net_device.py
@@ -218,7 +218,11 @@ class NetDevice(object):
         """
         Get the interface name by the default way on freebsd.
         """
-        pci_str = "%s:%s:%s" % (domain_id, bus_id, devfun_id) 
+        pci_str = "%s:%s:%s" % (domain_id, bus_id, devfun_id)
+        put = self.__send_expect("kldstat", "# ",20)
+        if "nic_uio.ko" in put:
+            self.__send_expect("kldunload contigmem.ko", "# ",20)
+            self.__send_expect("kldunload nic_uio.ko", "# ",20)
         out = self.__send_expect("pciconf -l", "# ")
         rexp = r"(\w*)@pci0:%s" % pci_str
         pattern = re.compile(rexp)
-- 
1.9.3

Re: [dts] [PATCH V2] fix IndexError on FreeBSD

[Liu, Yong]

Gang, 
Unbind driver is critical step in execution process. This action must be monitored and called properly.
NIC method "get_interface_name" maybe called in suite, if that will cause all later suites crashed.
My suggestion is that remove interface/mac/ipv6 address strip code in function "scan_ports_uncached_freebsd". 
All those information should be available in function "rescan_ports_uncached_freebsd".


> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang
> Sent: Tuesday, November 29, 2016 10:03 AM
> To: dts@dpdk.org
> Cc: Xu, GangX
> Subject: [dts] [PATCH V2] fix IndexError on FreeBSD
> 
> restore interface before get interface
> 
> 
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>  nics/net_device.py | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/nics/net_device.py b/nics/net_device.py
> index bbe4bed..0eac48d 100644
> --- a/nics/net_device.py
> +++ b/nics/net_device.py
> @@ -218,7 +218,11 @@ class NetDevice(object):
>          """
>          Get the interface name by the default way on freebsd.
>          """
> -        pci_str = "%s:%s:%s" % (domain_id, bus_id, devfun_id)
> +        pci_str = "%s:%s:%s" % (domain_id, bus_id, devfun_id)
> +        put = self.__send_expect("kldstat", "# ",20)
> +        if "nic_uio.ko" in put:
> +            self.__send_expect("kldunload contigmem.ko", "# ",20)
> +            self.__send_expect("kldunload nic_uio.ko", "# ",20)
>          out = self.__send_expect("pciconf -l", "# ")
>          rexp = r"(\w*)@pci0:%s" % pci_str
>          pattern = re.compile(rexp)
> --
> 1.9.3