* [dts] [PATCH V2] fix IndexError on FreeBSD
@ 2016-11-29 2:03 xu,gang
2016-11-29 9:01 ` Liu, Yong
0 siblings, 1 reply; 2+ messages in thread
From: xu,gang @ 2016-11-29 2:03 UTC (permalink / raw)
To: dts; +Cc: xu,gang
restore interface before get interface
Signed-off-by: xu,gang <gangx.xu@intel.com>
---
nics/net_device.py | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/nics/net_device.py b/nics/net_device.py
index bbe4bed..0eac48d 100644
--- a/nics/net_device.py
+++ b/nics/net_device.py
@@ -218,7 +218,11 @@ class NetDevice(object):
"""
Get the interface name by the default way on freebsd.
"""
- pci_str = "%s:%s:%s" % (domain_id, bus_id, devfun_id)
+ pci_str = "%s:%s:%s" % (domain_id, bus_id, devfun_id)
+ put = self.__send_expect("kldstat", "# ",20)
+ if "nic_uio.ko" in put:
+ self.__send_expect("kldunload contigmem.ko", "# ",20)
+ self.__send_expect("kldunload nic_uio.ko", "# ",20)
out = self.__send_expect("pciconf -l", "# ")
rexp = r"(\w*)@pci0:%s" % pci_str
pattern = re.compile(rexp)
--
1.9.3
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dts] [PATCH V2] fix IndexError on FreeBSD
2016-11-29 2:03 [dts] [PATCH V2] fix IndexError on FreeBSD xu,gang
@ 2016-11-29 9:01 ` Liu, Yong
0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2016-11-29 9:01 UTC (permalink / raw)
To: Xu, GangX, dts; +Cc: Xu, GangX
Gang,
Unbind driver is critical step in execution process. This action must be monitored and called properly.
NIC method "get_interface_name" maybe called in suite, if that will cause all later suites crashed.
My suggestion is that remove interface/mac/ipv6 address strip code in function "scan_ports_uncached_freebsd".
All those information should be available in function "rescan_ports_uncached_freebsd".
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang
> Sent: Tuesday, November 29, 2016 10:03 AM
> To: dts@dpdk.org
> Cc: Xu, GangX
> Subject: [dts] [PATCH V2] fix IndexError on FreeBSD
>
> restore interface before get interface
>
>
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
> nics/net_device.py | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/nics/net_device.py b/nics/net_device.py
> index bbe4bed..0eac48d 100644
> --- a/nics/net_device.py
> +++ b/nics/net_device.py
> @@ -218,7 +218,11 @@ class NetDevice(object):
> """
> Get the interface name by the default way on freebsd.
> """
> - pci_str = "%s:%s:%s" % (domain_id, bus_id, devfun_id)
> + pci_str = "%s:%s:%s" % (domain_id, bus_id, devfun_id)
> + put = self.__send_expect("kldstat", "# ",20)
> + if "nic_uio.ko" in put:
> + self.__send_expect("kldunload contigmem.ko", "# ",20)
> + self.__send_expect("kldunload nic_uio.ko", "# ",20)
> out = self.__send_expect("pciconf -l", "# ")
> rexp = r"(\w*)@pci0:%s" % pci_str
> pattern = re.compile(rexp)
> --
> 1.9.3
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-29 9:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-29 2:03 [dts] [PATCH V2] fix IndexError on FreeBSD xu,gang
2016-11-29 9:01 ` Liu, Yong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).