test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Xu, HuilongX" <huilongx.xu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xu, HuilongX" <huilongx.xu@intel.com>
Subject: Re: [dts] [PATCH V1] fix kni ping/stress
Date: Wed, 14 Dec 2016 08:17:27 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62D166EF@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1481527734-28062-1-git-send-email-huilongx.xu@intel.com>

Thanks Huilong. Two comments below.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong
> Sent: Monday, December 12, 2016 3:29 PM
> To: dts@dpdk.org
> Cc: Xu, HuilongX
> Subject: [dts] [PATCH V1] fix kni ping/stress
> 
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> ---
>  tests/TestSuite_kni.py | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/TestSuite_kni.py b/tests/TestSuite_kni.py
> index 18bd768..432526e 100644
> --- a/tests/TestSuite_kni.py
> +++ b/tests/TestSuite_kni.py
> @@ -574,12 +574,13 @@ class TestKni(TestCase):
> 
>              out = self.dut.send_expect("ping6 -w 1 -I %s %s" %
>                                         (virtual_interface,
> str(ipv6_address)), "# ", 10)
> -            self.verify("64 bytes from %s: icmp_seq=1 ttl=64" %
> +            # some os ping6 out info not same
> +            self.verify("64 bytes from %s" %
>                          ipv6_address in out, "ping6 not supported")
> 
Not sure what's the difference here, please give some descriptions.

>              out = self.tester.send_expect(
>                  "ping6 -w 1 -I %s %s" % (tx_interface, str(ipv6_address)),
> "# ", 10)
> -            self.verify("64 bytes from %s: icmp_seq=1 ttl=64" %
> +            self.verify("64 bytes from %s" %
>                          ipv6_address in out, "kni cannot reply ping6
> packet")
> 
>              ipv6list = list(ipv6_address)
> @@ -806,14 +807,13 @@ class TestKni(TestCase):
>              try:
>                  out = self.start_kni(step['lo_mode'],
> step['kthread_mode'])
>                  self.verify("Error" not in out, "Error found during kni
> start")
> +                # kni setup out info by kernel debug function. so should
> re-build kenel.
> +                # now not check kni setup out info, only check kni setup
> ok and setup no error output
> +                out = self.dut.send_expect('ps -aux', "]# ")
>              except:
>                  # some permutations have to fail
>                  pass
> 
> -            out = self.dut.send_expect('dmesg -c | grep "KNI"', "]# ")
> -            self.verify(len(re.findall(expectedMessage, out, re.DOTALL)) >
> 0,
> -                        "Module not properly loaded")
> -
After removed check with kernel message, we should add check with kernel process. 
Please add it.

>      def test_perf_loopback(self):
>          """
>          KNI loopback performance
> --
> 1.9.3

      reply	other threads:[~2016-12-14  8:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-12  7:28 xu,huilong
2016-12-14  8:17 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E62D166EF@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=huilongx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).