Re: [dts] [PATCH V1] fix kni ping/stress

["Liu, Yong" <yong.liu@intel.com>]

Thanks Huilong. Two comments below.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong
> Sent: Monday, December 12, 2016 3:29 PM
> To: dts@dpdk.org
> Cc: Xu, HuilongX
> Subject: [dts] [PATCH V1] fix kni ping/stress
> 
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> ---
>  tests/TestSuite_kni.py | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/TestSuite_kni.py b/tests/TestSuite_kni.py
> index 18bd768..432526e 100644
> --- a/tests/TestSuite_kni.py
> +++ b/tests/TestSuite_kni.py
> @@ -574,12 +574,13 @@ class TestKni(TestCase):
> 
>              out = self.dut.send_expect("ping6 -w 1 -I %s %s" %
>                                         (virtual_interface,
> str(ipv6_address)), "# ", 10)
> -            self.verify("64 bytes from %s: icmp_seq=1 ttl=64" %
> +            # some os ping6 out info not same
> +            self.verify("64 bytes from %s" %
>                          ipv6_address in out, "ping6 not supported")
> 
Not sure what's the difference here, please give some descriptions.

>              out = self.tester.send_expect(
>                  "ping6 -w 1 -I %s %s" % (tx_interface, str(ipv6_address)),
> "# ", 10)
> -            self.verify("64 bytes from %s: icmp_seq=1 ttl=64" %
> +            self.verify("64 bytes from %s" %
>                          ipv6_address in out, "kni cannot reply ping6
> packet")
> 
>              ipv6list = list(ipv6_address)
> @@ -806,14 +807,13 @@ class TestKni(TestCase):
>              try:
>                  out = self.start_kni(step['lo_mode'],
> step['kthread_mode'])
>                  self.verify("Error" not in out, "Error found during kni
> start")
> +                # kni setup out info by kernel debug function. so should
> re-build kenel.
> +                # now not check kni setup out info, only check kni setup
> ok and setup no error output
> +                out = self.dut.send_expect('ps -aux', "]# ")
>              except:
>                  # some permutations have to fail
>                  pass
> 
> -            out = self.dut.send_expect('dmesg -c | grep "KNI"', "]# ")
> -            self.verify(len(re.findall(expectedMessage, out, re.DOTALL)) >
> 0,
> -                        "Module not properly loaded")
> -
After removed check with kernel message, we should add check with kernel process. 
Please add it.

>      def test_perf_loopback(self):
>          """
>          KNI loopback performance
> --
> 1.9.3